mirror of
https://github.com/scm-manager/scm-manager.git
synced 2025-11-06 05:25:44 +01:00
01bff1ce95
There may be a race condition when loading plugin bundles with lazy dependencies: The OpenAPI plugin depends on "redux" and "react-redux", which are bundled in the lazy "ui-legacy" module, as the usage of redux is deprecated in the scmm. The "ui-legacy" module also binds a global wrapper extension point around the whole app. Due to a bug in the plugin loader, plugin bundles were marked as successfully loaded even if a lazy dependency hadn't successfully loaded yet. This caused the extension point from the "ui-legacy" bundle to be bound after the initial render. As the process of extension point binding doesn't trigger a re-render, the redux provider was not wrapped around the app on initial load. When the user now moved focus out of and back into the window, react-query hooks automatically refetched e.g. the index links, which caused a re-render. Now with the bound extension point applied. This caused the whole app to be unmounted and re-mounted, which in turn reset all form fields anywhere below in the tree. Also fixes a bug where the global notifications component was executing a state update while already unmounted. Also fixes a bug in the user creation form where an object literal was passed to the form's default values which caused a form reset whenever the component re-rendered. Committed-by: Rene Pfeuffer <rene.pfeuffer@cloudogu.com>
66 lines
2.3 KiB
TypeScript
66 lines
2.3 KiB
TypeScript
/*
|
|
* MIT License
|
|
*
|
|
* Copyright (c) 2020-present Cloudogu GmbH and Contributors
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in all
|
|
* copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
import { useCallback, useEffect, useRef } from "react";
|
|
|
|
export const createQueryString = (params: Record<string, string>) => {
|
|
return Object.keys(params)
|
|
.map((k) => encodeURIComponent(k) + "=" + encodeURIComponent(params[k]))
|
|
.join("&");
|
|
};
|
|
|
|
export type CancelablePromise<T> = Promise<T> & { cancel: () => void };
|
|
|
|
export function makeCancelable<T>(promise: Promise<T>): CancelablePromise<T> {
|
|
let isCanceled = false;
|
|
const wrappedPromise = new Promise<T>((resolve, reject) => {
|
|
promise
|
|
.then((val) => (isCanceled ? reject({ isCanceled }) : resolve(val)))
|
|
.catch((error) => (isCanceled ? reject({ isCanceled }) : reject(error)));
|
|
});
|
|
return Object.assign(wrappedPromise, {
|
|
cancel() {
|
|
isCanceled = true;
|
|
},
|
|
});
|
|
}
|
|
|
|
export function useCancellablePromise() {
|
|
const promises = useRef<Array<CancelablePromise<unknown>>>();
|
|
|
|
useEffect(() => {
|
|
promises.current = promises.current || [];
|
|
return function cancel() {
|
|
promises.current?.forEach((p) => p.cancel());
|
|
promises.current = [];
|
|
};
|
|
}, []);
|
|
|
|
return useCallback(<T>(p: Promise<T>) => {
|
|
const cPromise = makeCancelable(p);
|
|
promises.current?.push(cPromise);
|
|
return cPromise;
|
|
}, []);
|
|
}
|