Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-04 20:45:52 +01:00
Code Issues Packages Projects Releases Activity

Fix tab order for primary navigation

Browse Source
This commit is contained in:
Eduard Heimbuch
2023-01-26 07:32:14 +01:00
committed by SCM-Manager
parent dc60c924ed
commit b2a253ea29
5 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gradle/changelog/tab_index.yaml Normal file
View File

@@ -0,0 +1,2 @@
- type: fixed
description: Fix tab order for primary navigation

9
scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
View File

@@ -70974,7 +70974,6 @@ exports[`Storyshots Repositories/RepositoryEntry Archived 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>
@@ -71100,7 +71099,6 @@ exports[`Storyshots Repositories/RepositoryEntry Avatar EP 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>
@@ -71229,7 +71227,6 @@ exports[`Storyshots Repositories/RepositoryEntry Before Title EP 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>
@@ -71355,7 +71352,6 @@ exports[`Storyshots Repositories/RepositoryEntry Default 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>
@@ -71494,7 +71490,6 @@ exports[`Storyshots Repositories/RepositoryEntry Exporting 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>
@@ -71634,7 +71629,6 @@ exports[`Storyshots Repositories/RepositoryEntry HealthCheck Failure 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>
@@ -71785,7 +71779,6 @@ exports[`Storyshots Repositories/RepositoryEntry MultiRepositoryTags 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>
@@ -71925,7 +71918,6 @@ exports[`Storyshots Repositories/RepositoryEntry RepositoryFlag EP 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>
@@ -72051,7 +72043,6 @@ exports[`Storyshots Repositories/RepositoryEntry With long texts 1`] = `
<a
className="RepositoryEntry__ContactActionWrapper-sc-6jys82-3 gtjNed is-size-5"
href="mailto:heart-of-gold@hitchhiker.com"
tabIndex={1}
target="_blank"
title="overview.contact"
>

1
scm-ui/ui-components/src/repos/RepositoryEntry.tsx
View File

@@ -121,7 +121,6 @@ const RepositoryEntry: FC<Props> = ({ repository, baseDate }) => {
target="_blank"
className={"is-size-5"}
title={t("overview.contact", { contact: repository.contact })}
tabIndex={1}
>
{renderContactIcon()}
</ContactActionWrapper>

1
scm-ui/ui-webapp/src/components/HeaderDropDown.tsx
View File

@@ -193,6 +193,7 @@ const HeaderDropDown: FC<Props> = ({ className, icon, count, error, isLoading, m
className
)}
onClick={e => e.stopPropagation()}
tabIndex={0}
>
<DropDownTrigger
className={classNames("is-flex", "dropdown-trigger", "is-clickable")}

10
scm-ui/ui-webapp/src/containers/NavigationBar.tsx
View File

@@ -133,15 +133,15 @@ const NavigationBar: FC<Props> = ({ links }) => {
<span aria-hidden="true" />
</button>
</div>
<div className="is-active navbar-header-actions">
<Alerts className="navbar-item" />
<OmniSearch links={links} />
<Notifications className="navbar-item" />
</div>
<StyledMenuBar className={classNames("navbar-menu", { "is-active": burgerActive })}>
<div className="navbar-start">
<PrimaryNavigation links={links} />
</div>
<div className="is-active navbar-header-actions">
<Alerts className="navbar-item" />
<OmniSearch links={links} />
<Notifications className="navbar-item" />
</div>
<div className="navbar-end">
<LogoutButton burgerMode={burgerActive} links={links} />
<LoginButton burgerMode={burgerActive} links={links} />