Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-01-05 23:29:53 +01:00
Code Issues Packages Projects Releases Activity

fix review findings

Browse Source
This commit is contained in:
Eduard Heimbuch
2020-09-24 10:43:54 +02:00
parent b424bc8ff0
commit 23581e780d
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scm-webapp/src/main/java/sonia/scm/admin/ReleaseVersionChecker.java
View File

@@ -75,7 +75,7 @@ public class ReleaseVersionChecker {
return latestRelease;
}
// we cache that no new version was available to prevent request every time
LOG.info("No newer version found for SCM-Manager");
LOG.debug("No newer version found for SCM-Manager");
cache.put(CACHE_KEY, Optional.empty());
return Optional.empty();
}

1
scm-webapp/src/main/java/sonia/scm/api/v2/resources/AdminInfoResource.java
View File

@@ -63,6 +63,7 @@ public class AdminInfoResource {
@Produces(VndMediaType.ADMIN_INFO)
@Operation(summary = "Returns release info.", description = "Returns information about the latest release if a newer version of SCM-Manager is available.", tags = "AdminInfo")
@ApiResponse(responseCode = "200", description = "success")
@ApiResponse(responseCode = "204", description = "no newer version was found")
@ApiResponse(responseCode = "401", description = "not authenticated / invalid credentials")
@ApiResponse(
responseCode = "500",

2
scm-webapp/src/test/java/sonia/scm/api/v2/resources/UpdateInfoMapperTest.java
View File

@@ -57,6 +57,6 @@ class UpdateInfoMapperTest {
assertThat(dto.getLink()).isEqualTo(updateInfo.getLink());
assertThat(dto.getLatestVersion()).isEqualTo(updateInfo.getLatestVersion());
assertThat(dto.getLinks().getLinkBy("self").get().getHref()).isEqualTo("https://hitchhiker.com/scm/updateInfo");
assertThat(dto.getLinks().getLinkBy("self").get().getHref()).isEqualTo("https://hitchhiker.com/scm/v2/updateInfo");
}
}