Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-01-08 08:32:12 +01:00
Code Issues Packages Projects Releases Activity

Fix SonarQube issues

Browse Source
This commit is contained in:
Sebastian Sdorra
2020-10-26 16:55:22 +01:00
parent 4edb406420
commit 10d4f79302
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
scm-webapp/src/main/java/sonia/scm/net/ahc/DefaultAdvancedHttpClient.java
View File

@@ -307,7 +307,7 @@ public class DefaultAdvancedHttpClient extends AdvancedHttpClient
{
TrustManager[] trustAllCerts = new TrustManager[] {
new TrustAllTrustManager() };
SSLContext sc = SSLContext.getInstance("SSL");
SSLContext sc = SSLContext.getInstance("TLS");
sc.init(null, trustAllCerts, new java.security.SecureRandom());
connection.setSSLSocketFactory(sc.getSocketFactory());
@@ -337,7 +337,7 @@ public class DefaultAdvancedHttpClient extends AdvancedHttpClient
if (isProxyEnabled(request))
{
connection = openProxyConnection(request, url);
connection = openProxyConnection(url);
appendProxyAuthentication(connection);
}
else
@@ -347,7 +347,9 @@ public class DefaultAdvancedHttpClient extends AdvancedHttpClient
logger.trace("ignore proxy settings");
}
logger.debug("fetch {}", url.toExternalForm());
if (logger.isDebugEnabled()) {
logger.debug("fetch {}", url.toExternalForm());
}
connection = createConnection(url);
}
@@ -355,8 +357,7 @@ public class DefaultAdvancedHttpClient extends AdvancedHttpClient
return connection;
}
private HttpURLConnection openProxyConnection(BaseHttpRequest<?> request,
URL url)
private HttpURLConnection openProxyConnection(URL url)
throws IOException
{
if (logger.isDebugEnabled())
@@ -392,5 +393,5 @@ public class DefaultAdvancedHttpClient extends AdvancedHttpClient
private final Provider<SSLContext> sslContextProvider;
/** tracer used for request tracing */
private Tracer tracer;
private final Tracer tracer;
}