Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-06 21:45:43 +01:00
Code Issues Packages Projects Releases Activity

Fixed test & removed unused code

Browse Source
This commit is contained in:
Philipp Czora
2018-09-18 13:14:29 +02:00
parent a34dad585e
commit 04599350b6
2 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scm-ui/src/changesets/modules/changesets.js
View File

@@ -111,15 +111,7 @@ function extractChangesetsByIds(data: any, oldChangesetsByIds: any) {
} }
//selectors //selectors
export function getChangesetsForNamespaceAndNameFromState(namespace: string, name: string, state: Object) { export function getChangesets(state: Object, namespace: string, name: string, branch?: string) {
const key = createItemId(namespace, name);
if (!state.changesets[key]) {
return null;
}
return Object.values(state.changesets[key].byId);
}
export function getChangesets(state: Object, namespace: string, name: string, branch: string) {
const key = createItemId(namespace, name, branch); const key = createItemId(namespace, name, branch);
if (!state.changesets[key]) { if (!state.changesets[key]) {
return null; return null;

4
scm-ui/src/changesets/modules/changesets.test.js
View File

@@ -12,7 +12,6 @@ import {
fetchChangesetsByNamespaceNameAndBranch, fetchChangesetsByNamespaceNameAndBranch,
fetchChangesetsSuccess, fetchChangesetsSuccess,
getChangesets, getChangesets,
getChangesetsForNamespaceAndNameFromState,
getFetchChangesetsFailure, getFetchChangesetsFailure,
isFetchChangesetsPending isFetchChangesetsPending
} from "./changesets"; } from "./changesets";
@@ -186,8 +185,7 @@ describe("changesets", () => {
} }
} }
}; };
// const result = getChangesetsForNamespaceAndNameFromState("foo", "bar", state); const result = getChangesets(state, "foo", "bar" );
const result = getChangesets("foo", "bar", "", state);
expect(result).toContainEqual({id: "id1"}) expect(result).toContainEqual({id: "id1"})
}); });