diff --git a/scm-ui/src/changesets/modules/changesets.js b/scm-ui/src/changesets/modules/changesets.js index 498f6b3aea..161f03d48f 100644 --- a/scm-ui/src/changesets/modules/changesets.js +++ b/scm-ui/src/changesets/modules/changesets.js @@ -111,15 +111,7 @@ function extractChangesetsByIds(data: any, oldChangesetsByIds: any) { } //selectors -export function getChangesetsForNamespaceAndNameFromState(namespace: string, name: string, state: Object) { - const key = createItemId(namespace, name); - if (!state.changesets[key]) { - return null; - } - return Object.values(state.changesets[key].byId); -} - -export function getChangesets(state: Object, namespace: string, name: string, branch: string) { +export function getChangesets(state: Object, namespace: string, name: string, branch?: string) { const key = createItemId(namespace, name, branch); if (!state.changesets[key]) { return null; diff --git a/scm-ui/src/changesets/modules/changesets.test.js b/scm-ui/src/changesets/modules/changesets.test.js index e206178538..fad8d8a6a8 100644 --- a/scm-ui/src/changesets/modules/changesets.test.js +++ b/scm-ui/src/changesets/modules/changesets.test.js @@ -12,7 +12,6 @@ import { fetchChangesetsByNamespaceNameAndBranch, fetchChangesetsSuccess, getChangesets, - getChangesetsForNamespaceAndNameFromState, getFetchChangesetsFailure, isFetchChangesetsPending } from "./changesets"; @@ -186,8 +185,7 @@ describe("changesets", () => { } } }; - // const result = getChangesetsForNamespaceAndNameFromState("foo", "bar", state); - const result = getChangesets("foo", "bar", "", state); + const result = getChangesets(state, "foo", "bar" ); expect(result).toContainEqual({id: "id1"}) });