Commit Graph

377 Commits

Author SHA1 Message Date
Toshi MARUYAMA
2829ddcc33 code cleanup: rubocop: fix Layout/BlockEndNewline in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18517 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:54:53 +00:00
Toshi MARUYAMA
d0ca6ad31d code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18516 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:54:42 +00:00
Toshi MARUYAMA
bb5706e2f9 code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in db/migrate/20170302015225_change_attachments_digest_limit_to_64.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18515 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:21:20 +00:00
Toshi MARUYAMA
a405e8f950 code cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18514 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:21:09 +00:00
Toshi MARUYAMA
7272399dc9 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18513 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:20:58 +00:00
Toshi MARUYAMA
4c9bef2ace code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/repository/bazaar.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:13:46 +00:00
Toshi MARUYAMA
e5f22bd28a code cleanup: rubocop: fix Style/NegatedIf in lib/redmine/scm/adapters/bazaar_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18511 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:13:35 +00:00
Toshi MARUYAMA
5ff3ed914e code cleanup: rubocop: fix Style/ColonMethodCall in lib/redmine/scm/adapters/bazaar_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18510 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:13:24 +00:00
Toshi MARUYAMA
fb221e8069 code cleanup: rubocop: fix Layout/SpaceInsideRangeLiteral in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18507 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 02:34:43 +00:00
Toshi MARUYAMA
3b379c076d code cleanup: rubocop: fix Style/EmptyLiteral in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18506 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 02:34:32 +00:00
Toshi MARUYAMA
949d80c6d2 code cleanup: rubocop: fix Performance/Casecmp in lib/redmine/scm/adapters/bazaar_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18504 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 15:54:38 +00:00
Toshi MARUYAMA
f66cc7db80 code cleanup: rubocop: fix Performance/Casecmp in lib/redmine/codeset_util.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18503 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 15:54:25 +00:00
Toshi MARUYAMA
8fb0ec3c3b code cleanup: rubocop: fix Style/RedundantConditional in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18502 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 14:14:28 +00:00
Toshi MARUYAMA
fe78039aea rubocop: disable Naming/BinaryOperatorParameterName
git-svn-id: http://svn.redmine.org/redmine/trunk@18501 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 14:11:19 +00:00
Toshi MARUYAMA
53aae425ba rubocop: disable Rails/HelperInstanceVariable
git-svn-id: http://svn.redmine.org/redmine/trunk@18500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 14:11:07 +00:00
Toshi MARUYAMA
7ffa505a02 rubocop: remove app/helpers/issues_helper.rb from Style/NestedTernaryOperator fixed by r18496
git-svn-id: http://svn.redmine.org/redmine/trunk@18499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 14:10:56 +00:00
Toshi MARUYAMA
7df0230d67 code cleanup: rubocop: fix Rails/Blank in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 06:39:36 +00:00
Toshi MARUYAMA
a6116a98c5 code cleanup: rubocop: fix Style/MultilineTernaryOperator in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18496 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 06:39:24 +00:00
Toshi MARUYAMA
fc243aa3ea code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in test/unit/repository_bazaar_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 06:32:29 +00:00
Toshi MARUYAMA
a02f498275 code cleanup: rubocop: fix Lint/ScriptPermission of Rakefile fixed by r18493
git-svn-id: http://svn.redmine.org/redmine/trunk@18494 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 18:12:59 +00:00
Toshi MARUYAMA
fd51a4fe58 code cleanup: rubocop: fix Style/CommentedKeyword in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:54 +00:00
Toshi MARUYAMA
188c560edc code cleanup: rubocop: fix Style/CommentAnnotation in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18491 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:42 +00:00
Toshi MARUYAMA
9f26eac4f0 code cleanup: rubocop: fix Style/ClassCheck in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18490 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:30 +00:00
Toshi MARUYAMA
c50e1facb4 rubocop: remove app/models/issue.rb from Lint/DuplicateMethods fixed by previous two revisions
git-svn-id: http://svn.redmine.org/redmine/trunk@18489 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:58 +00:00
Toshi MARUYAMA
7fb47e4b5e code cleanup: rubocop: fix Layout/LeadingCommentSpace in app/models/repository.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 13:58:30 +00:00
Toshi MARUYAMA
0c416338dd code cleanup: rubocop: fix Style/StringLiteralsInInterpolation in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 12:59:24 +00:00
Toshi MARUYAMA
aa8c59a389 code cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 06:11:15 +00:00
Toshi MARUYAMA
5611ee0e02 backout r13743
git-svn-id: http://svn.redmine.org/redmine/trunk@18478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 05:49:21 +00:00
Toshi MARUYAMA
c7c2bb2b24 code cleanup: rubocop: fix Lint/UselessSetterCall in test/unit/issue_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18477 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-18 01:56:43 +00:00
Toshi MARUYAMA
217b091143 code cleanup: rubocop: fix Layout/LeadingCommentSpace in app/controllers/repositories_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-15 15:08:49 +00:00
Toshi MARUYAMA
881c99f162 code cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/repositories_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-15 15:08:38 +00:00
Toshi MARUYAMA
7a488904fa code cleanup: rubocop: fix Layout/IndentationConsistency in test/functional/repositories_mercurial_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18470 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-14 19:03:31 +00:00
Toshi MARUYAMA
2e37562206 code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/functional/repositories_git_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18469 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-14 18:45:57 +00:00
Toshi MARUYAMA
81d6e24a8f code cleanup: rubocop: fix Layout/IndentationConsistency in test/functional/repositories_git_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18466 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-13 13:46:08 +00:00
Toshi MARUYAMA
e6324f3499 code cleanup: rubocop: fix Style/MethodCallWithoutArgsParentheses in test/functional/repositories_git_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18462 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-13 05:00:32 +00:00
Toshi MARUYAMA
452376ae65 rubocop: disable Naming/PredicateName
git-svn-id: http://svn.redmine.org/redmine/trunk@18461 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-13 02:25:23 +00:00
Toshi MARUYAMA
c22ba96c92 code cleanup: rubocop: fix Lint/HandleExceptions in lib/redmine/scm/adapters/mercurial_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-12 16:23:42 +00:00
Toshi MARUYAMA
c73884aee2 rubocop: use Lint/HandleExceptions AllowComments true
git-svn-id: http://svn.redmine.org/redmine/trunk@18457 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-12 16:23:31 +00:00
Toshi MARUYAMA
2edbd2a597 code cleanup: rubocop: fix Lint/AmbiguousOperator in lib/redmine/scm/adapters/mercurial_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18456 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-12 15:08:21 +00:00
Go MAEDA
e54f1b23ec Code cleanup: RuboCop: Fix Performance/RedundantMatch and Rails/DynamicFindBy in app/controllers/auto_completes_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18451 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-11 08:08:38 +00:00
Toshi MARUYAMA
dc657cb2c0 code cleanup: rubocop: fix Layout/SpaceInsideReferenceBrackets in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18448 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-11 05:51:02 +00:00
Toshi MARUYAMA
f26590189b code cleanup: rubocop: fix Layout/SpaceInsideReferenceBrackets in lib/redmine/scm/adapters/subversion_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18447 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-11 05:50:51 +00:00
Toshi MARUYAMA
75519b7158 code cleanup: rubocop: fix Layout/SpaceBeforeFirstArg in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18425 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-04 05:35:37 +00:00
Go MAEDA
ef856653ac Code cleanup: RuboCop: Fix Performance/InefficientHashSearch
git-svn-id: http://svn.redmine.org/redmine/trunk@18423 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-03 07:42:05 +00:00
Toshi MARUYAMA
7854b5073a code cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/redmine/scm/adapters/git_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18419 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-31 05:53:53 +00:00
Toshi MARUYAMA
d5764a2537 code cleanup: rubocop: fix Layout/LeadingCommentSpace in lib/redmine/scm/adapters/cvs_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18417 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-31 05:53:32 +00:00
Go MAEDA
fe0a89d7d1 CodeCleanup: RuboCop: Fix Style/RaiseArgs in app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18405 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 16:08:44 +00:00
Go MAEDA
26774d09e9 Code cleanup: RuboCop: Fix Style/UnneededCondition in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18397 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-26 07:16:55 +00:00
Go MAEDA
0898910b10 RuboCop: Disable Layout/SpaceInsideBlockBraces
git-svn-id: http://svn.redmine.org/redmine/trunk@18393 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 15:33:53 +00:00
Go MAEDA
0553e8375c Code cleanup: RuboCop: Fix Lint/UnneededRequireStatement in app/models/wiki_page.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18392 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 05:04:48 +00:00