Toshi MARUYAMA
91c56e2cbd
code cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-09 02:05:25 +00:00
Toshi MARUYAMA
ae58969f64
code cleanup: rubocop: fix Style/RedundantBegin in lib/redmine/scm/adapters/git_adapter.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18626 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 14:09:40 +00:00
Toshi MARUYAMA
a55867fda3
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/issues_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 13:07:00 +00:00
Toshi MARUYAMA
28c29d19a8
code cleanup: rubocop: fix Style/HashSyntax in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18618 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 13:06:47 +00:00
Toshi MARUYAMA
6b5991b34e
use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids
...
WikiPage#deleted_attachment_ids is already defined in this class.
git-svn-id: http://svn.redmine.org/redmine/trunk@18617 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:45:22 +00:00
Toshi MARUYAMA
1c0b6075ee
use "attr_writer" instead of "attr_accessor" for QueryColumn#sortable
...
QueryColumn#sortable is already defined in this class.
git-svn-id: http://svn.redmine.org/redmine/trunk@18616 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:45:11 +00:00
Toshi MARUYAMA
21cc761b53
use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value
...
CustomFieldValue#value= is already defined in this class.
git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:44:54 +00:00
Toshi MARUYAMA
6972d7e982
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc in test/unit/setting_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18614 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:44:42 +00:00
Toshi MARUYAMA
023c3455e6
code cleanup: rubocop: fix Layout/AlignArray in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18612 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:21:27 +00:00
Toshi MARUYAMA
7d70e5175a
code cleanup: rubocop: fix Layout/SpaceAfterColon in test/integration/wiki_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18611 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:21:14 +00:00
Toshi MARUYAMA
359802ac3b
code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18610 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:21:03 +00:00
Toshi MARUYAMA
ff3df17fee
code cleanup: rubocop: fix Layout/SpaceAfterColon in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:50 +00:00
Toshi MARUYAMA
a7f046ee7a
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18608 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:38 +00:00
Toshi MARUYAMA
af67ade563
code cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:26 +00:00
Toshi MARUYAMA
eee75cf080
code cleanup: rubocop: fix Layout/IndentHeredoc in test/functional/documents_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18606 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:13 +00:00
Toshi MARUYAMA
78b1838b68
rubocop: remove test/integration/attachments_test.rb from Layout/EmptyLinesAroundExceptionHandling fixed by r18593
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18604 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 02:32:36 +00:00
Toshi MARUYAMA
3c5d5df196
rubocop: remove test/functional/issues_controller_test.rb from Layout/IndentHeredoc and Layout/IndentationConsistency fixed by r18593
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18603 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 02:02:40 +00:00
Go MAEDA
df1c54146f
RuboCop: Disable Layout/SpaceInsideHashLiteralBraces
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 00:08:02 +00:00
Go MAEDA
545a050ba3
Code cleanup: RuboCop: Fix Performance/Count and Performance/Detect.
...
This change corrects newly detected offenses after updating rubocop-performance to 1.5.0 in r18579.
git-svn-id: http://svn.redmine.org/redmine/trunk@18580 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-02 00:53:11 +00:00
Go MAEDA
fff145a49d
Update rubocop-performance to 1.5.0 ( #31509 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18579 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-02 00:27:19 +00:00
Toshi MARUYAMA
30f3fea023
fix Redmine::Themes#scan_themes is not private
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18578 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-01 05:07:27 +00:00
Toshi MARUYAMA
c343588fa7
fix Watcher#prune_single_user is not private
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18577 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-01 05:07:16 +00:00
Go MAEDA
cd7a5c2f2f
Update RuboCop to 0.75.0 ( #31509 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18576 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-01 03:18:39 +00:00
Toshi MARUYAMA
c4df67dcaf
fix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_subtasks
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18569 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 12:47:52 +00:00
Toshi MARUYAMA
c087649dfb
rubocop: remove app/models/issue.rb from Layout/ElseAlignment fixed by previous revisions
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18568 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:59 +00:00
Toshi MARUYAMA
2795d1edc3
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_helper.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18564 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:15 +00:00
Toshi MARUYAMA
90d7d58728
rubocop: remove test/integration/api_test/issues_test.rb from Layout/IndentationConsistency fixed by previous revisions
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18563 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 10:59:13 +00:00
Toshi MARUYAMA
b3955c935e
code cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/issues_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18562 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 10:59:01 +00:00
Toshi MARUYAMA
9237457518
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/issues_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18561 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 10:58:50 +00:00
Toshi MARUYAMA
4bd1cbfd70
rubocop: remove app/models/attachment.rb from Layout/EmptyLineBetweenDefs fixed by r18558
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18560 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 10:58:39 +00:00
Toshi MARUYAMA
ca411ddca7
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 09:00:06 +00:00
Toshi MARUYAMA
a8c1fc77ef
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/attachment.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18558 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:54 +00:00
Toshi MARUYAMA
fb04274fc0
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/helpers/application_helper.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18557 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:43 +00:00
Toshi MARUYAMA
ad110b965f
code cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18556 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:26 +00:00
Toshi MARUYAMA
d4f491847d
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/unit/changeset_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18555 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:14 +00:00
Toshi MARUYAMA
cc8750f7dd
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18554 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 02:44:32 +00:00
Toshi MARUYAMA
b5b2f499f5
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/api_test/issues_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 02:44:21 +00:00
Toshi MARUYAMA
ea3c11bf32
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation in test/integration/api_test/issues_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18538 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 17:55:26 +00:00
Toshi MARUYAMA
2e1da01790
code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18537 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 17:55:14 +00:00
Toshi MARUYAMA
7349477b1a
code cleanup: rubocop: fix Style/WhileUntilModifier in test/application_system_test_case.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18533 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 14:12:18 +00:00
Toshi MARUYAMA
83d5633a5f
code cleanup: rubocop: fix Style/TrailingCommaInArguments in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18529 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 11:18:59 +00:00
Toshi MARUYAMA
97fb2876d5
rubocop: remove config/initializers/30-redmine.rb from Style/MultilineTernaryOperator fixed by r18521
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18528 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 11:18:48 +00:00
Toshi MARUYAMA
2dab26cef1
rubocop: disable Naming/AccessorMethodName
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18526 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 04:35:40 +00:00
Toshi MARUYAMA
6c7794d300
rubocop: disable Lint/IneffectiveAccessModifier
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18525 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 04:35:29 +00:00
Toshi MARUYAMA
591d0eae79
code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:56:51 +00:00
Toshi MARUYAMA
9a5cb65b9e
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18522 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:43:56 +00:00
Toshi MARUYAMA
e7ba3cf008
code cleanup: rubocop: fix Rails/Presence in config/initializers/30-redmine.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18521 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:42:13 +00:00
Toshi MARUYAMA
fe6b965fd5
code cleanup: rubocop: fix Rails/Presence in config/initializers/10-patches.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18520 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:42:02 +00:00
Toshi MARUYAMA
e83313240f
code cleanup: rubocop: fix Rails/Presence in db/migrate/20110228000100_copy_repositories_log_encoding.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18519 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:41:50 +00:00
Toshi MARUYAMA
947fdf100d
code cleanup: rubocop: fix Rails/Presence in lib/redmine/scm/adapters/cvs_adapter.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18518 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:41:39 +00:00