Commit Graph

201 Commits

Author SHA1 Message Date
Go MAEDA
6ef0a4c4cc Use HTTP status code 403 instead of 401 when REST API is disabled (#30086).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-04-10 02:51:28 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
29063283da Ajax Request Returns 200 but an error event is fired instead of success (#30073).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17849 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-05 08:33:29 +00:00
Jean-Philippe Lang
3ba51f205d Let admins unarchive the project when trying to access an archived project (#29993).
git-svn-id: http://svn.redmine.org/redmine/trunk@17682 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-02 11:23:10 +00:00
Go MAEDA
679cf413ab Log exception's message when ActionView::MissingTemplate is raised (#26341).
Patch by Vincent Robert.


git-svn-id: http://svn.redmine.org/redmine/trunk@17174 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-11 12:29:52 +00:00
Jean-Philippe Lang
2eaabae252 Don't redirect anonymous users to the login form when module is disabled (#26145).
git-svn-id: http://svn.redmine.org/redmine/trunk@16726 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-26 21:04:34 +00:00
Jean-Philippe Lang
310060ff57 Code cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@16725 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-26 20:51:28 +00:00
Jean-Philippe Lang
e7c0e16a3f Use regular #authorize method.
git-svn-id: http://svn.redmine.org/redmine/trunk@16724 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-26 20:41:12 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
f6defca16d redirect_to :back deprecated in Rails 5.
git-svn-id: http://svn.redmine.org/redmine/trunk@16596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-03 07:51:48 +00:00
Jean-Philippe Lang
da4f9ce34d Don't call #head with a hash.
git-svn-id: http://svn.redmine.org/redmine/trunk@16588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-01 18:28:18 +00:00
Jean-Philippe Lang
b9ee00a8c8 Adds methods to User model to handle tokens.
git-svn-id: http://svn.redmine.org/redmine/trunk@16474 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-04 17:15:07 +00:00
Toshi MARUYAMA
6139e0033a spelling fixes (#25495)
git-svn-id: http://svn.redmine.org/redmine/trunk@16445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-02 03:34:44 +00:00
Jean-Philippe Lang
6eaceed7b5 Delete :issue_query from session instead of :query.
git-svn-id: http://svn.redmine.org/redmine/trunk@16402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-14 18:20:47 +00:00
Jean-Philippe Lang
6a1865905f Don't redirect to lost password page after login (#13741).
Patch by Gregory Van der Steen.

git-svn-id: http://svn.redmine.org/redmine/trunk@16151 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-07 10:49:31 +00:00
Jean-Philippe Lang
3ccf7cf7ff Set user's localization before redirecting (#23346).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@15775 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-08-31 17:01:47 +00:00
Jean-Philippe Lang
8b107b6058 Don't use render :text => "".
git-svn-id: http://svn.redmine.org/redmine/trunk@15731 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-21 20:49:14 +00:00
Jean-Philippe Lang
57afa5345e Don't pass conditions to #delete_all.
git-svn-id: http://svn.redmine.org/redmine/trunk@15675 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-16 10:30:45 +00:00
Jean-Philippe Lang
9e20edf2d4 Don't generate URL from params.
git-svn-id: http://svn.redmine.org/redmine/trunk@15659 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 07:43:34 +00:00
Jean-Philippe Lang
ee82a55602 Use .before_action instead of .before_filter.
git-svn-id: http://svn.redmine.org/redmine/trunk@15655 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 07:27:31 +00:00
Jean-Philippe Lang
f694839c82 Code cleanup (#23054).
git-svn-id: http://svn.redmine.org/redmine/trunk@15534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-15 18:24:02 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
5d70fce6ce Security notifications when password or email adress is changed (#21421).
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@15145 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-02-05 07:33:24 +00:00
Jean-Philippe Lang
c9ae44e85b Fix Non ASCII attachment filename encoding broken (MOJIBAKE) in Microsoft Edge Explorer (#21656).
Patch by by Hang Xie.

git-svn-id: http://svn.redmine.org/redmine/trunk@15013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-01-09 08:37:07 +00:00
Jean-Philippe Lang
4cd22dcc55 Keep track of valid user sessions (#21058).
git-svn-id: http://svn.redmine.org/redmine/trunk@14735 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-24 10:15:22 +00:00
Jean-Philippe Lang
4714b31002 Preload issues custom values for bulk operations.
git-svn-id: http://svn.redmine.org/redmine/trunk@14730 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-23 16:51:46 +00:00
Jean-Philippe Lang
7356e18d36 Include helper instead of patching (#20508).
git-svn-id: http://svn.redmine.org/redmine/trunk@14693 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-19 17:30:28 +00:00
Jean-Philippe Lang
032f2c9be6 Open redirect vulnerability (#19577).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@14560 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-09-13 14:35:20 +00:00
Jean-Philippe Lang
d6f389658b Require password re-entry for sensitive actions (#19851).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@14333 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-06-19 18:41:10 +00:00
Jean-Philippe Lang
51f7060aa8 Add the ability to expire passwords after a configurable number of days (#19458).
Patch by Holger Just and Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@14264 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-05-10 10:26:55 +00:00
Jean-Philippe Lang
ef2e75f072 Set a back_url when forcing new login after session expiration (#19655).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@14245 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-05-09 10:43:09 +00:00
Jean-Philippe Lang
840881c76a Use named routes.
git-svn-id: http://svn.redmine.org/redmine/trunk@14070 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-03-10 18:22:53 +00:00
Jean-Philippe Lang
e429d93945 Fixed that #require_login should respond for other request types (#19325).
git-svn-id: http://svn.redmine.org/redmine/trunk@14069 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-03-10 18:19:51 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
c0800b330c Error when adding user to group where he is already assigned (#18665).
git-svn-id: http://svn.redmine.org/redmine/trunk@13785 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-21 20:15:24 +00:00
Jean-Philippe Lang
6f3ab71f3f Localisation not set correctly on authenticity token errors (#18499).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@13670 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-29 15:16:59 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Jean-Baptiste Barth
b519aba63e Expire other sessions on password change (#17796).
Contributed by Jan Schulz-Hofen.


git-svn-id: http://svn.redmine.org/redmine/trunk@13412 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-09-16 21:38:54 +00:00
Jean-Philippe Lang
77b0abb79c Fixed: The error flash message on session expiration is not in the language of the user but of the user of the previous request (#17023).
git-svn-id: http://svn.redmine.org/redmine/trunk@13391 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-09-13 10:35:46 +00:00
Jean-Philippe Lang
0125ba14f6 Don't redirect to another suburi (#16530).
git-svn-id: http://svn.redmine.org/redmine/trunk@13213 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-07-05 09:02:38 +00:00
Toshi MARUYAMA
709211cb9c fix non-ascii attachment file name get corrupted in IE11 (#16711)
Contributed by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@13101 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-04-17 18:21:23 +00:00
Jean-Philippe Lang
4920bb9d4d Potentiel data leak in "Invalid form authenticity token" error screen (#16511).
git-svn-id: http://svn.redmine.org/redmine/trunk@13041 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-04-05 08:19:55 +00:00
Jean-Philippe Lang
380b0515d1 Fixed that back_url=/ param is ignored (#16467).
git-svn-id: http://svn.redmine.org/redmine/trunk@13040 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-04-05 08:11:28 +00:00
Jean-Philippe Lang
7567c3d8b2 Fixed back url verification (#16466).
git-svn-id: http://svn.redmine.org/redmine/trunk@13018 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-03-29 14:32:47 +00:00
Jean-Philippe Lang
58ff842d34 Trigger basic HTTP authentication only when Basic authorization header is present (#16107).
git-svn-id: http://svn.redmine.org/redmine/trunk@12915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-02-22 12:09:58 +00:00
Jean-Philippe Lang
98cbbdf7f1 Reverts r12855.
git-svn-id: http://svn.redmine.org/redmine/trunk@12856 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-02-07 11:45:25 +00:00
Jean-Philippe Lang
3d64938adc Adds JS response support to #render_error (#15760).
git-svn-id: http://svn.redmine.org/redmine/trunk@12855 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-02-07 09:26:27 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00