Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-10-31 02:15:52 +01:00
Code Issues Packages Projects Releases Activity
19,046 Commits 35 Branches 222 Tags
7e350f1585d51a754fde2bc6d0646e23870b898e
Commit Graph

201 Commits

Author SHA1 Message Date
Marius Balteanu
be07d4d01d Fixes "ArgumentError: wrong number of arguments (given 0, expected 1) in ApplicationController#find_model_object" in Rails 8 (#43205, #43230). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@24017 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-09-28 21:20:39 +00:00
Marius Balteanu
2d3b3b939e Add OAuth2 provider capability using doorkeeper gem (#24808). 
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23837 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-06-12 07:09:03 +00:00
Marius Balteanu
e56d84b632 Reverts r23835 due to wrong issue ID (#40856). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23836 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-06-12 07:05:01 +00:00
Marius Balteanu
ebdd1a40f4 Add OAuth2 provider capability using doorkeeper gem (#40856). 
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23835 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-06-11 20:30:44 +00:00
Go MAEDA
55d6b59b61 Simplify URL components omission in ApplicationController#verify_back_url (#41930). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23469 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-01-28 08:24:52 +00:00
Go MAEDA
7ccf349e36 Redirection after signing in fails when the back_url includes a port number (#41930). 
Patch by Kenta Kumojima (user:kumojima) and Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23465 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-01-28 05:49:12 +00:00
Go MAEDA
9fccf787a4 Remove navigation parameters from issue detail URLs after updates (#42073). 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23433 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2025-01-07 07:18:32 +00:00
Marius Balteanu
ffce07e785 Start working on replacing old icons with SVG icons (#23980): 
* Introduces IconsHelper with methods to render SVG icon from a sprite file.
* Adds SVG sprite file with icons mainly from Font Awesome, but also from Material Design Icons and Fluent UI System Icons (based on the work made by Takashi Kato (@tohosaku)).
* Replaces specific icons with new SVG icons.
* Temporarily keep all old CSS icon definitions for backard compatibility.



git-svn-id: https://svn.redmine.org/redmine/trunk@22988 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-29 21:46:40 +00:00
Go MAEDA
fdd90bab2b Fix RuboCop offenses Style/NegatedIf and Style/NegatedWhile (#39887, #7770). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22987 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-25 08:44:33 +00:00
Go MAEDA
b803bddb1f Fix "ArgumentError: Invalid response name: unprocessable_entity" with Rack 3.1.0+ in assert_response (#39889). 
Rack 3.1.0 changed the symbol for HTTP status code 422 from `:unprocessable_entity` to `:unprocessable_content`.
Due to the change, `assert_response(:unprocessable_entity, ...)` raises ArgumentError with Rack 3.1.0+.

This fix is a follow-up to r22837.


git-svn-id: https://svn.redmine.org/redmine/trunk@22876 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-12 16:09:37 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-02-26 22:55:54 +00:00
Marius Balteanu
b010054d69 Replaces @URI.parse@ with @Addressable::URI.parse(url)@ to enhance robustness of @validate_back_url@ (#31831). 
Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22710 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-02-13 23:17:09 +00:00
Marius Balteanu
353ac52d47 Stop appending the utf8 checkmark parameter to form URLs (#40190). 
Patch by Go MAEDA (@maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@22709 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-02-13 23:13:49 +00:00
Marius Balteanu
f0f1d49b56 Remove @rss_*@ deprecated methods (#36806). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22416 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-11-06 20:36:48 +00:00
Go MAEDA
32d2b1c42f Fix RuboCop offense Style/InverseMethods: Use present? instead of inverting blank? (#37248). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22152 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-03-25 01:32:23 +00:00
Go MAEDA
9d65eee424 Avoid double-render error with ApplicationController#find_optional_project (#38063). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22066 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-20 03:31:41 +00:00
Go MAEDA
0b6f4c6811 Ruby 2.7: Fix RuboCop offense Performance/MapCompact (#38134). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22055 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-17 01:38:27 +00:00
Go MAEDA
3942177f49 Fix RuboCop offense Performance/BlockGivenWithExplicitBlock (#38146). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22027 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-11 13:20:52 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-01 06:19:35 +00:00
Marius Balteanu
f286a6044b Deprecate and rename rss_* methods to atom_* methods (#15118). 
Patch by Mischa The Evil and Marius BĂLTEANU


git-svn-id: http://svn.redmine.org/redmine/trunk@21467 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-19 09:56:46 +00:00
Marius Balteanu
1db2566ff9 Disable API authentication with username and password when two-factor authentication is enabled for the user (#35001). 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21436 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-02-24 19:10:35 +00:00
Marius Balteanu
9cda1638bd Set default protect from forgery true (#36317). 
Patch by Takashi Kato.

git-svn-id: http://svn.redmine.org/redmine/trunk@21379 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-01-22 08:43:42 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-01-02 05:29:10 +00:00
Marius Balteanu
16b8d3c0be Fix typo (#33521). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21140 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-08-05 23:46:17 +00:00
Marius Balteanu
7e2f3352db Fix that updating an issue from context menu to a none value do not set the field to blank (#33521). 
Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@21139 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-08-05 23:41:01 +00:00
Go MAEDA
66fc9f463d Gracefully handle invalid query parameters for custom fields (#35312). 
Patch by Holger Just.


git-svn-id: http://svn.redmine.org/redmine/trunk@21012 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-05-28 03:58:01 +00:00
Go MAEDA
ec989a5420 Fix "DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: common/error_messages.api" (#29914, #34984). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20897 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-04-01 15:36:57 +00:00
Go MAEDA
a7b96ae2ab Reverts r20895 (#29914, #34985). 
Wrong issue number.


git-svn-id: http://svn.redmine.org/redmine/trunk@20896 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-04-01 15:34:21 +00:00
Go MAEDA
d67eeabd53 Fix "DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: common/error_messages.api" (#29914, #34985). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20895 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-04-01 15:27:33 +00:00
Go MAEDA
094628e694 Remove #filename_for_content_disposition for MS browsers (#29914, #32914). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20892 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-04-01 15:19:16 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069). 
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-03-25 06:58:56 +00:00
Go MAEDA
9783ba003d Fix hard-coded error messages in ApplicationController (#33232). 
Contributed by Kam Nazir.


git-svn-id: http://svn.redmine.org/redmine/trunk@20843 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-03-25 04:39:18 +00:00
Toshi MARUYAMA
745e4152f8 remove spaces inside {} of ApplicationController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20409 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-11-17 12:41:18 +00:00
Toshi MARUYAMA
834bc11cc9 use "do end" instead of {} at ApplicationController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20142 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-10-11 12:57:39 +00:00
Toshi MARUYAMA
a6b68a82c6 add space after comma to ApplicationController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20134 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-10-11 12:56:36 +00:00
Toshi MARUYAMA
d7e881617d add empty line after guard clause to ApplicationController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20046 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-09-17 15:49:06 +00:00
Go MAEDA
be7f5e21fa Adds a setting to disable/enable/require 2fa auth (#1237). 
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@19989 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-08-29 06:37:09 +00:00
Toshi MARUYAMA
562dea3aa8 avoid using rescue in its modifier form at ApplicationController#find_current_user 
git-svn-id: http://svn.redmine.org/redmine/trunk@19862 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-07-08 17:29:56 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069). 
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-03-03 00:24:10 +00:00
Jean-Philippe Lang
0cd14b3a4b Validate back_url everywhere (#32850). 
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19488 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-02-02 08:39:22 +00:00
Jean-Philippe Lang
b3cda4fd61 Expose validate_back_url as helper method (#32850). 
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19487 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-02-02 08:38:47 +00:00
Jean-Philippe Lang
914f57fefc Move duplicated back_url method from ApplicationHelper to ApplicationController (#32850). 
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@19486 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-02-02 08:38:01 +00:00
Go MAEDA
f7fcd111e9 Ruby 2.7: Regexp#match and Regexp#match? with a nil argument are deprecated (#32527, #31500). 
git-svn-id: http://svn.redmine.org/redmine/trunk@19324 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-11-30 05:40:40 +00:00
Toshi MARUYAMA
cb591d0af6 code layout clean up app/controllers/application_controller.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@19284 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-11-25 06:32:28 +00:00
Toshi MARUYAMA
4a60ebd848 cleanup: rubocop: fix Layout/SpaceInsideParens in app/controllers/application_controller.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@19253 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-11-24 13:18:21 +00:00
Toshi MARUYAMA
252450b44c code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@18821 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-10-22 12:41:21 +00:00
Go MAEDA
4082069c75 Update copyright year. 
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-25 07:36:06 +00:00
Go MAEDA
6d6ea928c8 Custom Exception classes should inherit StandardError instead of Exception (#31387). 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18187 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-21 23:53:10 +00:00
Go MAEDA
29403e710a Adds favorites and recently used projects lists to project jump box (#31355). 
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@18181 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-20 22:26:30 +00:00
Go MAEDA
f992df684f Small refactorization of avatar methods (#31391). 
* move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
* change default avatar size from 50 to 24 because most of the avatars are using the  size 24
* class 'gravatar' is always added and all custom classes are appended
* added user name as default title for avatar images
* added two new methods: @assignee_avatar@ and @author_avatar@

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18175 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-19 22:27:41 +00:00