Commit Graph

15271 Commits

Author SHA1 Message Date
Toshi MARUYAMA
1b02ee12f3 cleanup: rubocop: fix Style/AccessModifierDeclarations in lib/redmine/scm/adapters/git_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19119 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 05:38:24 +00:00
Toshi MARUYAMA
28d52aecc4 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters/git_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19118 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:06:03 +00:00
Toshi MARUYAMA
aa352d57a4 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19117 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:05:52 +00:00
Toshi MARUYAMA
007f634a20 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/scm/base.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19116 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:05:42 +00:00
Toshi MARUYAMA
b3c743b3ba cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/generators/redmine_plugin_model/redmine_plugin_model_generator.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19115 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:05:31 +00:00
Toshi MARUYAMA
b009d7165c cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/diff.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19114 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:05:21 +00:00
Toshi MARUYAMA
fb913285f6 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in lib/redmine/views/builders/structure.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:05:10 +00:00
Toshi MARUYAMA
2584615d37 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_formatting/markdown_html_parser_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19112 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:05:00 +00:00
Toshi MARUYAMA
79db2a69bd cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_formatting/textile_html_parser_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19111 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:04:49 +00:00
Toshi MARUYAMA
a3248e3e64 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/project_nested_set_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19110 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-21 04:04:39 +00:00
Toshi MARUYAMA
f20e125bc1 rubocop: disable Style/TrailingCommaInHashLiteral
git-svn-id: http://svn.redmine.org/redmine/trunk@19109 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 17:12:40 +00:00
Toshi MARUYAMA
8db904c401 rubocop: use "EnforcedStyle: empty" for Style/EmptyElse
git-svn-id: http://svn.redmine.org/redmine/trunk@19108 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 17:05:35 +00:00
Toshi MARUYAMA
58a2c91218 rubocop: remove Style/AsciiComments comment
git-svn-id: http://svn.redmine.org/redmine/trunk@19107 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 17:05:24 +00:00
Toshi MARUYAMA
33df60a6fa rubocop: move Layout/CaseIndentation exclude entry from .rubocop_todo.yml to .rubocop.yml
git-svn-id: http://svn.redmine.org/redmine/trunk@19106 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 17:05:13 +00:00
Toshi MARUYAMA
eb41a074ce cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/project_query.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19105 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:30:02 +00:00
Toshi MARUYAMA
ab37571a8e cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19104 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:29:52 +00:00
Toshi MARUYAMA
b131063315 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/time_entry_query.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19103 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:29:41 +00:00
Toshi MARUYAMA
bc348591f7 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/wiki_formatting/html_parser_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19102 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:29:30 +00:00
Toshi MARUYAMA
1708efbad0 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/themes_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19100 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:01:00 +00:00
Toshi MARUYAMA
c1e6d0bda2 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/access_control_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19099 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:00:49 +00:00
Toshi MARUYAMA
8192c56320 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in test/unit/lib/redmine/codeset_util_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19098 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:00:39 +00:00
Toshi MARUYAMA
3326956a62 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/query.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19097 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:00:28 +00:00
Toshi MARUYAMA
902d2d4f53 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/models/issue_query.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19096 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:00:16 +00:00
Toshi MARUYAMA
2a1b08f2e8 cleanup: rubocop: fix Layout/EmptyLinesAroundClassBody in app/controllers/previews_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19095 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 16:00:05 +00:00
Jean-Philippe Lang
97efebf08e Make sure we cannot create a ProjectQuery on a given project (#29482).
git-svn-id: http://svn.redmine.org/redmine/trunk@19093 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 15:53:04 +00:00
Jean-Philippe Lang
05e24edda9 Fixes the assertion so that it doesn't rely on the display order (#32436).
Patch by Kouhei Sutou.

git-svn-id: http://svn.redmine.org/redmine/trunk@19092 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 15:07:23 +00:00
Jean-Philippe Lang
977bbea725 Only admin users should be able to manage public queries on the project list (#29482).
Like for issues, project members with the "Manage public" queries are allowed to manage public queries inside their projects, not public global queries that are proposed on /issues.

git-svn-id: http://svn.redmine.org/redmine/trunk@19091 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-20 15:01:24 +00:00
Go MAEDA
18e6cc9cb6 Fix that text copied from some applications such as MS Office and LibreOffice is pasted as an image in addition to plain text (#32469, #3816).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@19089 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-19 02:33:50 +00:00
Go MAEDA
4a90acb49e Add missing fixture to TimelogControllerTest in order to fix random test failure (#32478).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19088 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-19 00:18:10 +00:00
Toshi MARUYAMA
bd00d16d0f rubocop: fix Lint/IneffectiveAccessModifier in app/models/auth_source_ldap.rb (#32470)
git-svn-id: http://svn.redmine.org/redmine/trunk@19085 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-16 13:10:51 +00:00
Toshi MARUYAMA
03e719b12b regenerate .rubocop_todo.yml (#32470)
git-svn-id: http://svn.redmine.org/redmine/trunk@19083 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-16 12:46:43 +00:00
Toshi MARUYAMA
829a14d431 cleanup: rubocop: fix Lint/ParenthesesAsGroupedExpression and Style/RedundantParentheses and Layout/SpaceAfterNot in test/helpers/application_helper_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19082 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-16 12:38:38 +00:00
Jean-Philippe Lang
1220a68cbd Reverts r18692 (#32470).
git-svn-id: http://svn.redmine.org/redmine/trunk@19079 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-16 10:31:48 +00:00
Go MAEDA
2dfa50ce85 Update capybara (~> 3.29.0) (#32453).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@19073 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-14 00:23:40 +00:00
Go MAEDA
5c0b2506b3 Update Rouge to 3.13.0 (#32468).
git-svn-id: http://svn.redmine.org/redmine/trunk@19072 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-13 23:40:31 +00:00
Go MAEDA
8d61eadfc5 Add missing fixture to Redmine::WikiFormatting::MacrosTest (#32444).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19071 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-13 22:08:53 +00:00
Go MAEDA
b5ce1b9cff Fix a Rubocop offense caused by r19065 (#16904).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19068 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-13 13:22:05 +00:00
Go MAEDA
30fd23b917 Fix that QueriesControllerTest fails due to r19065 (#16904).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19067 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-13 09:49:52 +00:00
Jean-Philippe Lang
9746ab7e5b Add anonymous user to author list in issue/time query (#16904).
Patch by Yuichi HARADA and Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@19065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-10 07:58:57 +00:00
Jean-Philippe Lang
4a447dda09 Add support for grouping by issue on timelog view (#32436).
Patch by Kouhei Sutou.

git-svn-id: http://svn.redmine.org/redmine/trunk@19063 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-10 07:56:47 +00:00
Jean-Philippe Lang
e23c480f22 Removed invalid association IssueCustomField#issue_custom_values (#32431).
Patch by Akira Matsuda.

git-svn-id: http://svn.redmine.org/redmine/trunk@19061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-10 07:54:24 +00:00
Go MAEDA
1c533c948b Adds "Target Version" column to the list of "Available columns" in "Spent time" tab (#30346).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-10 00:42:30 +00:00
Toshi MARUYAMA
e7121752c2 rubocop: enable Layout/AlignArguments
git-svn-id: http://svn.redmine.org/redmine/trunk@19058 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 18:17:25 +00:00
Toshi MARUYAMA
eb18ef819f cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_options_for_select_with_users_and_groups
git-svn-id: http://svn.redmine.org/redmine/trunk@19057 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 18:17:12 +00:00
Toshi MARUYAMA
6ea5d0c3c6 cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_options_for_select_with_selected
git-svn-id: http://svn.redmine.org/redmine/trunk@19056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 18:17:01 +00:00
Toshi MARUYAMA
0d6015be56 cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_principals_options_for_select_with_users
git-svn-id: http://svn.redmine.org/redmine/trunk@19055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 18:16:50 +00:00
Toshi MARUYAMA
28ae34b68f cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_thumbnail_tag
git-svn-id: http://svn.redmine.org/redmine/trunk@19054 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 18:16:38 +00:00
Toshi MARUYAMA
22bce3517b cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_link_to_attachment
git-svn-id: http://svn.redmine.org/redmine/trunk@19053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 18:16:27 +00:00
Toshi MARUYAMA
8e6014a9f8 cleanup: rubocop: fix Layout/AlignArguments in ApplicationHelperTest#test_section_edit_links
git-svn-id: http://svn.redmine.org/redmine/trunk@19052 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 18:16:15 +00:00
Toshi MARUYAMA
a3246bf5fa cleanup: rubocop: fix Layout/AlignArguments in test/integration/attachments_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19051 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 17:57:36 +00:00