Replaces the use of text_area with textarea (#43276).

git-svn-id: https://svn.redmine.org/redmine/trunk@24030 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-10-26 00:36:14 +02:00 · 2025-10-06 22:45:02 +00:00
parent c1bb1edefb
commit 4837c0fbe3
27 changed files with 34 additions and 34 deletions
--- a/app/helpers/settings_helper.rb
+++ b/app/helpers/settings_helper.rb
@@ -99,9 +99,9 @@ module SettingsHelper
      text_field_tag("settings[#{setting}]", setting_value(setting), options).html_safe
  end

-  def setting_text_area(setting, options={})
+  def setting_textarea(setting, options={})
    setting_label(setting, options).html_safe +
-      text_area_tag("settings[#{setting}]", setting_value(setting), options).html_safe
+      textarea_tag("settings[#{setting}]", setting_value(setting), options).html_safe
  end

  def setting_check_box(setting, options={})
--- a/app/views/auth_sources/_form_auth_source_ldap.html.erb
+++ b/app/views/auth_sources/_form_auth_source_ldap.html.erb
@@ -15,7 +15,7 @@
           :onfocus => "this.value=''; this.name='auth_source[account_password]';",
           :onchange => "this.name='auth_source[account_password]';" %></p>
  <p><%= f.text_field :base_dn, :required => true, :size => 60 %></p>
-  <p><%= f.text_area :filter, :size => 60, :label => :field_auth_source_ldap_filter %></p>
+  <p><%= f.textarea :filter, :size => 60, :label => :field_auth_source_ldap_filter %></p>
  <p><%= f.text_field :timeout, :size => 4 %></p>
  <p><%= f.check_box :onthefly_register, :label => :field_onthefly %></p>
 </div>
--- a/app/views/custom_fields/_form.html.erb
+++ b/app/views/custom_fields/_form.html.erb
@@ -5,7 +5,7 @@
 <div class="box tabular">
 <p><%= f.select :field_format, custom_field_formats_for_select(@custom_field), {}, :disabled => !@custom_field.new_record? %></p>
 <p><%= f.text_field :name, :size => 50, :required => true %></p>
-<p><%= f.text_area :description, :rows => 7 %></p>
+<p><%= f.textarea :description, :rows => 7 %></p>

 <% if @custom_field.format.multiple_supported %>
 <p>
--- a/app/views/custom_fields/formats/_list.html.erb
+++ b/app/views/custom_fields/formats/_list.html.erb
@@ -1,5 +1,5 @@
 <p>
-  <%= f.text_area :possible_values, :value => @custom_field.possible_values.to_a.join("\n"), :rows => 15, :required => true %>
+  <%= f.textarea :possible_values, :value => @custom_field.possible_values.to_a.join("\n"), :rows => 15, :required => true %>
  <em class="info"><%= l(:text_custom_field_possible_values_info) %></em>
 </p>
 <p><%= f.text_field(:default_value) %></p>
--- a/app/views/custom_fields/formats/_text.html.erb
+++ b/app/views/custom_fields/formats/_text.html.erb
@@ -3,4 +3,4 @@
 <% if @custom_field.class.name == "IssueCustomField" %>
 <p><%= f.check_box :full_width_layout %></p>
 <% end %>
-<p><%= f.text_area(:default_value, :rows => 5) %></p>
+<p><%= f.textarea(:default_value, :rows => 5) %></p>
--- a/app/views/documents/_form.html.erb
+++ b/app/views/documents/_form.html.erb
@@ -3,7 +3,7 @@
 <div class="box tabular">
  <p><%= f.select :category_id, DocumentCategory.active.collect {|c| [c.name, c.id]} %></p>
  <p><%= f.text_field :title, :required => true, :size => 60 %></p>
-  <p><%= f.text_area :description, :cols => 60, :rows => 15, :class => 'wiki-edit',
+  <p><%= f.textarea :description, :cols => 60, :rows => 15, :class => 'wiki-edit',
                    :data => {
                        :auto_complete => true
                    }.merge(list_autofill_data_attributes)
--- a/app/views/doorkeeper/applications/_form.html.erb
+++ b/app/views/doorkeeper/applications/_form.html.erb
@@ -3,7 +3,7 @@
  <p><%= f.text_field :name, :required => true %></p>

  <p>
-    <%= f.text_area :redirect_uri, :required => true, :size => 60, :label => :'activerecord.attributes.doorkeeper/application.redirect_uri' %>
+    <%= f.textarea :redirect_uri, :required => true, :size => 60, :label => :'activerecord.attributes.doorkeeper/application.redirect_uri' %>
    <em class="info">
      <%= t('doorkeeper.applications.help.redirect_uri') %>
    </em>
--- a/app/views/issue_statuses/_form.html.erb
+++ b/app/views/issue_statuses/_form.html.erb
@@ -2,7 +2,7 @@

 <div class="box tabular">
 <p><%= f.text_field :name, :required => true %></p>
-<p><%= f.text_area :description, :rows => 4 %></p>
+<p><%= f.textarea :description, :rows => 4 %></p>
 <% if Issue.use_status_for_done_ratio? %>
  <p><%= f.select :default_done_ratio, ((0..100).step(Setting.issue_done_ratio_interval.to_i).to_a.collect {|r| ["#{r} %", r]}), :include_blank => true, :label => :field_done_ratio %></p>
 <% end %>
--- a/app/views/issues/_edit.html.erb
+++ b/app/views/issues/_edit.html.erb
@@ -29,7 +29,7 @@
    <% end %>
    <% if @issue.notes_addable? %>
      <fieldset id="add_notes"><legend><%= l(:field_notes) %></legend>
-      <%= f.text_area :notes, :cols => 60, :rows => 10, :class => 'wiki-edit',
+      <%= f.textarea :notes, :cols => 60, :rows => 10, :class => 'wiki-edit',
            :data => {
                :auto_complete => true
            }.merge(list_autofill_data_attributes),
--- a/app/views/issues/_form.html.erb
+++ b/app/views/issues/_form.html.erb
@@ -33,7 +33,7 @@
 <p>
  <%= f.label_for_field :description, :required => @issue.required_attribute?('description') %>
  <%= content_tag 'span', :id => "issue_description_and_toolbar", :style => (@issue.new_record? ? nil : 'display:none') do %>
-    <%= f.text_area :description, :cols => 60, :accesskey => accesskey(:edit), :class => 'wiki-edit',
+    <%= f.textarea :description, :cols => 60, :accesskey => accesskey(:edit), :class => 'wiki-edit',
                   :rows => [[10, @issue.description.to_s.length / 50].max, 20].min,
                   :data => {
                       :auto_complete => true
--- a/app/views/issues/bulk_edit.html.erb
+++ b/app/views/issues/bulk_edit.html.erb
@@ -220,7 +220,7 @@

 <fieldset>
 <legend><%= l(:field_notes) %></legend>
-<%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit',
+<%= textarea_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit',
                  :data => {
                      :auto_complete => true
                  }.merge(list_autofill_data_attributes)
--- a/app/views/journals/_notes_form.html.erb
+++ b/app/views/journals/_notes_form.html.erb
@@ -3,7 +3,7 @@
             :method => 'put',
             :id => "journal-#{@journal.id}-form") do %>
    <%= label_tag "notes", l(:description_notes), :class => "hidden-for-sighted", :for => "journal_#{@journal.id}_notes" %>
-    <%= text_area_tag 'journal[notes]', @journal.notes, :id => "journal_#{@journal.id}_notes", :class => 'wiki-edit',
+    <%= textarea_tag 'journal[notes]', @journal.notes, :id => "journal_#{@journal.id}_notes", :class => 'wiki-edit',
          :rows => (@journal.notes.blank? ? 10 : [[10, @journal.notes.length / 50].max, 100].min),
          :data => {
              :auto_complete => true
--- a/app/views/mail_handler/new.html.erb
+++ b/app/views/mail_handler/new.html.erb
@@ -14,7 +14,7 @@

  <fieldset>
    <legend>Raw Email</legend>
-    <label><%= text_area_tag 'email', '', :style => 'width:95%; height:400px;' %></label>
+    <label><%= textarea_tag 'email', '', :style => 'width:95%; height:400px;' %></label>
  </fieldset>

  <fieldset>
--- a/app/views/messages/_form.html.erb
+++ b/app/views/messages/_form.html.erb
@@ -23,7 +23,7 @@

 <p>
 <%= label_tag "message_content", l(:description_message_content), :class => "hidden-for-sighted" %>
-<%= f.text_area :content, :cols => 80, :rows => 15, :class => 'wiki-edit', :id => 'message_content',
+<%= f.textarea :content, :cols => 80, :rows => 15, :class => 'wiki-edit', :id => 'message_content',
                :accesskey => accesskey(:edit),
                :data => {
                    :auto_complete => true
--- a/app/views/news/_form.html.erb
+++ b/app/views/news/_form.html.erb
@@ -9,8 +9,8 @@
  </p>
 <% end %>
 <p><%= f.text_field :title, :required => true, :size => 60 %></p>
-<p><%= f.text_area :summary, :cols => 60, :rows => 2 %></p>
-<p><%= f.text_area :description, :required => true, :cols => 60, :rows => 15, :class => 'wiki-edit',
+<p><%= f.textarea :summary, :cols => 60, :rows => 2 %></p>
+<p><%= f.textarea :description, :required => true, :cols => 60, :rows => 15, :class => 'wiki-edit',
                   :data => {
                       :auto_complete => true
                   }.merge(list_autofill_data_attributes)
--- a/app/views/news/show.html.erb
+++ b/app/views/news/show.html.erb
@@ -67,7 +67,7 @@
 <p><%= toggle_link l(:label_comment_add), "add_comment_form", :focus => "comment_comments" %></p>
 <%= form_tag({:controller => 'comments', :action => 'create', :id => @news}, :id => "add_comment_form", :style => "display:none;") do %>
 <div class="box">
-    <%= text_area 'comment', 'comments', :cols => 80, :rows => 15, :class => 'wiki-edit',
+    <%= textarea 'comment', 'comments', :cols => 80, :rows => 15, :class => 'wiki-edit',
                  :data => {
                    :auto_complete => true
                  }.merge(list_autofill_data_attributes)
--- a/app/views/projects/_form.html.erb
+++ b/app/views/projects/_form.html.erb
@@ -4,7 +4,7 @@
 <!--[form:project]-->
 <p><%= f.text_field :name, :required => true, :size => 60 %></p>

-<p><%= f.text_area :description, :rows => 8, :class => 'wiki-edit', :data => list_autofill_data_attributes %></p>
+<p><%= f.textarea :description, :rows => 8, :class => 'wiki-edit', :data => list_autofill_data_attributes %></p>
 <p><%= f.text_field :identifier, :required => true, :size => 60, :disabled => @project.identifier_frozen?, :maxlength => Project::IDENTIFIER_MAX_LENGTH %>
 <% unless @project.identifier_frozen? %>
  <em class="info"><%= l(:text_length_between, :min => 1, :max => Project::IDENTIFIER_MAX_LENGTH) %> <%= l(:text_project_identifier_info).html_safe %></em>
--- a/app/views/settings/_attachments.html.erb
+++ b/app/views/settings/_attachments.html.erb
@@ -5,10 +5,10 @@

 <p><%= setting_text_field :bulk_download_max_size, :size => 6 %> <%= l(:"number.human.storage_units.units.kb") %></p>

-<p><%= setting_text_area :attachment_extensions_allowed %>
+<p><%= setting_textarea :attachment_extensions_allowed %>
 <em class="info"><%= l(:text_comma_separated) %> <%= l(:label_example) %>: txt, png</em></p>

-<p><%= setting_text_area :attachment_extensions_denied %>
+<p><%= setting_textarea :attachment_extensions_denied %>
 <em class="info"><%= l(:text_comma_separated) %> <%= l(:label_example) %>: js, swf</em></p>

 <p><%= setting_text_field :file_max_size_displayed, :size => 6 %> <%= l(:"number.human.storage_units.units.kb") %></p>
--- a/app/views/settings/_general.html.erb
+++ b/app/views/settings/_general.html.erb
@@ -3,7 +3,7 @@
 <div class="box tabular settings">
 <p><%= setting_text_field :app_title, :size => 30 %></p>

-<p><%= setting_text_area :welcome_text, :cols => 60, :rows => 5, :class => 'wiki-edit', :data => list_autofill_data_attributes %></p>
+<p><%= setting_textarea :welcome_text, :cols => 60, :rows => 5, :class => 'wiki-edit', :data => list_autofill_data_attributes %></p>
 <%= wikitoolbar_for 'settings_welcome_text' %>


--- a/app/views/settings/_mail_handler.html.erb
+++ b/app/views/settings/_mail_handler.html.erb
@@ -2,7 +2,7 @@

 <div class="box tabular settings">
  <p>
-    <%= setting_text_area :mail_handler_body_delimiters, :rows => 5 %>
+    <%= setting_textarea :mail_handler_body_delimiters, :rows => 5 %>
    <label class="block">
      <%= setting_check_box :mail_handler_enable_regex_delimiters, :label => false %>
      <%= l(:setting_mail_handler_enable_regex) %>
@@ -10,7 +10,7 @@
    <em class="info"><%= l(:text_line_separated) %></em>
  </p>
  <p>
-    <%= setting_text_area :mail_handler_excluded_filenames %>
+    <%= setting_textarea :mail_handler_excluded_filenames %>
    <label class="block">
      <%= setting_check_box :mail_handler_enable_regex_excluded_filenames, :label => false %>
      <%= l(:setting_mail_handler_enable_regex) %>
--- a/app/views/settings/_notifications.html.erb
+++ b/app/views/settings/_notifications.html.erb
@@ -19,12 +19,12 @@
 </fieldset>

 <fieldset class="box"><legend><%= l(:setting_emails_header) %></legend>
-<%= setting_text_area :emails_header, :label => false, :class => 'wiki-edit', :rows => 5, :data => list_autofill_data_attributes %>
+<%= setting_textarea :emails_header, :label => false, :class => 'wiki-edit', :rows => 5, :data => list_autofill_data_attributes %>
 <%= wikitoolbar_for 'settings_emails_header' %>
 </fieldset>

 <fieldset class="box"><legend><%= l(:setting_emails_footer) %></legend>
-<%= setting_text_area :emails_footer, :label => false, :class => 'wiki-edit', :rows => 5, :data => list_autofill_data_attributes %>
+<%= setting_textarea :emails_footer, :label => false, :class => 'wiki-edit', :rows => 5, :data => list_autofill_data_attributes %>
 <%= wikitoolbar_for 'settings_emails_footer' %>
 </fieldset>

--- a/app/views/settings/_users.html.erb
+++ b/app/views/settings/_users.html.erb
@@ -3,10 +3,10 @@
  <div class="box tabular settings">
    <p><%= setting_text_field :max_additional_emails, :size => 6 %></p>

-    <p><%= setting_text_area :email_domains_allowed %>
+    <p><%= setting_textarea :email_domains_allowed %>
    <em class="info"><%= l(:text_comma_separated) %> <%= l(:label_example) %>: example.com, example.org</em></p>

-    <p><%= setting_text_area :email_domains_denied %>
+    <p><%= setting_textarea :email_domains_denied %>
    <em class="info"><%= l(:text_comma_separated) %> <%= l(:label_example) %>: .example.com, foo.example.org, example.net</em></p>

    <p><%= setting_check_box :unsubscribe %></p>
--- a/app/views/trackers/_form.html.erb
+++ b/app/views/trackers/_form.html.erb
@@ -11,7 +11,7 @@
        :required => true %>
 </p>
 <p><%= f.check_box :is_in_roadmap %></p>
-<p><%= f.text_area :description, :rows => 4 %></p>
+<p><%= f.textarea :description, :rows => 4 %></p>
 <p>
  <label><%= l(:field_core_fields) %></label>
  <% Tracker::CORE_FIELDS.each do |field| %>
--- a/app/views/users/_preferences.html.erb
+++ b/app/views/users/_preferences.html.erb
@@ -6,7 +6,7 @@
 <p><%= pref_fields.select :textarea_font, textarea_font_options %></p>
 <p><%= pref_fields.text_field :recently_used_projects, :size => 2 %></p>
 <p><%= pref_fields.select :history_default_tab, history_default_tab_options %></p>
-<p><%= pref_fields.text_area :toolbar_language_options, :rows => 4 %></p>
+<p><%= pref_fields.textarea :toolbar_language_options, :rows => 4 %></p>
 <p><%= pref_fields.select :default_issue_query, default_issue_query_options(@user), include_blank: l(:label_none) %></p>
 <p><%= pref_fields.select :default_project_query, default_project_query_options(@user), include_blank: l(:label_none) %></p>
 <% end %>
--- a/app/views/wiki/edit.html.erb
+++ b/app/views/wiki/edit.html.erb
@@ -13,7 +13,7 @@
 <%= error_messages_for 'content' %>

 <div class="box tabular">
-<%= text_area_tag 'content[text]', @text, :cols => 100, :rows => 25, :accesskey => accesskey(:edit),
+<%= textarea_tag 'content[text]', @text, :cols => 100, :rows => 25, :accesskey => accesskey(:edit),
                  :class => 'wiki-edit',
                  :data => {
                      :auto_complete => true
--- a/lib/redmine/field_format.rb
+++ b/lib/redmine/field_format.rb
@@ -438,11 +438,11 @@ module Redmine
      end

      def edit_tag(view, tag_id, tag_name, custom_value, options={})
-        view.text_area_tag(tag_name, custom_value.value, options.merge(:id => tag_id, :rows => 8))
+        view.textarea_tag(tag_name, custom_value.value, options.merge(:id => tag_id, :rows => 8))
      end

      def bulk_edit_tag(view, tag_id, tag_name, custom_field, objects, value, options={})
-        view.text_area_tag(tag_name, value, options.merge(:id => tag_id, :rows => 8)) +
+        view.textarea_tag(tag_name, value, options.merge(:id => tag_id, :rows => 8)) +
          '<br />'.html_safe +
          bulk_clear_tag(view, tag_id, tag_name, custom_field, value)
      end
--- a/lib/redmine/views/labelled_form_builder.rb
+++ b/lib/redmine/views/labelled_form_builder.rb
@@ -23,7 +23,7 @@ class Redmine::Views::LabelledFormBuilder < ActionView::Helpers::FormBuilder
  include Redmine::I18n

  (field_helpers.map(&:to_s) - %w(radio_button hidden_field fields_for check_box label) +
-        %w(date_select text_area)).each do |selector|
+        %w(date_selec)).each do |selector|
    src = <<-END_SRC
    def #{selector}(field, options = {})
      label_for_field(field, options) + super(field, options.except(:label)).html_safe