Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-16 10:16:03 +01:00
Code Issues Packages Projects Releases Activity

use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value

Browse Source 
CustomFieldValue#value= is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA
2019-10-07 11:44:54 +00:00
parent 6972d7e982
commit 21cc761b53
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.rubocop_todo.yml
View File

@@ -495,7 +495,6 @@ Lint/DeprecatedClassMethods:
Lint/DuplicateMethods: Lint/DuplicateMethods:
Exclude: Exclude:
- 'app/models/custom_field_value.rb'
- 'app/models/query.rb' - 'app/models/query.rb'
- 'app/models/wiki_page.rb' - 'app/models/wiki_page.rb'

3
app/models/custom_field_value.rb
View File

@@ -18,7 +18,8 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
class CustomFieldValue class CustomFieldValue
attr_accessor :custom_field, :customized, :value, :value_was attr_accessor :custom_field, :customized, :value_was
attr_reader :value
def initialize(attributes={}) def initialize(attributes={})
attributes.each do |name, v| attributes.each do |name, v|