From 21cc761b539817f9c60dba119e49b4a9842d2d90 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Mon, 7 Oct 2019 11:44:54 +0000 Subject: [PATCH] use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value CustomFieldValue#value= is already defined in this class. git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 1 - app/models/custom_field_value.rb | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b2aee54e2..cbaa842b8 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -495,7 +495,6 @@ Lint/DeprecatedClassMethods: Lint/DuplicateMethods: Exclude: - - 'app/models/custom_field_value.rb' - 'app/models/query.rb' - 'app/models/wiki_page.rb' diff --git a/app/models/custom_field_value.rb b/app/models/custom_field_value.rb index aa2e66145..8e4cda92a 100644 --- a/app/models/custom_field_value.rb +++ b/app/models/custom_field_value.rb @@ -18,7 +18,8 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. class CustomFieldValue - attr_accessor :custom_field, :customized, :value, :value_was + attr_accessor :custom_field, :customized, :value_was + attr_reader :value def initialize(attributes={}) attributes.each do |name, v|