mirror of
https://github.com/NodeBB/NodeBB.git
synced 2025-12-30 12:20:38 +01:00
Compare commits
16 Commits
v1.16.2-be
...
v1.16.2-be
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
44d9ac2a95 | ||
|
|
be01951c41 | ||
|
|
9095057223 | ||
|
|
efc4fc3ddc | ||
|
|
18a5f7d568 | ||
|
|
38b0b3e5f7 | ||
|
|
8e23b9d766 | ||
|
|
f6370cd6f5 | ||
|
|
becff8bc22 | ||
|
|
d168790612 | ||
|
|
a852b374e9 | ||
|
|
55835b3b72 | ||
|
|
a79707ef9a | ||
|
|
a68fc1dc50 | ||
|
|
536b66dc89 | ||
|
|
75d60bfaf2 |
@@ -99,7 +99,7 @@ define('admin/manage/categories', [
|
||||
}
|
||||
|
||||
Categories.throwCreateModal = function () {
|
||||
socket.emit('categories.getSelectCategories', {}, function (err, categories) {
|
||||
socket.emit('categories.getSelectCategories', { query: utils.params() }, function (err, categories) {
|
||||
if (err) {
|
||||
return app.alertError(err.message);
|
||||
}
|
||||
|
||||
@@ -114,7 +114,7 @@ define('admin/manage/category', [
|
||||
});
|
||||
|
||||
$('.copy-settings').on('click', function () {
|
||||
socket.emit('categories.getSelectCategories', {}, function (err, allCategories) {
|
||||
socket.emit('categories.getSelectCategories', { query: utils.params() }, function (err, allCategories) {
|
||||
if (err) {
|
||||
return app.alertError(err.message);
|
||||
}
|
||||
@@ -261,7 +261,7 @@ define('admin/manage/category', [
|
||||
}
|
||||
|
||||
Category.launchParentSelector = function () {
|
||||
socket.emit('categories.getSelectCategories', {}, function (err, allCategories) {
|
||||
socket.emit('categories.getSelectCategories', { query: utils.params() }, function (err, allCategories) {
|
||||
if (err) {
|
||||
return app.alertError(err.message);
|
||||
}
|
||||
|
||||
@@ -416,7 +416,7 @@ define('forum/chats', [
|
||||
roomid = '';
|
||||
}
|
||||
|
||||
var url = 'user/' + ajaxify.data.userslug + '/chats/' + roomid;
|
||||
var url = 'user/' + ajaxify.data.userslug + '/chats/' + roomid + window.location.search;
|
||||
if (self.fetch) {
|
||||
fetch(config.relative_path + '/api/' + url, { credentials: 'include' })
|
||||
.then(function (response) {
|
||||
|
||||
@@ -12,7 +12,7 @@ define('forum/topic/move', ['categorySelector', 'alerts'], function (categorySel
|
||||
Move.onComplete = onComplete;
|
||||
Move.moveAll = !tids;
|
||||
|
||||
socket.emit('categories.getMoveCategories', onCategoriesLoaded);
|
||||
socket.emit('categories.getMoveCategories', { query: utils.params() }, onCategoriesLoaded);
|
||||
};
|
||||
|
||||
function onCategoriesLoaded(err, categories) {
|
||||
|
||||
@@ -10,6 +10,13 @@ const socketHelpers = require('../socket.io/helpers');
|
||||
const websockets = require('../socket.io');
|
||||
const events = require('../events');
|
||||
|
||||
exports.setDefaultPostData = function (reqOrSocket, data) {
|
||||
data.uid = reqOrSocket.uid;
|
||||
data.req = exports.buildReqObject(reqOrSocket, { ...data });
|
||||
data.timestamp = Date.now();
|
||||
data.fromQueue = false;
|
||||
};
|
||||
|
||||
// creates a slimmed down version of the request object
|
||||
exports.buildReqObject = (req, payload) => {
|
||||
req = req || {};
|
||||
|
||||
@@ -33,10 +33,7 @@ topicsAPI.create = async function (caller, data) {
|
||||
|
||||
const payload = { ...data };
|
||||
payload.tags = payload.tags || [];
|
||||
payload.uid = caller.uid;
|
||||
payload.req = apiHelpers.buildReqObject(caller);
|
||||
payload.timestamp = Date.now();
|
||||
payload.fromQueue = false;
|
||||
apiHelpers.setDefaultPostData(caller, payload);
|
||||
|
||||
// Blacklist & Post Queue
|
||||
await meta.blacklist.test(caller.ip);
|
||||
@@ -57,16 +54,8 @@ topicsAPI.create = async function (caller, data) {
|
||||
};
|
||||
|
||||
topicsAPI.reply = async function (caller, data) {
|
||||
var payload = {
|
||||
tid: data.tid,
|
||||
uid: caller.uid,
|
||||
req: apiHelpers.buildReqObject(caller), // For IP recording
|
||||
content: data.content,
|
||||
timestamp: Date.now(),
|
||||
fromQueue: false,
|
||||
};
|
||||
|
||||
if (data.toPid) { payload.toPid = data.toPid; }
|
||||
const payload = { ...data };
|
||||
apiHelpers.setDefaultPostData(caller, payload);
|
||||
|
||||
// Blacklist & Post Queue
|
||||
await meta.blacklist.test(caller.ip);
|
||||
|
||||
@@ -45,16 +45,6 @@ module.exports = function (Categories) {
|
||||
category.backgroundImage = data.backgroundImage;
|
||||
}
|
||||
|
||||
const result = await plugins.hooks.fire('filter:category.create', { category: category, data: data });
|
||||
category = result.category;
|
||||
|
||||
|
||||
await db.setObject('category:' + category.cid, category);
|
||||
if (!category.descriptionParsed) {
|
||||
await Categories.parseDescription(category.cid, category.description);
|
||||
}
|
||||
await db.sortedSetsAdd(['categories:cid', 'cid:' + parentCid + ':children'], category.order, category.cid);
|
||||
|
||||
const defaultPrivileges = [
|
||||
'groups:find',
|
||||
'groups:read',
|
||||
@@ -70,12 +60,35 @@ module.exports = function (Categories) {
|
||||
'groups:topics:delete',
|
||||
];
|
||||
const modPrivileges = defaultPrivileges.concat([
|
||||
'groups:topics:schedule',
|
||||
'groups:posts:view_deleted',
|
||||
'groups:purge',
|
||||
]);
|
||||
await privileges.categories.give(defaultPrivileges, category.cid, 'registered-users');
|
||||
await privileges.categories.give(modPrivileges, category.cid, ['administrators', 'Global Moderators']);
|
||||
await privileges.categories.give(['groups:find', 'groups:read', 'groups:topics:read'], category.cid, ['guests', 'spiders']);
|
||||
const guestPrivileges = ['groups:find', 'groups:read', 'groups:topics:read'];
|
||||
|
||||
const result = await plugins.hooks.fire('filter:category.create', {
|
||||
category: category,
|
||||
data: data,
|
||||
defaultPrivileges: defaultPrivileges,
|
||||
modPrivileges: modPrivileges,
|
||||
guestPrivileges: guestPrivileges,
|
||||
});
|
||||
category = result.category;
|
||||
|
||||
await db.setObject(`category:${category.cid}`, category);
|
||||
if (!category.descriptionParsed) {
|
||||
await Categories.parseDescription(category.cid, category.description);
|
||||
}
|
||||
|
||||
await db.sortedSetAddBulk([
|
||||
['categories:cid', category.order, category.cid],
|
||||
[`cid:${parentCid}:children`, category.order, category.cid],
|
||||
['categories:name', 0, `${data.name.substr(0, 200).toLowerCase()}:${category.cid}`],
|
||||
]);
|
||||
|
||||
await privileges.categories.give(result.defaultPrivileges, category.cid, 'registered-users');
|
||||
await privileges.categories.give(result.modPrivileges, category.cid, ['administrators', 'Global Moderators']);
|
||||
await privileges.categories.give(result.guestPrivileges, category.cid, ['guests', 'spiders']);
|
||||
|
||||
cache.del(['categories:cid', 'cid:' + parentCid + ':children']);
|
||||
if (data.cloneFromCid && parseInt(data.cloneFromCid, 10)) {
|
||||
|
||||
@@ -7,6 +7,7 @@ const validator = require('validator');
|
||||
const meta = require('../meta');
|
||||
const plugins = require('../plugins');
|
||||
const middleware = require('../middleware');
|
||||
const helpers = require('../middleware/helpers');
|
||||
|
||||
exports.handle404 = function handle404(req, res) {
|
||||
const relativePath = nconf.get('relative_path');
|
||||
@@ -22,7 +23,13 @@ exports.handle404 = function handle404(req, res) {
|
||||
|
||||
if (isClientScript.test(req.url)) {
|
||||
res.type('text/javascript').status(404).send('Not Found');
|
||||
} else if (req.path.startsWith(relativePath + '/assets/uploads') || (req.get('accept') && !req.get('accept').includes('text/html')) || req.path === '/favicon.ico') {
|
||||
} else if (
|
||||
!res.locals.isAPI && (
|
||||
req.path.startsWith(`${relativePath}/assets/uploads`) ||
|
||||
(req.get('accept') && !req.get('accept').includes('text/html')) ||
|
||||
req.path === '/favicon.ico'
|
||||
)
|
||||
) {
|
||||
meta.errors.log404(req.path || '');
|
||||
res.sendStatus(404);
|
||||
} else if (req.accepts('html')) {
|
||||
@@ -41,8 +48,16 @@ exports.send404 = async function (req, res) {
|
||||
res.status(404);
|
||||
const path = String(req.path || '');
|
||||
if (res.locals.isAPI) {
|
||||
return res.json({ path: validator.escape(path.replace(/^\/api/, '')), title: '[[global:404.title]]' });
|
||||
return res.json({
|
||||
path: validator.escape(path.replace(/^\/api/, '')),
|
||||
title: '[[global:404.title]]',
|
||||
bodyClass: helpers.buildBodyClass(req, res),
|
||||
});
|
||||
}
|
||||
await middleware.buildHeaderAsync(req, res);
|
||||
res.render('404', { path: validator.escape(path), title: '[[global:404.title]]' });
|
||||
await res.render('404', {
|
||||
path: validator.escape(path),
|
||||
title: '[[global:404.title]]',
|
||||
bodyClass: helpers.buildBodyClass(req, res),
|
||||
});
|
||||
};
|
||||
|
||||
@@ -3,6 +3,7 @@
|
||||
|
||||
const nconf = require('nconf');
|
||||
const validator = require('validator');
|
||||
const qs = require('querystring');
|
||||
|
||||
const db = require('../database');
|
||||
const privileges = require('../privileges');
|
||||
@@ -42,7 +43,7 @@ categoryController.get = async function (req, res, next) {
|
||||
return next();
|
||||
}
|
||||
if (topicIndex < 0) {
|
||||
return helpers.redirect(res, '/category/' + categoryFields.slug);
|
||||
return helpers.redirect(res, `/category/${categoryFields.slug}?${qs.stringify(req.query)}`);
|
||||
}
|
||||
|
||||
if (!userPrivileges.read) {
|
||||
@@ -50,7 +51,7 @@ categoryController.get = async function (req, res, next) {
|
||||
}
|
||||
|
||||
if (!res.locals.isAPI && !req.params.slug && (categoryFields.slug && categoryFields.slug !== `${cid}/`)) {
|
||||
return helpers.redirect(res, `/category/${categoryFields.slug}`, true);
|
||||
return helpers.redirect(res, `/category/${categoryFields.slug}?${qs.stringify(req.query)}`, true);
|
||||
}
|
||||
|
||||
if (categoryFields.link) {
|
||||
@@ -86,7 +87,7 @@ categoryController.get = async function (req, res, next) {
|
||||
}
|
||||
|
||||
if (topicIndex > Math.max(categoryData.topic_count - 1, 0)) {
|
||||
return helpers.redirect(res, '/category/' + categoryData.slug + '/' + categoryData.topic_count);
|
||||
return helpers.redirect(res, `/category/${categoryData.slug}/${categoryData.topic_count}?${qs.stringify(req.query)}`);
|
||||
}
|
||||
const pageCount = Math.max(1, Math.ceil(categoryData.topic_count / userSettings.topicsPerPage));
|
||||
if (userSettings.usePagination && currentPage > pageCount) {
|
||||
|
||||
@@ -1,10 +1,11 @@
|
||||
'use strict';
|
||||
|
||||
var nconf = require('nconf');
|
||||
var winston = require('winston');
|
||||
var validator = require('validator');
|
||||
var plugins = require('../plugins');
|
||||
var middleware = require('../middleware');
|
||||
const nconf = require('nconf');
|
||||
const winston = require('winston');
|
||||
const validator = require('validator');
|
||||
const plugins = require('../plugins');
|
||||
const middleware = require('../middleware');
|
||||
const helpers = require('../middleware/helpers');
|
||||
|
||||
exports.handleURIErrors = async function handleURIErrors(err, req, res, next) {
|
||||
// Handle cases where malformed URIs are passed in
|
||||
@@ -56,12 +57,17 @@ exports.handleErrors = function handleErrors(err, req, res, next) { // eslint-di
|
||||
|
||||
res.status(status || 500);
|
||||
|
||||
var path = String(req.path || '');
|
||||
const path = String(req.path || '');
|
||||
const data = {
|
||||
path: validator.escape(path),
|
||||
error: validator.escape(String(err.message)),
|
||||
bodyClass: helpers.buildBodyClass(req, res),
|
||||
};
|
||||
if (res.locals.isAPI) {
|
||||
res.json({ path: validator.escape(path), error: err.message });
|
||||
res.json(data);
|
||||
} else {
|
||||
await middleware.buildHeaderAsync(req, res);
|
||||
res.render('500', { path: validator.escape(path), error: validator.escape(String(err.message)) });
|
||||
res.render('500', data);
|
||||
}
|
||||
};
|
||||
|
||||
|
||||
@@ -106,6 +106,7 @@ modsController.flags.list = async function (req, res, next) {
|
||||
filters: filters,
|
||||
sort: sort,
|
||||
uid: req.uid,
|
||||
query: req.query,
|
||||
}),
|
||||
analytics.getDailyStatsForSet('analytics:flags', Date.now(), 30),
|
||||
categories.buildForSelect(req.uid, 'read'),
|
||||
|
||||
15
src/flags.js
15
src/flags.js
@@ -121,13 +121,13 @@ Flags.get = async function (flagId) {
|
||||
return data.flag;
|
||||
};
|
||||
|
||||
Flags.getCount = async function ({ uid, filters }) {
|
||||
Flags.getCount = async function ({ uid, filters, query }) {
|
||||
filters = filters || {};
|
||||
const flagIds = await Flags.getFlagIdsWithFilters({ filters, uid });
|
||||
const flagIds = await Flags.getFlagIdsWithFilters({ filters, uid, query });
|
||||
return flagIds.length;
|
||||
};
|
||||
|
||||
Flags.getFlagIdsWithFilters = async function ({ filters, uid }) {
|
||||
Flags.getFlagIdsWithFilters = async function ({ filters, uid, query }) {
|
||||
let sets = [];
|
||||
const orSets = [];
|
||||
|
||||
@@ -164,7 +164,13 @@ Flags.getFlagIdsWithFilters = async function ({ filters, uid }) {
|
||||
}
|
||||
}
|
||||
|
||||
return flagIds;
|
||||
const result = await plugins.hooks.fire('filter:flags.getFlagIdsWithFilters', {
|
||||
filters,
|
||||
uid,
|
||||
query,
|
||||
flagIds,
|
||||
});
|
||||
return result.flagIds;
|
||||
};
|
||||
|
||||
Flags.list = async function (data) {
|
||||
@@ -172,6 +178,7 @@ Flags.list = async function (data) {
|
||||
let flagIds = await Flags.getFlagIdsWithFilters({
|
||||
filters,
|
||||
uid: data.uid,
|
||||
query: data.query,
|
||||
});
|
||||
flagIds = await Flags.sort(flagIds, data.sort);
|
||||
|
||||
|
||||
@@ -109,6 +109,7 @@ middleware.renderHeader = async function renderHeader(req, res, data) {
|
||||
unreadCount: templateValues.unreadCount,
|
||||
} = await appendUnreadCounts({
|
||||
uid: req.uid,
|
||||
query: req.query,
|
||||
navigation: results.navigation,
|
||||
unreadData,
|
||||
}));
|
||||
@@ -152,16 +153,17 @@ middleware.renderHeader = async function renderHeader(req, res, data) {
|
||||
return await req.app.renderAsync('header', hookReturn.templateValues);
|
||||
};
|
||||
|
||||
async function appendUnreadCounts({ uid, navigation, unreadData }) {
|
||||
async function appendUnreadCounts({ uid, navigation, unreadData, query }) {
|
||||
const originalRoutes = navigation.map(nav => nav.originalRoute);
|
||||
const calls = {
|
||||
unreadData: topics.getUnreadData({ uid: uid }),
|
||||
unreadData: topics.getUnreadData({ uid: uid, query: query }),
|
||||
unreadChatCount: messaging.getUnreadCount(uid),
|
||||
unreadNotificationCount: user.notifications.getUnreadCount(uid),
|
||||
unreadFlagCount: (async function () {
|
||||
if (originalRoutes.includes('/flags') && await user.isPrivileged(uid)) {
|
||||
return flags.getCount({
|
||||
uid,
|
||||
query,
|
||||
filters: {
|
||||
quick: 'unresolved',
|
||||
cid: (await user.isAdminOrGlobalMod(uid)) ? [] : (await user.getModeratedCids(uid)),
|
||||
|
||||
@@ -1,5 +1,9 @@
|
||||
'use strict';
|
||||
|
||||
const winston = require('winston');
|
||||
const validator = require('validator');
|
||||
const slugify = require('../slugify');
|
||||
|
||||
const helpers = module.exports;
|
||||
|
||||
helpers.try = function (middleware) {
|
||||
@@ -20,3 +24,34 @@ helpers.try = function (middleware) {
|
||||
}
|
||||
};
|
||||
};
|
||||
|
||||
helpers.buildBodyClass = function (req, res, templateData = {}) {
|
||||
const clean = req.path.replace(/^\/api/, '').replace(/^\/|\/$/g, '');
|
||||
const parts = clean.split('/').slice(0, 3);
|
||||
parts.forEach((p, index) => {
|
||||
try {
|
||||
p = slugify(decodeURIComponent(p));
|
||||
} catch (err) {
|
||||
winston.error(err.stack);
|
||||
p = '';
|
||||
}
|
||||
p = validator.escape(String(p));
|
||||
parts[index] = index ? `${parts[0]}-${p}` : `page-${p || 'home'}`;
|
||||
});
|
||||
|
||||
if (templateData.template && templateData.template.topic) {
|
||||
parts.push(`page-topic-category-${templateData.category.cid}`);
|
||||
parts.push(`page-topic-category-${slugify(templateData.category.name)}`);
|
||||
}
|
||||
|
||||
if (Array.isArray(templateData.breadcrumbs)) {
|
||||
templateData.breadcrumbs.forEach((crumb) => {
|
||||
if (crumb && crumb.hasOwnProperty('cid')) {
|
||||
parts.push(`parent-category-${crumb.cid}`);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
parts.push(`page-status-${res.statusCode}`);
|
||||
return parts.join(' ');
|
||||
};
|
||||
|
||||
@@ -2,88 +2,96 @@
|
||||
|
||||
const nconf = require('nconf');
|
||||
const validator = require('validator');
|
||||
const winston = require('winston');
|
||||
|
||||
|
||||
const plugins = require('../plugins');
|
||||
const meta = require('../meta');
|
||||
const translator = require('../translator');
|
||||
const widgets = require('../widgets');
|
||||
const utils = require('../utils');
|
||||
const slugify = require('../slugify');
|
||||
const helpers = require('./helpers');
|
||||
|
||||
const relative_path = nconf.get('relative_path');
|
||||
|
||||
module.exports = function (middleware) {
|
||||
middleware.processRender = function processRender(req, res, next) {
|
||||
// res.render post-processing, modified from here: https://gist.github.com/mrlannigan/5051687
|
||||
const render = res.render;
|
||||
const { render } = res;
|
||||
|
||||
res.render = async function renderOverride(template, options, fn) {
|
||||
const self = this;
|
||||
const req = this.req;
|
||||
|
||||
options = options || {};
|
||||
if (typeof options === 'function') {
|
||||
fn = options;
|
||||
options = {};
|
||||
}
|
||||
|
||||
options.loggedIn = req.uid > 0;
|
||||
options.relative_path = relative_path;
|
||||
options.template = { name: template, [template]: true };
|
||||
options.url = (req.baseUrl + req.path.replace(/^\/api/, ''));
|
||||
options.bodyClass = buildBodyClass(req, res, options);
|
||||
|
||||
const buildResult = await plugins.hooks.fire(`filter:${template}.build`, { req: req, res: res, templateData: options });
|
||||
if (res.headersSent) {
|
||||
return;
|
||||
}
|
||||
const templateToRender = buildResult.templateData.templateToRender || template;
|
||||
|
||||
const renderResult = await plugins.hooks.fire('filter:middleware.render', { req: req, res: res, templateData: buildResult.templateData });
|
||||
if (res.headersSent) {
|
||||
return;
|
||||
}
|
||||
options = renderResult.templateData;
|
||||
options._header = {
|
||||
tags: await meta.tags.parse(req, renderResult, res.locals.metaTags, res.locals.linkTags),
|
||||
};
|
||||
options.widgets = await widgets.render(req.uid, {
|
||||
template: template + '.tpl',
|
||||
url: options.url,
|
||||
templateData: options,
|
||||
req: req,
|
||||
res: res,
|
||||
});
|
||||
res.locals.template = template;
|
||||
options._locals = undefined;
|
||||
|
||||
if (res.locals.isAPI) {
|
||||
if (req.route && req.route.path === '/api/') {
|
||||
options.title = '[[pages:home]]';
|
||||
const { req } = this;
|
||||
async function renderMethod(template, options, fn) {
|
||||
options = options || {};
|
||||
if (typeof options === 'function') {
|
||||
fn = options;
|
||||
options = {};
|
||||
}
|
||||
|
||||
options.loggedIn = req.uid > 0;
|
||||
options.relative_path = relative_path;
|
||||
options.template = { name: template, [template]: true };
|
||||
options.url = (req.baseUrl + req.path.replace(/^\/api/, ''));
|
||||
options.bodyClass = helpers.buildBodyClass(req, res, options);
|
||||
|
||||
const buildResult = await plugins.hooks.fire(`filter:${template}.build`, { req: req, res: res, templateData: options });
|
||||
if (res.headersSent) {
|
||||
return;
|
||||
}
|
||||
const templateToRender = buildResult.templateData.templateToRender || template;
|
||||
|
||||
const renderResult = await plugins.hooks.fire('filter:middleware.render', { req: req, res: res, templateData: buildResult.templateData });
|
||||
if (res.headersSent) {
|
||||
return;
|
||||
}
|
||||
options = renderResult.templateData;
|
||||
options._header = {
|
||||
tags: await meta.tags.parse(req, renderResult, res.locals.metaTags, res.locals.linkTags),
|
||||
};
|
||||
options.widgets = await widgets.render(req.uid, {
|
||||
template: `${template}.tpl`,
|
||||
url: options.url,
|
||||
templateData: options,
|
||||
req: req,
|
||||
res: res,
|
||||
});
|
||||
res.locals.template = template;
|
||||
options._locals = undefined;
|
||||
|
||||
if (res.locals.isAPI) {
|
||||
if (req.route && req.route.path === '/api/') {
|
||||
options.title = '[[pages:home]]';
|
||||
}
|
||||
req.app.set('json spaces', global.env === 'development' || req.query.pretty ? 4 : 0);
|
||||
return res.json(options);
|
||||
}
|
||||
|
||||
const results = await utils.promiseParallel({
|
||||
header: renderHeaderFooter('renderHeader', req, res, options),
|
||||
content: renderContent(render, templateToRender, req, res, options),
|
||||
footer: renderHeaderFooter('renderFooter', req, res, options),
|
||||
});
|
||||
|
||||
const str = `${results.header +
|
||||
(res.locals.postHeader || '') +
|
||||
results.content
|
||||
}<script id="ajaxify-data" type="application/json">${
|
||||
JSON.stringify(options).replace(/<\//g, '<\\/')
|
||||
}</script>${
|
||||
res.locals.preFooter || ''
|
||||
}${results.footer}`;
|
||||
|
||||
if (typeof fn !== 'function') {
|
||||
self.send(str);
|
||||
} else {
|
||||
fn(null, str);
|
||||
}
|
||||
req.app.set('json spaces', global.env === 'development' || req.query.pretty ? 4 : 0);
|
||||
return res.json(options);
|
||||
}
|
||||
|
||||
const results = await utils.promiseParallel({
|
||||
header: renderHeaderFooter('renderHeader', req, res, options),
|
||||
content: renderContent(render, templateToRender, req, res, options),
|
||||
footer: renderHeaderFooter('renderFooter', req, res, options),
|
||||
});
|
||||
|
||||
const str = results.header +
|
||||
(res.locals.postHeader || '') +
|
||||
results.content +
|
||||
'<script id="ajaxify-data" type="application/json">' +
|
||||
JSON.stringify(options).replace(/<\//g, '<\\/') +
|
||||
'</script>' +
|
||||
(res.locals.preFooter || '') +
|
||||
results.footer;
|
||||
|
||||
if (typeof fn !== 'function') {
|
||||
self.send(str);
|
||||
} else {
|
||||
fn(null, str);
|
||||
try {
|
||||
await renderMethod(template, options, fn);
|
||||
} catch (err) {
|
||||
next(err);
|
||||
}
|
||||
};
|
||||
|
||||
@@ -123,34 +131,4 @@ module.exports = function (middleware) {
|
||||
const translated = await translator.translate(str, language);
|
||||
return translator.unescape(translated);
|
||||
}
|
||||
|
||||
function buildBodyClass(req, res, templateData) {
|
||||
const clean = req.path.replace(/^\/api/, '').replace(/^\/|\/$/g, '');
|
||||
const parts = clean.split('/').slice(0, 3);
|
||||
parts.forEach(function (p, index) {
|
||||
try {
|
||||
p = slugify(decodeURIComponent(p));
|
||||
} catch (err) {
|
||||
winston.error(err.stack);
|
||||
p = '';
|
||||
}
|
||||
p = validator.escape(String(p));
|
||||
parts[index] = index ? parts[0] + '-' + p : 'page-' + (p || 'home');
|
||||
});
|
||||
|
||||
if (templateData.template.topic) {
|
||||
parts.push('page-topic-category-' + templateData.category.cid);
|
||||
parts.push('page-topic-category-' + slugify(templateData.category.name));
|
||||
}
|
||||
if (templateData.breadcrumbs) {
|
||||
templateData.breadcrumbs.forEach(function (crumb) {
|
||||
if (crumb.hasOwnProperty('cid')) {
|
||||
parts.push('parent-category-' + crumb.cid);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
parts.push('page-status-' + res.statusCode);
|
||||
return parts.join(' ');
|
||||
}
|
||||
};
|
||||
|
||||
@@ -123,6 +123,12 @@ Notifications.create = async function (data) {
|
||||
}
|
||||
const now = Date.now();
|
||||
data.datetime = now;
|
||||
const result = await plugins.hooks.fire('filter:notifications.create', {
|
||||
data: data,
|
||||
});
|
||||
if (!result.data) {
|
||||
return null;
|
||||
}
|
||||
await Promise.all([
|
||||
db.sortedSetAdd('notifications', now, data.nid),
|
||||
db.setObject('notifications:' + data.nid, data),
|
||||
|
||||
@@ -24,7 +24,7 @@ module.exports = function (Posts) {
|
||||
throw new Error('[[error:invalid-uid]]');
|
||||
}
|
||||
|
||||
if (data.toPid && !utils.isNumber(data.toPid)) {
|
||||
if (data.hasOwnProperty('toPid') && !utils.isNumber(data.toPid)) {
|
||||
throw new Error('[[error:invalid-pid]]');
|
||||
}
|
||||
|
||||
|
||||
@@ -282,7 +282,7 @@ async function getWatchedCids(data) {
|
||||
if (!data.categories.includes('watched')) {
|
||||
return [];
|
||||
}
|
||||
return await user.getCategoriesByStates(data.uid, [categories.watchStates.watching]);
|
||||
return await user.getWatchedCategories(data.uid);
|
||||
}
|
||||
|
||||
async function getChildrenCids(data) {
|
||||
|
||||
@@ -6,6 +6,7 @@ const user = require('../user');
|
||||
const topics = require('../topics');
|
||||
const api = require('../api');
|
||||
const sockets = require('.');
|
||||
const plugins = require('../plugins');
|
||||
|
||||
const SocketCategories = module.exports;
|
||||
|
||||
@@ -94,12 +95,17 @@ SocketCategories.getMoveCategories = async function (socket, data) {
|
||||
return await SocketCategories.getSelectCategories(socket, data);
|
||||
};
|
||||
|
||||
SocketCategories.getSelectCategories = async function (socket) {
|
||||
SocketCategories.getSelectCategories = async function (socket, data) {
|
||||
const [isAdmin, categoriesData] = await Promise.all([
|
||||
user.isAdministrator(socket.uid),
|
||||
categories.buildForSelect(socket.uid, 'find', ['disabled', 'link']),
|
||||
]);
|
||||
return categoriesData.filter(category => category && (!category.disabled || isAdmin) && !category.link);
|
||||
const result = await plugins.hooks.fire('filter:categories.getSelectCategories', {
|
||||
categories: categoriesData,
|
||||
isAdmin: isAdmin,
|
||||
query: data.query || {},
|
||||
});
|
||||
return result.categories.filter(category => category && (!category.disabled || isAdmin) && !category.link);
|
||||
};
|
||||
|
||||
SocketCategories.setWatchState = async function (socket, data) {
|
||||
|
||||
@@ -18,10 +18,8 @@ const apiHelpers = require('../api/helpers');
|
||||
const SocketHelpers = module.exports;
|
||||
|
||||
SocketHelpers.setDefaultPostData = function (data, socket) {
|
||||
data.uid = socket.uid;
|
||||
data.req = apiHelpers.buildReqObject(socket);
|
||||
data.timestamp = Date.now();
|
||||
data.fromQueue = false;
|
||||
websockets.warnDeprecated(socket, 'apiHelpers.setDefaultPostData');
|
||||
apiHelpers.setDefaultPostData(socket, data);
|
||||
};
|
||||
|
||||
SocketHelpers.notifyNew = async function (uid, type, result) {
|
||||
|
||||
@@ -10,6 +10,7 @@ const user = require('../user');
|
||||
const socketHelpers = require('./helpers');
|
||||
const utils = require('../utils');
|
||||
const api = require('../api');
|
||||
const apiHelpers = require('../api/helpers');
|
||||
|
||||
const sockets = require('.');
|
||||
const SocketPosts = module.exports;
|
||||
@@ -28,7 +29,7 @@ SocketPosts.reply = async function (socket, data) {
|
||||
throw new Error('[[error:invalid-data]]');
|
||||
}
|
||||
|
||||
socketHelpers.setDefaultPostData(data, socket);
|
||||
apiHelpers.setDefaultPostData(socket, data);
|
||||
await meta.blacklist.test(data.req.ip);
|
||||
const shouldQueue = await posts.shouldQueue(socket.uid, data);
|
||||
if (shouldQueue) {
|
||||
|
||||
@@ -4,6 +4,7 @@ const _ = require('lodash');
|
||||
|
||||
const db = require('../database');
|
||||
const categories = require('../categories');
|
||||
const plugins = require('../plugins');
|
||||
|
||||
module.exports = function (User) {
|
||||
User.setCategoryWatchState = async function (uid, cids, state) {
|
||||
@@ -36,14 +37,24 @@ module.exports = function (User) {
|
||||
if (!(parseInt(uid, 10) > 0)) {
|
||||
return [];
|
||||
}
|
||||
return await User.getCategoriesByStates(uid, [categories.watchStates.ignoring]);
|
||||
const cids = await User.getCategoriesByStates(uid, [categories.watchStates.ignoring]);
|
||||
const result = await plugins.hooks.fire('filter:user.getIgnoredCategories', {
|
||||
uid: uid,
|
||||
cids: cids,
|
||||
});
|
||||
return result.cids;
|
||||
};
|
||||
|
||||
User.getWatchedCategories = async function (uid) {
|
||||
if (!(parseInt(uid, 10) > 0)) {
|
||||
return [];
|
||||
}
|
||||
return await User.getCategoriesByStates(uid, [categories.watchStates.watching]);
|
||||
const cids = await User.getCategoriesByStates(uid, [categories.watchStates.watching]);
|
||||
const result = await plugins.hooks.fire('filter:user.getWatchedCategories', {
|
||||
uid: uid,
|
||||
cids: cids,
|
||||
});
|
||||
return result.cids;
|
||||
};
|
||||
|
||||
User.getCategoriesByStates = async function (uid, states) {
|
||||
|
||||
Reference in New Issue
Block a user