closes #3626

Added: 'filter:group.build' in group details controller.

package.json

@@ -2,7 +2,7 @@
   "name": "nodebb",
   "license": "GPL-3.0",
   "description": "NodeBB Forum",
-  "version": "0.8.1",
+  "version": "0.8.2",
   "homepage": "http://www.nodebb.org",
   "repository": {
     "type": "git",

public/src/admin/settings/general.js

@@ -6,9 +6,7 @@ define('admin/settings/general', ['admin/settings'], function(Settings) {
 
 	Module.init = function() {
 		$('button[data-action="removeLogo"]').on('click', function() {
-			socket.emit('admin.settings.removeLogo', function() {
-				app.alertSuccess('Logo removed');
-			});
+			$('input[data-field="brand:logo"]').val('');
 		});
 	};
 

src/categories/delete.js

@@ -4,15 +4,14 @@ var async = require('async'),
 	db = require('../database'),
 	batch = require('../batch'),
 	plugins = require('../plugins'),
-	threadTools = require('../threadTools');
-
+	topics = require('../topics');
 
 module.exports = function(Categories) {
 
 	Categories.purge = function(cid, callback) {
 		batch.processSortedSet('cid:' + cid + ':tids', function(tids, next) {
 			async.eachLimit(tids, 10, function(tid, next) {
-				threadTools.purge(tid, 0, next);
+				topics.purgePostsAndTopic(tid, next);
 			}, next);
 		}, {alwaysStartAt: 0}, function(err) {
 			if (err) {

src/controllers/categories.js

@@ -91,9 +91,6 @@ categoriesController.get = function(req, res, callback) {
 	async.waterfall([
 		function(next) {
 			async.parallel({
-				exists: function(next) {
-					categories.exists(cid, next);
-				},
 				categoryData: function(next) {
 					categories.getCategoryFields(cid, ['slug', 'disabled', 'topic_count'], next);
 				},
@@ -108,7 +105,7 @@ categoriesController.get = function(req, res, callback) {
 		function(results, next) {
 			userPrivileges = results.privileges;
 
-			if (!results.exists || (results.categoryData && parseInt(results.categoryData.disabled, 10) === 1)) {
+			if (!results.categoryData.slug || (results.categoryData && parseInt(results.categoryData.disabled, 10) === 1)) {
 				return callback();
 			}
 

src/controllers/groups.js

@@ -8,6 +8,7 @@ var async = require('async'),
 	groups = require('../groups'),
 	user = require('../user'),
 	helpers = require('./helpers'),
+	plugins = require('../plugins'),
 	groupsController = {};
 
 groupsController.list = function(req, res, next) {
@@ -93,7 +94,13 @@ groupsController.details = function(req, res, callback) {
 
 			results.title = '[[pages:group, ' + results.group.displayName + ']]';
 			results.breadcrumbs = helpers.buildBreadcrumbs([{text: '[[pages:groups]]', url: '/groups' }, {text: results.group.displayName}]);
-			res.render('groups/details', results);
+			
+			plugins.fireHook('filter:group.build', { req: req, res: res, templateData: results }, function (err, results) {
+				if(err) {
+					return callback(err);
+				}
+				res.render('groups/details', results.templateData);
+			});
 		});
 	});
 };

src/controllers/topics.js

@@ -40,6 +40,11 @@ topicsController.get = function(req, res, callback) {
 			}, next);
 		},
 		function (results, next) {
+
+			if (!results.topic.slug) {
+				return callback();
+			}
+
 			userPrivileges = results.privileges;
 
 			if (!userPrivileges.read || (parseInt(results.topic.deleted, 10) && !userPrivileges.view_deleted)) {

src/socket.io/admin.js

@@ -203,10 +203,6 @@ SocketAdmin.settings.clearSitemapCache = function(socket, data, callback) {
 	callback();
 };
 
-SocketAdmin.settings.removeLogo = function(socket, data, callback) {
-	db.setObjectField('config', 'brand:logo', '', callback);
-};
-
 SocketAdmin.email.test = function(socket, data, callback) {
 	if (plugins.hasListeners('action:email.send')) {
 		emailer.send('test', socket.uid, {

src/threadTools.js

@@ -66,7 +66,7 @@ var async = require('async'),
 	}
 
 	ThreadTools.purge = function(tid, uid, callback) {
-		var topic;
+		var cid;
 		async.waterfall([
 			function(next) {
 				topics.exists(tid, next);
@@ -82,23 +82,15 @@ var async = require('async'),
 					return next(new Error('[[error:no-privileges]]'));
 				}
 
-				topics.getTopicFields(tid, ['mainPid', 'cid'], next);
+				topics.getTopicField(tid, 'cid', next);
 			},
-			function (_topic, next) {
-				topic = _topic;
+			function (_cid, next) {
+				cid = _cid;
 
-				batch.processSortedSet('tid:' + tid + ':posts', function(pids, next) {
-					async.eachLimit(pids, 10, posts.purge, next);
-				}, {alwaysStartAt: 0}, next);
+				topics.purgePostsAndTopic(tid, next);
 			},
 			function (next) {
-				posts.purge(topic.mainPid, next);
-			},
-			function (next) {
-				topics.purge(tid, next);
-			},
-			function (next) {
-				next(null, {tid: tid, cid: topic.cid, uid: uid});
+				next(null, {tid: tid, cid: cid, uid: uid});
 			}
 		], callback);
 	};

src/topics/delete.js

@@ -5,7 +5,8 @@ var async = require('async'),
 
 	user = require('../user'),
 	posts = require('../posts'),
-	plugins = require('../plugins');
+	plugins = require('../plugins'),
+	batch = require('../batch');
 
 
 module.exports = function(Topics) {
@@ -80,6 +81,27 @@ module.exports = function(Topics) {
 		});
 	};
 
+	Topics.purgePostsAndTopic = function(tid, callback) {
+		var mainPid;
+		async.waterfall([
+			function (next) {
+				Topics.getTopicField(tid, 'mainPid', next);
+			},
+			function (_mainPid, next) {
+				mainPid = _mainPid;
+				batch.processSortedSet('tid:' + tid + ':posts', function(pids, next) {
+					async.eachLimit(pids, 10, posts.purge, next);
+				}, {alwaysStartAt: 0}, next);
+			},
+			function (next) {
+				posts.purge(mainPid, next);
+			},
+			function (next) {
+				Topics.purge(tid, next);
+			}
+		], callback);
+	};
+
 	Topics.purge = function(tid, callback) {
 		async.parallel([
 			function(next) {