feat: add data param to filter:categories.search

so plugins can do custom search for categories

install/package.json

@@ -2,7 +2,7 @@
     "name": "nodebb",
     "license": "GPL-3.0",
     "description": "NodeBB Forum",
-    "version": "1.18.4",
+    "version": "1.18.5",
     "homepage": "http://www.nodebb.org",
     "repository": {
         "type": "git",
@@ -182,4 +182,4 @@
             "url": "https://github.com/barisusakli"
         }
     ]
-}
+}

public/src/app.js

@@ -593,11 +593,14 @@ app.cacheBuster = null;
 		});
 
 		let ajaxified = false;
-		hooks.on('action:ajaxify.end', function () {
-			if (!ajaxify.isCold()) {
-				ajaxified = true;
-			}
+		require(['hooks'], function (hooks) {
+			hooks.on('action:ajaxify.end', function () {
+				if (!ajaxify.isCold()) {
+					ajaxified = true;
+				}
+			});
 		});
+
 		inputEl.on('focus', function () {
 			mousedownOnResults = false;
 			const query = inputEl.val();

public/src/client/topic.js

@@ -32,12 +32,6 @@ define('forum/topic', [
 			navigator.disable();
 			components.get('navbar/title').find('span').text('').hide();
 			app.removeAlert('bookmark');
-
-			require(['search'], function (search) {
-				if (search.topicDOM.active) {
-					search.topicDOM.end();
-				}
-			});
 		}
 	});
 
@@ -79,18 +73,6 @@ define('forum/topic', [
 	};
 
 	function handleTopicSearch() {
-		$('.topic-search').off('click')
-			.on('click', '.prev', function () {
-				require(['search'], function (search) {
-					search.topicDOM.prev();
-				});
-			})
-			.on('click', '.next', function () {
-				require(['search'], function (search) {
-					search.topicDOM.next();
-				});
-			});
-
 		if (config.topicSearchEnabled) {
 			require(['mousetrap'], function (mousetrap) {
 				mousetrap.bind(['command+f', 'ctrl+f'], function (e) {

src/categories/search.js

@@ -18,6 +18,7 @@ module.exports = function (Categories) {
 		let cids = await findCids(query, data.hardCap);
 
 		const result = await plugins.hooks.fire('filter:categories.search', {
+			data: data,
 			cids: cids,
 			uid: uid,
 		});

src/search.js

@@ -58,7 +58,7 @@ async function searchInContent(data) {
 	}
 	let pids = [];
 	let tids = [];
-	const inTopic = data.query.match(/^in:topic-([\d]+) /);
+	const inTopic = String(data.query || '').match(/^in:topic-([\d]+) /);
 	if (inTopic) {
 		const tid = inTopic[1];
 		const cleanedTerm = data.query.replace(inTopic[0], '');