Commit Graph

21215 Commits

Author SHA1 Message Date
Renovate Bot
b07fb9abca fix(deps): update dependency nodebb-plugin-composer-default to v6.5.2 2020-12-10 17:34:59 +00:00
Misty (Bot)
7eaedf4847 Latest translations and fallbacks 2020-12-10 09:07:57 +00:00
Julian Lam
05dd859714 fix: postgres is slow™️ 2020-12-09 19:23:23 -05:00
Julian Lam
f8dff94a15 fix: derp? 2020-12-09 19:05:26 -05:00
Julian Lam
9a4ea04a75 fix: attempted fix for psql test in topic thumbs 2020-12-09 18:57:45 -05:00
Julian Lam
9f62df15bd chore: appease codeclimate 2020-12-09 18:45:37 -05:00
Julian Lam
24e754d120 feat: add thumbs to category data return 2020-12-09 18:41:46 -05:00
Julian Lam
edf67f349f fix: use getSortedSetRange instead of getSortedSetsMembers 2020-12-09 17:12:59 -05:00
Julian Lam
bd5c4a5cff fix: tests 2020-12-09 16:46:19 -05:00
Julian Lam
e83baa97a0 fix: bad topic thumbs logic on local thumb upload 2020-12-09 16:30:11 -05:00
Julian Lam
ce8057f389 feat: broken test for bad topic thumbs logic 2020-12-09 16:23:31 -05:00
Julian Lam
3e54b70c06 fix: #9092, Topic thumbnails do not work with third-party uploaders 2020-12-09 15:47:58 -05:00
Julian Lam
dd448e2b1a fix: move topic thumb tests to root level, so they actually get run by mocha 2020-12-09 15:31:46 -05:00
Julian Lam
9681557f60 fix: tests for topic thumbs 2020-12-09 15:29:25 -05:00
Julian Lam
91899329fc chore(deps): bump persona to 10.3.9 2020-12-09 11:37:07 -05:00
Julian Lam
228cfa6710 chore(deps): bump composer to 6.5.1, re: #9067 2020-12-09 11:30:43 -05:00
Julian Lam
15f1a08940 chore(i18n): fallbacks for new topic thumb keys 2020-12-09 10:45:14 -05:00
Julian Lam
0db4912111 fix(deps): bump composer-default to 6.5.0 2020-12-09 10:42:41 -05:00
Julian Lam
2170c40007 fix: iteration logic bug 2020-12-09 10:42:41 -05:00
Julian Lam
ae9439748d fix: spec 2020-12-09 10:42:41 -05:00
Julian Lam
9342d611be fix: enable topic thumbnails across the board [breaking] 2020-12-09 10:42:41 -05:00
Julian Lam
a30c8ab5c8 feat: clent-side modal for managing topic thumbs
closes #9087
2020-12-09 10:42:41 -05:00
Julian Lam
67cf5e83b7 fix: changes to thumb resizing logic
- Resized thumb no longer skews aspect ratio
- Thumbs resized down to maximum thumb size by WIDTH only
- image.checkDimensions() now returns dimensions
2020-12-09 10:42:41 -05:00
Julian Lam
37c367d6ff feat: raise maximum thumb size to 512 2020-12-09 10:42:41 -05:00
Julian Lam
1c5cdb5121 feat: associate topic thumbs with post uploads (for the mainPid) 2020-12-09 10:42:41 -05:00
Julian Lam
08736b1812 fix: use file lib instead of direct fs module access 2020-12-09 10:42:41 -05:00
Julian Lam
c043cfebd6 fix: added back missing topic thumb tests that were removed in last commit 2020-12-09 10:42:41 -05:00
Julian Lam
5ec3b3d083 fix: tests 2020-12-09 10:42:41 -05:00
Julian Lam
d31aae167e fix(spec): broken link to status component 2020-12-09 10:42:41 -05:00
Julian Lam
cb7e4cda2a feat: helper method to get thumbs by pid 2020-12-09 10:42:41 -05:00
Julian Lam
41379e27c8 fix: hack uploader to handle a response from v3 write api 2020-12-09 10:42:41 -05:00
Julian Lam
340387c18a fix: #9055, non-standard API response from addThumbs route
Also removed old thumb upload router handler, and updated uploadPost handling in composer to match new response schema
2020-12-09 10:42:41 -05:00
Julian Lam
c09c238e3f fix: do not allow thumb deletion route to arbitrarily delete other files in uploads folder 2020-12-09 10:42:41 -05:00
Julian Lam
5950683316 feat: closes #9048, tests for topic thumbs routes, write API schema 2020-12-09 10:42:41 -05:00
Julian Lam
ef10b6b70d fix: missing file added 2020-12-09 10:42:41 -05:00
Julian Lam
4152aa552e feat: tests for topic thumbs
Also added some error checking to addThumbs controller
2020-12-09 10:42:41 -05:00
Julian Lam
ef7d6db912 feat: server-side work for #9047
- rename Thumbs.commit to Thumbs.migrate
- new PUT method that calls Thumbs.migrate
- `checkThumbPrivileges` now takes a single object parameter (ins. of req/res)
2020-12-09 10:42:41 -05:00
Julian Lam
b5d910f53b feat: core work for #9042, thumb deletion now accepts uuids
+ common data validation for thumb addition and deletion
2020-12-09 10:42:41 -05:00
Julian Lam
1f0c1cd229 fix: references to since-removed Topics.thumbs.resizeAndUpload 2020-12-09 10:42:41 -05:00
Julian Lam
90497e3ef5 feat: more work on topic thumbs refactor
- addThumb and deleteThumb are now protected routes (duh)
- new getThumbs route GET /api/v3/topics/<tid>/thumbs
- Updated `assert.path` middleware to better handle if relative paths are received with upload_url
- Slight refactor of thumbs lib to use validator to differentiate between tid and UUID
2020-12-09 10:42:41 -05:00
Julian Lam
43dc3e3e48 fix: #9041, remove Topics.thumbs.resizeAndUpload() 2020-12-09 10:42:41 -05:00
Julian Lam
708b1c338f fix: #9040 2020-12-09 10:42:41 -05:00
Julian Lam
1949d20a87 fix: spec 2020-12-09 10:42:41 -05:00
Julian Lam
1257aa981e feat: expose uploaded thumbnails to client-side via API
+ plugin hook: filter:topics.getThumbs
2020-12-09 10:42:41 -05:00
Julian Lam
7e9e08f718 feat: server-side routes for handling multiple topic thumbnails
closes #8994, requires 'topic-thumb-refactor' branch of composer-default
2020-12-09 10:42:41 -05:00
Julian Lam
98cd9e3549 feat: allow uploadThumb controller to be called in code
it, and uploadsController.upload() now return the results of their operation
2020-12-09 10:42:41 -05:00
Julian Lam
4fc9da81a9 refactor: topic thumbs lib to topics.thumbs 2020-12-09 10:42:41 -05:00
Barış Soner Uşaklı
0f480be658 fix: #9085, dont prevent admins from deleting other users 2020-12-09 10:15:30 -05:00
Barış Soner Uşaklı
ff2aa17bbc fix: show errors when user delete fails 2020-12-09 10:07:40 -05:00
Barış Soner Uşaklı
dd9ed23631 fix: dont start logout timer if adminReloginDuration is disabled 2020-12-09 09:56:09 -05:00