Commit Graph

12835 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
5694e62e59 fix: #10322 2022-02-18 17:22:14 -05:00
Julian Lam
17836f2a3a Re-introduce lodash into src/package-install.js (#10315)
* test: add failing test for if package.json is non-existant, fix tests' beforeEach method

* Revert "fix: #10289, remove lodash dependency in src/cli/package-install.js"

This reverts commit 81fa2e22bc.

* fix: regression caused by 94b79ce402

`./nodebb setup` was no longer able to be called without arguments or env vars

* fix: .updatePackageFile() throwing if no package.json

* fix: removing unneeded code in src/cli/index.js that seemed to be used to handle cases where package.json was missing (initial install)

... However, as .updatePackageFile() now handled cases where there is no package.json, it should be ok to remove this code

* fix: handle missing package.json or node_modules/
2022-02-17 14:10:24 -05:00
Julian Lam
4164898d85 fix: regression caused by 94b79ce402
`./nodebb setup` was no longer able to be called without arguments or env vars
2022-02-17 13:18:17 -05:00
Barış Soner Uşaklı
3acd2ac850 refactor: wrap around if at end
remove debug log
dont focus input on mobile
2022-02-17 11:19:43 -05:00
Barış Soner Uşaklı
b517b376ac feat: ability to go through your posts in a topic
because I am 👴 useful for large topics
2022-02-16 22:07:52 -05:00
Barış Soner Uşaklı
e9e48a756f feat: delete diffs on post purge, closes #10291 2022-02-16 13:23:27 -05:00
Barış Soner Uşaklı
9205169f00 fix: one last try 2022-02-15 20:51:52 -05:00
Barış Soner Uşaklı
2f64d63369 fix: doggy.gif 2022-02-15 20:22:22 -05:00
Barış Soner Uşaklı
cfdfbf3280 fix: one more fix 2022-02-15 20:21:21 -05:00
Barış Soner Uşaklı
770fcd9ea8 fix: dupe key errors 2022-02-15 20:12:42 -05:00
Barış Soner Uşaklı
dbf7a45828 fix: #10292, delete missing fields 2022-02-15 19:33:52 -05:00
Barış Soner Uşaklı
58b5781cea feat: closes #10296
asset_base_url in nconf
keep assetBaseUrl in config for backwards compat
2022-02-15 19:22:34 -05:00
ppenguin
94b79ce402 Allow NodeBB setup with env vars (#9850)
* initial try [WIP]

* typo; add test start script; initial Dockerfile mod with integrated setup [WIP]

* minor fixes

* add some winston debug...

* typos

* fix pass confirm setup

* more fixes

* fix entrypoint

* cleanup

* remove echo sensitive setupVal

* remove obsolete code and comments

* fix linting errors

* Merge branch 'additional-fixes'

* Merge branch 'pitaj-suggested-fixes'

* Merge branch 'pitaj-fixes2'

* merge checkSetup functions (env vars and flags)

* comment (lint)

* remove tab

* finalise PR; tested ok locally (setup json overrides env vars)
2022-02-15 13:13:43 -05:00
Julian Lam
fb78570c13 test: fix topic thumb tests and topic thumbs to work properly with post upload assoc. 2022-02-14 15:02:07 -05:00
Julian Lam
d5ed8736aa feat: deleting a user upload dissociates from posts, and vice versa 2022-02-14 15:02:07 -05:00
Julian Lam
8c2752bab1 test: user uploads.js tests 2022-02-14 15:02:07 -05:00
Julian Lam
11275d6809 test: testing user upload methods, already fixed one bug 2022-02-14 15:02:07 -05:00
Julian Lam
5d7e1ebc68 style: linting errors 2022-02-14 15:02:07 -05:00
Julian Lam
b9edee143e fix: local deleteUploads() method in src/user/delete.js to call User.deleteUpload() 2022-02-14 15:02:07 -05:00
Julian Lam
7ef9c7d220 refactor: .deleteUpload() to accept array of paths 2022-02-14 15:02:07 -05:00
Julian Lam
ea36016d87 refactor: fix user uploads paths, and associate uid with user uploads 2022-02-14 15:02:07 -05:00
Julian Lam
6489e9fd9e refactor: change the post uploads' hash seeds to have the files/ prefix 2022-02-14 15:02:07 -05:00
Julian Lam
84dfda59e6 fix: #10144, automatically delete uploads from disk on post purge, ACP option to keep uploads on disk if desired 2022-02-14 15:02:07 -05:00
Julian Lam
aad0c5fd51 refactor: abstract some common code out to local utility methods 2022-02-14 15:02:07 -05:00
Julian Lam
9aa3e442d0 fix: four-space indents in package.json 2022-02-14 14:40:34 -05:00
Julian Lam
81fa2e22bc fix: #10289, remove lodash dependency in src/cli/package-install.js 2022-02-14 14:36:50 -05:00
Julian Lam
6aae2e5d89 Revert "fix: proactively guard against homograph characters in website values"
This reverts commit fa7dcdb968.
2022-02-11 14:12:22 -05:00
Barış Soner Uşaklı
489c0d3015 refactor: remove extra zset remove, closes #10277 2022-02-11 10:43:40 -05:00
Julian Lam
1c7fb8fe11 fix: non-functional upgrade script 2022-02-10 15:19:56 -05:00
Barış Soner Uşaklı
350052ec50 fix: language keys 2022-02-09 17:50:08 -05:00
Barış Soner Uşaklı
d70ce3a937 fix: #10273, properly calculate item count for best/controversial 2022-02-09 17:42:41 -05:00
Barış Soner Uşaklı
b98758d30a chore: add missing quote 2022-02-08 12:28:51 -05:00
Julian Lam
a2c7d69e1b fix: remove extraneous devDependencies on package merge
/cc @pitaj
2022-02-08 11:13:51 -05:00
Barış Soner Uşaklı
5143ca33f3 feat: handle array of keys in psql exists for zsets 2022-02-07 17:54:51 -05:00
Julian Lam
0ac2843587 feat: upgrade script to clean up leftover :thumb zsets 2022-02-07 17:29:34 -05:00
Julian Lam
0f788b8eaa fix: #10257, topic thumbs not deleting on topic deletion 2022-02-07 17:29:34 -05:00
Julian Lam
606808760e test: add test to verify that a sorted set is automatically deleted if its last element is removed (#10261)
* test: add test to verify that a sorted set is automatically deleted if its last element is removed

* fix: remote empty zsets when all elements have been removed #yolo

* Revert "fix: remote empty zsets when all elements have been removed #yolo"

This reverts commit 0ac73244bb.

* fix: altered behaviour in module.exists instead of zrem
2022-02-07 17:16:50 -05:00
Barış Soner Uşaklı
08f2a05053 fix: #10255, create verified/unverified groups on install 2022-02-07 10:30:46 -05:00
Barış Soner Uşaklı
6be330f2d6 lint: remove unused require 2022-02-04 21:56:58 -05:00
Barış Soner Uşaklı
b548083b24 perf: increase batch size 2022-02-04 21:53:30 -05:00
Barış Soner Uşaklı
079c487dcb fix: controversial posts/bests posts not showing anything
fix upgrade script so posts with negative votes are stored, a post can have 10 upvotes and 2 downvotes
fix missing negative votes checks
remove unnecessary pids flters since the cids are only already filtered by topics:read
2022-02-04 21:52:44 -05:00
Julian Lam
d34471f69f fix: regression in package.json merging logic that caused extraneous packages to not be removed 2022-02-04 16:20:31 -05:00
Julian Lam
689c125cd3 fix: #10229, package merging should deep merge nested objects
+ tests
2022-02-04 16:20:31 -05:00
Julian Lam
cf88483fee feat: upgrade script to store downvotes posts in the user :votes sorted set 2022-02-04 14:33:58 -05:00
Julian Lam
5cff6e3f95 fix: bug where .reduce() exploded due to no initial value, if input value was an empty array 2022-02-04 14:33:58 -05:00
Julian Lam
5afd5de07d feat: new accounts route to show most downvoted ('controversial') posts 2022-02-04 14:33:58 -05:00
Barış Soner Uşaklı
45ca046533 Merge branch 'master' of https://github.com/NodeBB/NodeBB 2022-02-04 10:38:06 -05:00
Barış Soner Uşaklı
dcb201dfa8 fix: https://github.com/NodeBB/NodeBB/issues/10242 2022-02-04 10:37:59 -05:00
Julian Lam
ad63517511 fix: missing early return 2022-02-04 10:20:46 -05:00
Julian Lam
936562c3cb fix: handle case where email is explicitly passed into user.create, and thus is set in user hash, but confirmation request may have expired 2022-02-04 10:20:46 -05:00