Commit Graph

12835 Commits

Author SHA1 Message Date
Julian Lam
f38b2a737a fix: improper handling of single vs. multiple inputs for hidePrivateData 2022-06-29 16:19:52 -04:00
Julian Lam
ecf0e8ce22 fix: observe user-specific and ACP-specific hiding rules for fullname 2022-06-29 16:12:32 -04:00
Julian Lam
3f5ae893c6 refactor: allow user.hidePrivateData() to handle an array of userData 2022-06-29 16:10:04 -04:00
Julian Lam
17e44ff5c9 feat: fire hook to allow plugins to filter the pids returned in a user profile
/cc julianlam/nodebb-plugin-support-forum#14
2022-06-24 11:35:21 -04:00
Barış Soner Uşaklı
be917e8d39 feat: closes #10719, don't trim children if category is marked section 2022-06-24 11:35:21 -04:00
Julian Lam
0d68643bcb Revert "Revert "feat: cross origin opener policy options (#10710)""
This reverts commit 46050ace1a.
2022-06-24 11:35:21 -04:00
Julian Lam
43f9e6c8e4 fix: handle ENOENT on file deletion, closes #10645 2022-06-17 15:09:45 -04:00
Julian Lam
46050ace1a Revert "feat: cross origin opener policy options (#10710)"
This reverts commit 881323583f.
2022-06-17 11:21:41 -04:00
Barış Soner Uşaklı
881323583f feat: cross origin opener policy options (#10710) 2022-06-17 09:40:02 -04:00
Julian Lam
22368b996e refactor: move orphan cleaning logic to its own method, added tests for getOrphans and cleanOrphans 2022-06-15 15:22:51 -04:00
Julian Lam
88aee43947 feat: new cronjob and ACP option to delete orphans after configurable number of days, closes #10659 2022-06-15 15:22:51 -04:00
Julian Lam
bef236f371 chore: remove unnecessary affected set from deprecated plugin hook 2022-06-15 13:50:12 -04:00
Julian Lam
b9d4724e0f feat: allowed plugins to modify email verification details prior to db saving or email send/plugin fire
+ new hook `filter:user.verify`
- hook `filter:user.verify.code`
2022-06-15 13:49:30 -04:00
Julian Lam
3a015eb8e3 fix: no need to pass in empty Set in deprecated hooks 2022-06-15 13:49:19 -04:00
Barış Soner Uşaklı
b6f8e2fd05 fix: #10692 2022-06-11 19:50:05 -04:00
Julian Lam
a04da673fa fix: #10690, all uploads in uploads/files showing orphaned 2022-06-10 15:29:18 -04:00
Julian Lam
7f870beb59 fix: bug where post associations are not shown when the directory is files 2022-06-10 14:32:43 -04:00
Julian Lam
ece733eddc feat: pass absolute url to post into post tools response, #10566 2022-06-10 13:54:42 -04:00
Julian Lam
a35642601c fix: buildBreadcrumbs naively prepending relative path even if absolute paths are passed in 2022-05-31 14:56:41 -04:00
Barış Soner Uşaklı
191fb9f443 test: fix tests again 2022-05-26 13:10:57 -04:00
Barış Soner Uşaklı
e802fab87f fix: get rid of math.random in utils.generateUUID 2022-05-26 12:12:19 -04:00
Barış Soner Uşaklı
7e4d2852f6 fix: #10528, gray out disabled nav items
use enabled property if present
change default to true, so added nav items are enabled by default
2022-05-20 20:23:16 -04:00
Barış Soner Uşaklı
0084b563f3 fix: #10631, fix user digest setting display acp 2022-05-19 12:32:52 -04:00
Julian Lam
54ff768f51 chore: remove optional middleware parameter from setupPageRoute and setupAdminPageRoute calls 2022-05-16 13:34:14 -04:00
Barış Soner Uşaklı
c926358d73 feat: add mute history, closes #10596 2022-05-15 22:26:35 -04:00
Barış Soner Uşaklı
9acdc6808c feat: allow unban/unmute on flag details page. closes #10593 2022-05-15 21:49:27 -04:00
Barış Soner Uşaklı
b17a81bfb0 fix: translate api error messages to user lang, closes #10623, 2022-05-15 21:23:23 -04:00
Barış Soner Uşaklı
3a009f96cd fix: closes #10621, convert \r\n to \n so it isn't counted as 2 characters 2022-05-14 20:03:16 -04:00
Barış Soner Uşaklı
b860c2605c feat: paginaton for admins-mods, closes #10610
ability to select categoriest to see children
2022-05-13 19:52:19 -04:00
Julian Lam
1411059698 feat: fix typo, show route in deprecation notice for third-param removal in setupPageRoute 2022-05-13 13:31:43 -04:00
Barış Soner Uşaklı
3a77e71443 lint: fix semicolon 2022-05-12 20:58:14 -04:00
Barış Soner Uşaklı
a583141252 feat: add button to see category children, closes #10606 2022-05-12 20:48:57 -04:00
Barış Soner Uşaklı
0e60a704a5 fix: 'unread' postIndex regression closes #10607 2022-05-12 11:33:11 -04:00
Barış Soner Uşaklı
f07b4484cf feat: add post to hook params 2022-05-11 10:34:29 -04:00
Julian Lam
e2ff1e39b1 fix: #10588 exit code 1 on failed plugin activation 2022-05-06 16:02:07 -04:00
Barış Soner Uşaklı
5e7d366f55 fix: #10584, dont show backlinks if you dont have read privilege 2022-05-06 14:01:08 -04:00
Julian Lam
0c19b1e57c feat: send back missing parameters as array of missing properties, in API response 2022-05-05 14:16:10 -04:00
Barış Soner Uşaklı
323dbc9789 feat: add hook for user invite 2022-05-05 12:43:48 -04:00
Barış Soner Uşaklı
84f2726391 refactor: deprecate middleware param (#10513)
* refactor: deprecate middleware param

make middlewares optional

* chore: add node 18 again
2022-05-04 21:12:37 -04:00
Barış Soner Uşaklı
ea01ba0152 fix: #10569, fix category move event text 2022-05-03 14:19:38 -04:00
Barış Soner Uşaklı
23175110a2 feat: post queue bulk actions closes #10520, fix #10555, 2022-04-30 19:07:49 -04:00
Barış Soner Uşaklı
d20b07cfea Webpack5 (#10311)
* feat: webpack 5 part 1

* fix: gruntfile fixes

* fix: fix taskbar warning

add app.importScript
copy public/src/modules to build folder

* refactor: remove commented old code

* feat: reenable admin

* fix: acp settings pages, fix sortable on manage categories

embedded require in html not allowed

* fix: bundle serialize/deserizeli so plugins dont break

* test: fixe util tests

* test: fix require path

* test: more test fixes

* test: require correct utils module

* test: require correct utils

* test: log stack

* test: fix db require blowing up tests

* test: move and disable bundle test

* refactor: add aliases

* test: disable testing route

* fix: move webpack modules necessary for build, into `dependencies`

* test: fix one more test

remove 500-embed.tpl

* fix: restore use of assets/nodebb.min.js, at least for now

* fix: remove unnecessary line break

* fix: point to proper ACP bundle

* test: maybe fix build test

* test: composer

* refactor: dont need dist

* refactor: more cleanup

use everything from build/public folder

* get rid of conditional import in app.js

* fix: ace

* refactor: cropper alias

* test: lint and test fixes

* lint: fix

* refactor: rename function to app.require

* refactor: go back to using app.require

* chore: use github branch

* chore: use webpack branch

* feat: webpack webinstaller

* feat: add chunkFile name with contenthash

* refactor: move hooks to top

* refactor: get rid of template500Function

* fix(deps): use webpack5 branch of 2factor plugin

* chore: tagging v2.0.0-beta.0 pre-release version 💥 :shipit: 🎉 🚀

* refactor: disable cache on templates

loadTemplate is called once by benchpress and the result is cache internally

* refactor: add server side helpers.js

* feat: deprecate /plugins shorthand route, closes #10343

* refactor: use build/public for webpack

* test: fix filename

* fix: more specific selector

* lint: ignore

* refactor: fix comments

* test: add debug for random failing test

* refactor: cleanup

remove test page, remove dupe functions in utils.common

* lint: use relative path  for now

* chore: bump prerelease version

* feat: add translateKeys

* fix: optional params

* fix: get rid of extra timeago files

* refactor: cleanup, require timeago locale earlier

remove translator.prepareDOM, it is in header.tpl html tag

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* feat: allow app.require('bootbox'/'benchpressjs')

* refactor: require server side utils

* test: jquery ready

* change istaller to use build/public

* test: use document.addEventListener

* refactor: closes #10301

* refactor: generateTopicClass

* fix: column counts for other privileges

* fix: #10443, regression where sorted-list items did not render into the DOM in the predicted order [breaking]

* fix: typo in hook name

* refactor: introduce a generic autocomplete.init() method that can be called to add nodebb-style autocompletion but using different data sources (e.g. not user/groups/tags)

* fix: crash if `delay` not passed in (as it cannot be destructured)

* refactor: replace substr

* feat: set --panel-offset style in html element based on stored value in localStorage

* refactor: addDropupHandler() logic to be less naive

- Take into account height of the menu
- Don't apply dropUp logic if there's nothing in the dropdown
- Remove 'hidden' class (added by default in Persona for post tools) when menu items are added

closes #10423

* refactor: simplify utils.params [breaking]

Retrospective analysis of the usage of this method suggests that the options passed in are superfluous, and that only `url` is required. Using a browser built-in makes more sense to accomplish what this method sets out to do.

* feat: add support for returning full URLSearchParams for utils.params

* fix: utils.params() fallback handling

* fix: default empty obj for params()

* fix: remove \'loggedin\' and \'register\' qs parameters once they have been used, delay invocation of messages until ajaxify.end

* fix: utils.params() not allowing relative paths to be passed in

* refactor(DRY): new assertPasswordValidity utils method

* fix: incorrect error message returned on insufficient privilege on flag edit

* fix: read/update/delete access to flags API should be limited for moderators to only post flags in categories they moderate

- added failing tests and patched up middleware.assert.flags to fix

* refactor: flag api v3 tests to create new post and flags on every round

* fix: missing error:no-flag language key

* refactor: flags.canView to check flag existence, simplify middleware.assert.flag

* feat: flag deletion API endpoint, #10426

* feat: UI for flag deletion, closes #10426

* chore: update plugin versions

* chore: up emoji

* chore: update markdown

* chore: up emoji-android

* fix: regression caused by utils.params() refactor, supports arrays and pipes all values through utils.toType, adjusts tests to type check

Co-authored-by: Julian Lam <julian@nodebb.org>
2022-04-29 21:39:33 -04:00
Julian Lam
e4a9c07817 feat: output canonical URL as last line on NodeBB boot 2022-04-29 11:29:02 -04:00
Barış Soner Uşaklı
82389469f6 feat: make it simpler to use redis sentinels 2022-04-22 15:39:27 -04:00
Barış Soner Uşaklı
d98ca43799 Revert "refactor: closes #10509"
This reverts commit 7f241dbbe6.
2022-04-22 15:24:02 -04:00
Barış Soner Uşaklı
7f241dbbe6 refactor: closes #10509
deprecate third param(middleware) to setupPageRoute/setupAdminPageRoute
make middlewares optional on all 3 helpers
2022-04-22 15:22:08 -04:00
Barış Soner Uşaklı
ac125538d0 refactor: show invalid uri 2022-04-22 12:13:43 -04:00
Barış Soner Uşaklı
a8e642ade2 refactor: skip content length check if submitting from post-queue 2022-04-21 12:23:37 -04:00
Barış Soner Uşaklı
b9f9164308 fix: #10502, allow unblocking admin/mod
if they were blocked before becoming admin/mod it wasn't possible to unblock them
2022-04-17 18:15:49 -04:00
Barış Soner Uşaklı
b28f9f776a feat: closes #10501, minimum reputation to chat 2022-04-16 21:37:54 -04:00