Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-04 14:50:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3384

Browse Source 
Resolved issue where if a bundled plugin was uninstalled, NodeBB would no longer start as the dep check could not be completed.
This commit is contained in:
Julian Lam
2015-08-04 16:59:50 -04:00
parent 9604779be1
commit f53fb19468
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/meta/dependencies.js
View File

@@ -19,6 +19,12 @@ module.exports = function(Meta) {
fs.readFile(path.join(__dirname, '../../node_modules/', module, 'package.json'), {
encoding: 'utf-8'
}, function(err, pkgData) {
// If a bundled plugin/theme is not present, skip the dep check (#3384)
if (err && err.code === 'ENOENT' && (module.startsWith('nodebb-plugin') || module.startsWith('nodebb-theme'))) {
winston.warn('[meta/dependencies] Bundled plugin ' + module + ' not found, skipping dependency check.');
return next(true);
}
try {
var pkgData = JSON.parse(pkgData),
ok = semver.satisfies(pkgData.version, pkg.dependencies[module]);
@@ -30,7 +36,7 @@ module.exports = function(Meta) {
next(false);
}
} catch(e) {
winston.error('[meta.dependencies] Could not read: ' + module);
winston.error('[meta/dependencies] Could not read: ' + module);
process.exit();
}
})