Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-05 05:25:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

closes #6103

Browse Source
This commit is contained in:
Baris Usakli
2017-11-22 12:10:34 -05:00
parent d0c9c52f9b
commit dbf815ed47
2 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/database/redis/hash.js
View File

@@ -102,7 +102,7 @@ module.exports = function (redisClient, module) {
module.deleteObjectField = function (key, field, callback) {
callback = callback || function () {};
if (field === null) {
if (key === undefined || key === null || field === undefined || field === null) {
return setImmediate(callback);
}
redisClient.hdel(key, field, function (err) {

28
test/database/hash.js
View File

@@ -330,6 +330,34 @@ describe('Hash methods', function () {
});
});
});
it('should not error if key is undefined', function (done) {
db.deleteObjectField(undefined, 'someField', function (err) {
assert.ifError(err);
done();
});
});
it('should not error if key is null', function (done) {
db.deleteObjectField(null, 'someField', function (err) {
assert.ifError(err);
done();
});
});
it('should not error if field is undefined', function (done) {
db.deleteObjectField('someKey', undefined, function (err) {
assert.ifError(err);
done();
});
});
it('should not error if field is null', function (done) {
db.deleteObjectField('someKey', null, function (err) {
assert.ifError(err);
done();
});
});
});
describe('incrObjectField()', function () {