Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-11-09 07:25:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

shorter sort methods

Browse Source
This commit is contained in:
barisusakli
2015-10-11 21:56:28 -04:00
parent 79d5eea46d
commit c8fb68c2d5
1 changed files with 9 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/search.js
View File

@@ -315,16 +315,12 @@ function sortPosts(posts, data) {
} }
data.sortBy = data.sortBy || 'timestamp'; data.sortBy = data.sortBy || 'timestamp';
data.sortDirection = data.sortDirection || 'desc'; data.sortDirection = data.sortDirection || 'desc';
var direction = data.sortDirection === 'desc' ? 1 : -1;
if (data.sortBy === 'timestamp') { if (data.sortBy === 'timestamp') {
if (data.sortDirection === 'desc') { posts.sort(function(p1, p2) {
posts.sort(function(p1, p2) { return direction * (p2.timestamp - p1.timestamp);
return p2.timestamp - p1.timestamp; });
});
} else {
posts.sort(function(p1, p2) {
return p1.timestamp - p2.timestamp;
});
}
return; return;
} }
@@ -336,21 +332,13 @@ function sortPosts(posts, data) {
return; return;
} }
var value = firstPost[fields[0]][fields[1]]; var isNumeric = utils.isNumber(firstPost[fields[0]][fields[1]]);
var isNumeric = utils.isNumber(value);
if (isNumeric) { if (isNumeric) {
if (data.sortDirection === 'desc') { posts.sort(function(p1, p2) {
posts.sort(function(p1, p2) { return direction * (p2[fields[0]][fields[1]] - p1[fields[0]][fields[1]]);
return p2[fields[0]][fields[1]] - p1[fields[0]][fields[1]]; });
});
} else {
posts.sort(function(p1, p2) {
return p1[fields[0]][fields[1]] - p2[fields[0]][fields[1]];
});
}
} else { } else {
var direction = data.sortDirection === 'desc' ? 1 : -1;
posts.sort(function(p1, p2) { posts.sort(function(p1, p2) {
if (p1[fields[0]][fields[1]] > p2[fields[0]][fields[1]]) { if (p1[fields[0]][fields[1]] > p2[fields[0]][fields[1]]) {
return direction; return direction;