From c8fb68c2d509bde1d86dc2567a675bcea333d0bf Mon Sep 17 00:00:00 2001 From: barisusakli Date: Sun, 11 Oct 2015 21:56:28 -0400 Subject: [PATCH] shorter sort methods --- src/search.js | 30 +++++++++--------------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/src/search.js b/src/search.js index ffd19b1cd6..33fc7ffca8 100644 --- a/src/search.js +++ b/src/search.js @@ -315,16 +315,12 @@ function sortPosts(posts, data) { } data.sortBy = data.sortBy || 'timestamp'; data.sortDirection = data.sortDirection || 'desc'; + var direction = data.sortDirection === 'desc' ? 1 : -1; + if (data.sortBy === 'timestamp') { - if (data.sortDirection === 'desc') { - posts.sort(function(p1, p2) { - return p2.timestamp - p1.timestamp; - }); - } else { - posts.sort(function(p1, p2) { - return p1.timestamp - p2.timestamp; - }); - } + posts.sort(function(p1, p2) { + return direction * (p2.timestamp - p1.timestamp); + }); return; } @@ -336,21 +332,13 @@ function sortPosts(posts, data) { return; } - var value = firstPost[fields[0]][fields[1]]; - var isNumeric = utils.isNumber(value); + var isNumeric = utils.isNumber(firstPost[fields[0]][fields[1]]); if (isNumeric) { - if (data.sortDirection === 'desc') { - posts.sort(function(p1, p2) { - return p2[fields[0]][fields[1]] - p1[fields[0]][fields[1]]; - }); - } else { - posts.sort(function(p1, p2) { - return p1[fields[0]][fields[1]] - p2[fields[0]][fields[1]]; - }); - } + posts.sort(function(p1, p2) { + return direction * (p2[fields[0]][fields[1]] - p1[fields[0]][fields[1]]); + }); } else { - var direction = data.sortDirection === 'desc' ? 1 : -1; posts.sort(function(p1, p2) { if (p1[fields[0]][fields[1]] > p2[fields[0]][fields[1]]) { return direction;