Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-04 23:00:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Escape arguments in Translator.compile

Browse Source
This commit is contained in:
Peter Jaszkowiak
2016-12-10 20:41:49 -07:00
parent a81aad61ab
commit bb5fe0cc83
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
public/src/modules/translator.js
View File

@@ -399,9 +399,12 @@
* @param {...string} arg - Optional argument for the pattern
*/
Translator.compile = function compile() {
var args = Array.prototype.slice.call(arguments, 0);
var args = Array.prototype.slice.call(arguments, 0).map(function (text) {
// escape commas and percent signs in arguments
return text.replace(/%/g, '%').replace(/,/g, ',');
});
return '[[' + args.join(', ') + ']]';
return '[[' + args.join(', ') + ']]';
};
return Translator;

8
test/translator.js
View File

@@ -251,5 +251,13 @@ describe('Translator static methods', function () {
);
done();
});
it('should escape `%` and `,` in arguments', function (done) {
assert.strictEqual(
Translator.compile('amazing:cool', '100% awesome!', 'one, two, and three'),
'[[amazing:cool, 100% awesome!, one, two, and three]]'
);
done();
});
});
});