Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-03 06:10:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

fixed issue where Groups.getUserGroups called getGroupsData on all groups, resulting in a very unscalable method if called on forum with thousands of groups

Browse Source
This commit is contained in:
Julian Lam
2015-05-19 00:06:37 -04:00
parent 8bc5330e89
commit 8aac4bdfa1
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/groups.js
View File

@@ -981,13 +981,13 @@ var async = require('async'),
return groupName !== 'registered-users' && groupName.indexOf(':privileges:') === -1;
});
Groups.getGroupsData(groupNames, function(err, groupData) {
Groups.getMultipleGroupFields(groupNames, ['name', 'hidden'], function(err, groupData) {
if (err) {
return callback(err);
}
groupData = groupData.filter(function(group) {
return group && !group.hidden;
return group && !parseInt(group.hidden, 10);
});
var groupSets = groupData.map(function(group) {
@@ -1003,11 +1003,11 @@ var async = require('async'),
var memberOf = [];
isMembers.forEach(function(isMember, index) {
if (isMember) {
memberOf.push(groupData[index]);
memberOf.push(groupData[index].name);
}
});
next(null, memberOf);
Groups.getGroupsData(memberOf, next);
});
}, callback);
});