Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2026-01-01 21:30:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: bug where fallback window trigger was not firing if there were no hook listeners attached

Browse Source 
... so in essence the backwards compatibility was not working at all.

closes nodebb/nodebb-plugin-composer-default#147
This commit is contained in:
Julian Lam
2021-03-04 11:10:06 -05:00
parent c8b78654d9
commit 1e579428e7
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
public/src/modules/hooks.js
View File

@@ -63,12 +63,10 @@ define('hooks', [], () => {
};
const _fireActionHook = (hookName, data) => {
if (!Hooks.hasListeners(hookName)) {
return;
if (Hooks.hasListeners(hookName)) {
Hooks.loaded[hookName].forEach(listener => listener(data));
}
Hooks.loaded[hookName].forEach(listener => listener(data));
// Backwards compatibility (remove this when we eventually remove jQuery from NodeBB core)
$(window).trigger(hookName, data);
};