From 1e579428e7c21d937b66e70c7833f8a1b3f03f82 Mon Sep 17 00:00:00 2001 From: Julian Lam Date: Thu, 4 Mar 2021 11:10:06 -0500 Subject: [PATCH] fix: bug where fallback window trigger was not firing if there were no hook listeners attached ... so in essence the backwards compatibility was not working at all. closes nodebb/nodebb-plugin-composer-default#147 --- public/src/modules/hooks.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/public/src/modules/hooks.js b/public/src/modules/hooks.js index a9c13eb6ef..f5e4c61744 100644 --- a/public/src/modules/hooks.js +++ b/public/src/modules/hooks.js @@ -63,12 +63,10 @@ define('hooks', [], () => { }; const _fireActionHook = (hookName, data) => { - if (!Hooks.hasListeners(hookName)) { - return; + if (Hooks.hasListeners(hookName)) { + Hooks.loaded[hookName].forEach(listener => listener(data)); } - Hooks.loaded[hookName].forEach(listener => listener(data)); - // Backwards compatibility (remove this when we eventually remove jQuery from NodeBB core) $(window).trigger(hookName, data); };