use false, and remove @ is not muting the error any more

This commit is contained in:
Mitan Omar
2022-08-23 21:10:28 +02:00
parent 7aebd0dd77
commit 9404f7a1b6

View File

@@ -32,7 +32,7 @@ class cache
{
if (defined('DEV_STAGE'))
{
return [];
return false;
}
$name = preg_replace('![^a-z0-9_]!', '_', $name);
@@ -40,22 +40,15 @@ class cache
if (file_exists(PATH . 'cache/' . $name . '.php'))
{
include PATH . 'cache/' . $name . '.php';
return empty($data) ? [] : $data;
}
else
{
return [];
return empty($data) ? false : $data;
}
return false;
}
public function exists($name)
public function exists($name): bool
{
$name = preg_replace('![^a-z0-9_]!', '_', $name);
if (file_exists(PATH . 'cache/' . $name . '.php'))
{
return true;
}
return file_exists(PATH . 'cache/' . $name . '.php');
}
public function save($name, $data, $time = 86400)
@@ -64,17 +57,20 @@ class cache
$data_for_save = '<?' . 'php' . "\n";
$data_for_save .= '//Cache file, generated for Kleeja at ' . gmdate('d-m-Y h:i A') . "\n\n";
$data_for_save .= '//No direct opening' . "\n";
$data_for_save .= '(!defined("IN_COMMON") ? exit("hacking attemp!") : null);' . "\n\n";
$data_for_save .= '(!defined("IN_COMMON") ? exit("hacking attempt!") : null);' . "\n\n";
$data_for_save .= '//return false after x time' . "\n";
$data_for_save .= 'if(time() > ' . (time() + $time) . ') return false;' . "\n\n";
$data_for_save .= '$data = ' . var_export($data, true) . ";\n\n//end of cache";
if ($fd = @fopen(PATH . 'cache/' . $name . '.php', 'w'))
{
@flock($fd, LOCK_EX); // exlusive look
@fwrite($fd, $data_for_save);
@flock($fd, LOCK_UN);
@fclose($fd);
try {
$fd = fopen(PATH . 'cache/' . $name . '.php', 'w');
flock($fd, LOCK_EX); // exclusive look
fwrite($fd, $data_for_save);
flock($fd, LOCK_UN);
fclose($fd);
return true;
} catch (Exception $e) {
return false;
}
}