mirror of
https://github.com/gitbucket/gitbucket.git
synced 2025-11-01 19:15:59 +01:00
Fix redirect behaviour after sign in.
This commit is contained in:
@@ -107,7 +107,11 @@ abstract class ControllerBase extends ScalatraFilter
|
||||
if(context.loginAccount.isDefined){
|
||||
org.scalatra.Unauthorized(redirect("/"))
|
||||
} else {
|
||||
org.scalatra.Unauthorized(redirect("/signin?" + currentURL))
|
||||
if(request.getMethod.toUpperCase == "POST"){
|
||||
org.scalatra.Unauthorized(redirect("/signin"))
|
||||
} else {
|
||||
org.scalatra.Unauthorized(redirect("/signin?redirect=" + currentURL))
|
||||
}
|
||||
}
|
||||
} else {
|
||||
org.scalatra.Unauthorized()
|
||||
@@ -126,6 +130,14 @@ abstract class ControllerBase extends ScalatraFilter
|
||||
*/
|
||||
case class Context(path: String, loginAccount: Option[Account], currentUrl: String, request: HttpServletRequest){
|
||||
|
||||
def redirectUrl = {
|
||||
if(request.getParameter("redirect") != null){
|
||||
request.getParameter("redirect")
|
||||
} else {
|
||||
currentUrl
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Get object from cache.
|
||||
*
|
||||
|
||||
@@ -16,9 +16,9 @@ trait SignInControllerBase extends ControllerBase { self: SystemSettingsService
|
||||
)(SignInForm.apply)
|
||||
|
||||
get("/signin"){
|
||||
val queryString = request.getQueryString
|
||||
if(queryString != null && queryString.startsWith("/")){
|
||||
session.setAttribute("REDIRECT", queryString)
|
||||
val redirect = params.get("redirect")
|
||||
if(redirect.isDefined && redirect.get.startsWith("/")){
|
||||
session.setAttribute("REDIRECT", redirect.get)
|
||||
}
|
||||
html.signin(loadSystemSettings())
|
||||
}
|
||||
|
||||
@@ -60,7 +60,7 @@
|
||||
}
|
||||
<a href="@path/signout" class="menu-last" data-toggle="tooltip" data-placement="bottom" title="Sign out"><i class="icon-share-alt"></i></a>
|
||||
} else {
|
||||
<a href="@path/signin?@currentUrl" class="btn btn-last">Sign in</a>
|
||||
<a href="@path/signin?redirect=@redirectUrl" class="btn btn-last">Sign in</a>
|
||||
}
|
||||
</div><!--/.nav-collapse -->
|
||||
</div>
|
||||
|
||||
Reference in New Issue
Block a user