Address comments

This commit is contained in:
ajnart
2023-01-06 12:23:54 +09:00
parent 94e36f3e0f
commit cb9ee81aa2
4 changed files with 3 additions and 6 deletions

View File

@@ -26,5 +26,6 @@
} }
}, },
"tip": "You can select the search bar with the shortcut ", "tip": "You can select the search bar with the shortcut ",
"switchedSearchEngine": "Switched to searching with {{searchEngine}}" "switchedSearchEngine": "Switched to searching with {{searchEngine}}",
"configurationName": "Search engine configuration"
} }

View File

@@ -50,7 +50,7 @@ export const SearchEngineSelector = ({ searchEngine }: Props) => {
/> />
<Paper p="md" py="sm" mb="md" withBorder> <Paper p="md" py="sm" mb="md" withBorder>
<Title order={6} mb={0}> <Title order={6} mb={0}>
Search engine configuration {t('configurationName')}
</Title> </Title>
<SearchNewTabSwitch defaultValue={searchEngine.properties.openInNewTab} /> <SearchNewTabSwitch defaultValue={searchEngine.properties.openInNewTab} />

View File

@@ -55,9 +55,6 @@ export function Search() {
const [searchQuery, setSearchQuery] = useState(''); const [searchQuery, setSearchQuery] = useState('');
const [debounced, cancel] = useDebouncedValue(searchQuery, 250); const [debounced, cancel] = useDebouncedValue(searchQuery, 250);
// TODO: ask manuel-rw about overseerr
// Answer: We can simply check if there is a app of the type overseer and display results if there is one.
// Overseerr is not use anywhere else, so it makes no sense to add a standalone toggle for displaying results
const isOverseerrEnabled = config?.apps.some( const isOverseerrEnabled = config?.apps.some(
(x) => x.integration.type === 'overseerr' || x.integration.type === 'jellyseerr' (x) => x.integration.type === 'overseerr' || x.integration.type === 'jellyseerr'
); );

View File

@@ -8,7 +8,6 @@ interface smallAppItem {
export default function SmallAppItem(props: any) { export default function SmallAppItem(props: any) {
const { app }: { app: smallAppItem } = props; const { app }: { app: smallAppItem } = props;
// TODO : Use Next/link
return ( return (
<Group> <Group>
{app.icon && <Avatar src={app.icon} />} {app.icon && <Avatar src={app.icon} />}