From cb9ee81aa2717cf898b3f789e84bc3b904f3c0b7 Mon Sep 17 00:00:00 2001 From: ajnart Date: Fri, 6 Jan 2023 12:23:54 +0900 Subject: [PATCH] Address comments --- public/locales/en/modules/search.json | 3 ++- .../Settings/Common/SearchEngine/SearchEngineSelector.tsx | 2 +- src/components/layout/header/Search.tsx | 3 --- src/components/layout/header/SmallAppItem.tsx | 1 - 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/public/locales/en/modules/search.json b/public/locales/en/modules/search.json index cf3f50de0..8b3ed6302 100644 --- a/public/locales/en/modules/search.json +++ b/public/locales/en/modules/search.json @@ -26,5 +26,6 @@ } }, "tip": "You can select the search bar with the shortcut ", - "switchedSearchEngine": "Switched to searching with {{searchEngine}}" + "switchedSearchEngine": "Switched to searching with {{searchEngine}}", + "configurationName": "Search engine configuration" } \ No newline at end of file diff --git a/src/components/Settings/Common/SearchEngine/SearchEngineSelector.tsx b/src/components/Settings/Common/SearchEngine/SearchEngineSelector.tsx index 3e9fe1d4d..c001184e2 100644 --- a/src/components/Settings/Common/SearchEngine/SearchEngineSelector.tsx +++ b/src/components/Settings/Common/SearchEngine/SearchEngineSelector.tsx @@ -50,7 +50,7 @@ export const SearchEngineSelector = ({ searchEngine }: Props) => { /> - Search engine configuration + {t('configurationName')} diff --git a/src/components/layout/header/Search.tsx b/src/components/layout/header/Search.tsx index 619b10fce..5c28e7fcb 100644 --- a/src/components/layout/header/Search.tsx +++ b/src/components/layout/header/Search.tsx @@ -55,9 +55,6 @@ export function Search() { const [searchQuery, setSearchQuery] = useState(''); const [debounced, cancel] = useDebouncedValue(searchQuery, 250); - // TODO: ask manuel-rw about overseerr - // Answer: We can simply check if there is a app of the type overseer and display results if there is one. - // Overseerr is not use anywhere else, so it makes no sense to add a standalone toggle for displaying results const isOverseerrEnabled = config?.apps.some( (x) => x.integration.type === 'overseerr' || x.integration.type === 'jellyseerr' ); diff --git a/src/components/layout/header/SmallAppItem.tsx b/src/components/layout/header/SmallAppItem.tsx index caa198785..02aeed486 100644 --- a/src/components/layout/header/SmallAppItem.tsx +++ b/src/components/layout/header/SmallAppItem.tsx @@ -8,7 +8,6 @@ interface smallAppItem { export default function SmallAppItem(props: any) { const { app }: { app: smallAppItem } = props; - // TODO : Use Next/link return ( {app.icon && }