mirror of
https://github.com/scm-manager/scm-manager.git
synced 2026-01-06 15:42:12 +01:00
7a7ac9a3f2
The change tackles a sporadic error in integration tests, where during or after a change in a git repository a pack file could not be read correctly due to a "short compressed stream". The exception could look like this: ERROR org.eclipse.jgit.internal.storage.file.ObjectDirectory - Exception caught while accessing pack file scm-home/repositories/8gSNr4ogc5X/data/objects/pack/pack-51a3500283ece83ab8efa7edfb9370e6f97311b5.pack, the pack file might be corrupt. Caught 1 consecutive errors while trying to read this pack. java.io.EOFException: Short compressed stream at 197 at org.eclipse.jgit.internal.storage.file.PackFile.decompress(PackFile.java:381) at org.eclipse.jgit.internal.storage.file.PackFile.load(PackFile.java:815) at org.eclipse.jgit.internal.storage.file.PackFile.get(PackFile.java:284) at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedObject(ObjectDirectory.java:455) at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedFromSelfOrAlternate(ObjectDirectory.java:413) at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openObject(ObjectDirectory.java:404) at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:132) at org.eclipse.jgit.treewalk.CanonicalTreeParser.reset(CanonicalTreeParser.java:191) at org.eclipse.jgit.treewalk.TreeWalk.parserFor(TreeWalk.java:1344) at org.eclipse.jgit.treewalk.TreeWalk.addTree(TreeWalk.java:732) at sonia.scm.repository.spi.Differ.create(Differ.java:102) at sonia.scm.repository.spi.Differ.diff(Differ.java:63) We found out that this seems to be linked to the asynchronous execution of post commit hooks, that originally are triggered in the midst of the processing of a receive pack. With this change the fireing of these triggers is delayed until the end of the internal git processing. The central class for this is the GitHookEventFacade, where hook events are either - put into a ThreadLocal, so that they can be triggered later, or - triggered in a thread that is joined with an internal JGit thread for internal pushes (eg. for modify command or merge command)