Files
SCM-Manager/scm-ui/ui-api/src/notifications.ts
Konstantin Schaper 01bff1ce95 Fix race condition with plugin bundles
There may be a race condition when loading plugin bundles with lazy dependencies:

The OpenAPI plugin depends on "redux" and "react-redux", which are bundled in the lazy "ui-legacy" module, as the usage of redux is deprecated in the scmm. The "ui-legacy" module also binds a global wrapper extension point around the whole app. Due to a bug in the plugin loader, plugin bundles were marked as successfully loaded even if a lazy dependency hadn't successfully loaded yet. This caused the extension point from the "ui-legacy" bundle to be bound after the initial render. As the process of extension point binding  doesn't trigger a re-render, the redux provider was not wrapped around the app on initial load. When the user now moved focus out of and back into the window, react-query hooks automatically refetched e.g. the index links, which caused a re-render. Now with the bound extension point applied. This caused the whole app to be unmounted and re-mounted, which in turn reset all form fields anywhere below in the tree.

Also fixes a bug where the global notifications component was executing a state update while already unmounted.

Also fixes a bug in the user creation form where an object literal was passed to the form's default values which caused a form reset whenever the component re-rendered.

Committed-by: Rene Pfeuffer <rene.pfeuffer@cloudogu.com>
2023-05-15 17:34:50 +02:00

193 lines
5.8 KiB
TypeScript

/*
* MIT License
*
* Copyright (c) 2020-present Cloudogu GmbH and Contributors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
import { useMe } from "./login";
import { useMutation, useQuery, useQueryClient } from "react-query";
import { Link, Notification, NotificationCollection } from "@scm-manager/ui-types";
import { apiClient } from "./apiclient";
import { useCallback, useEffect, useState } from "react";
import { requiredLink } from "./links";
import { useCancellablePromise } from "./utils";
export const useNotifications = () => {
const { data: me } = useMe();
const link = (me?._links["notifications"] as Link)?.href;
const { data, error, isLoading, refetch } = useQuery<NotificationCollection, Error>(
"notifications",
() => apiClient.get(link).then((response) => response.json()),
{
enabled: !!link,
}
);
const memoizedRefetch = useCallback(() => {
return refetch().then((r) => r.data);
}, [refetch]);
return {
data,
error,
isLoading,
refetch: memoizedRefetch,
};
};
export const useDismissNotification = (notification: Notification) => {
const queryClient = useQueryClient();
const link = requiredLink(notification, "dismiss");
const { data, isLoading, error, mutate } = useMutation<Response, Error>(() => apiClient.delete(link), {
onSuccess: () => {
queryClient.invalidateQueries("notifications");
},
});
return {
isLoading,
error,
dismiss: () => mutate(),
isCleared: !!data,
};
};
export const useClearNotifications = (notificationCollection: NotificationCollection) => {
const queryClient = useQueryClient();
const link = requiredLink(notificationCollection, "clear");
const { data, isLoading, error, mutate } = useMutation<Response, Error>(() => apiClient.delete(link), {
onSuccess: () => {
queryClient.invalidateQueries("notifications");
},
});
return {
isLoading,
error,
clear: () => mutate(),
isCleared: !!data,
};
};
const isEqual = (left: Notification, right: Notification) => {
return left === right || (left.message === right.message && left.createdAt === right.createdAt);
};
export const useNotificationSubscription = (
refetch: () => Promise<NotificationCollection | undefined>,
notificationCollection?: NotificationCollection
) => {
const [notifications, setNotifications] = useState<Notification[]>([]);
const [disconnectedAt, setDisconnectedAt] = useState<Date>();
const link = (notificationCollection?._links.subscribe as Link)?.href;
const cancelOnUnmount = useCancellablePromise();
const onVisible = useCallback(() => {
// we don't need to catch the error,
// because if the refetch throws an error the parent useNotifications should catch it
cancelOnUnmount(refetch()).then(
(collection) => {
if (collection) {
const newNotifications = collection._embedded?.notifications.filter((n) => {
return disconnectedAt && disconnectedAt < new Date(n.createdAt);
});
if (newNotifications && newNotifications.length > 0) {
setNotifications((previous) => [...previous, ...newNotifications]);
}
setDisconnectedAt(undefined);
}
},
(reason) => {
if (!reason.isCanceled) {
throw reason;
}
}
);
}, [cancelOnUnmount, disconnectedAt, refetch]);
const onHide = useCallback(() => {
setDisconnectedAt(new Date());
}, []);
const received = useCallback(
(notification: Notification) => {
setNotifications((previous) => [...previous, notification]);
refetch();
},
[refetch]
);
useEffect(() => {
if (link) {
let cancel: () => void;
const disconnect = () => {
if (cancel) {
cancel();
}
};
const connect = () => {
disconnect();
cancel = apiClient.subscribe(link, {
notification: (event) => {
received(JSON.parse(event.data));
},
});
};
const handleVisibilityChange = () => {
if (document.visibilityState === "visible") {
onVisible();
} else {
onHide();
}
};
if (document.visibilityState === "visible") {
connect();
}
document.addEventListener("visibilitychange", handleVisibilityChange);
return () => {
disconnect();
document.removeEventListener("visibilitychange", handleVisibilityChange);
};
}
}, [link, onVisible, onHide, received]);
const remove = useCallback(
(notification: Notification) => {
setNotifications((oldNotifications) => [...oldNotifications.filter((n) => !isEqual(n, notification))]);
},
[setNotifications]
);
const clear = useCallback(() => {
setNotifications([]);
}, [setNotifications]);
return {
notifications,
remove,
clear,
};
};