Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-03 20:15:52 +01:00
Code Issues Packages Projects Releases Activity

There is no need for a class component here

Browse Source 
We should use function component as much as possible, because their are easier to read and less confusing.
This commit is contained in:
Sebastian Sdorra
2020-10-15 08:34:36 +02:00
parent e67ca28c5f
commit ffd1daba52
1 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
scm-ui/ui-components/src/repos/CommitAuthor.tsx
View File

@@ -22,34 +22,31 @@
* SOFTWARE.
*/
import React from "react";
import { WithTranslation, withTranslation } from "react-i18next";
import React, { FC } from "react";
import { useTranslation } from "react-i18next";
import Notification from "../Notification";
import { Me } from "@scm-manager/ui-types";
import { connect } from "react-redux";
import { compose } from "redux";
type Props = WithTranslation & {
type Props = {
// props from global state
me: Me;
};
class CommitAuthor extends React.Component<Props> {
render() {
const { me, t } = this.props;
const CommitAuthor: FC<Props> = ({ me }) => {
const [t] = useTranslation("repos");
const mail = me.mail ? me.mail : me.fallbackMail;
const mail = me.mail ? me.mail : me.fallbackMail;
return (
<>
{!me.mail && <Notification type="warning">{t("commit.commitAuthor.noMail")}</Notification>}
<span className="mb-2">
<strong>{t("commit.commitAuthor.author")}</strong> {`${me.displayName} <${mail}>`}
</span>
</>
);
}
}
return (
<>
{!me.mail && <Notification type="warning">{t("commit.commitAuthor.noMail")}</Notification>}
<span className="mb-2">
<strong>{t("commit.commitAuthor.author")}</strong> {`${me.displayName} <${mail}>`}
</span>
</>
);
};
const mapStateToProps = (state: any) => {
const { auth } = state;
@@ -60,4 +57,4 @@ const mapStateToProps = (state: any) => {
};
};
export default compose(connect(mapStateToProps), withTranslation("repos"))(CommitAuthor);
export default connect(mapStateToProps)(CommitAuthor);