Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-13 17:05:43 +01:00
Code Issues Packages Projects Releases Activity

Fix integration tests

Browse Source 
Every authenticated user should be able to see her own "Me" Resource.
This commit is contained in:
René Pfeuffer
2018-09-27 11:50:58 +02:00
parent 20f3f86f73
commit fdbc5077d2
3 changed files with 2 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
scm-it/src/test/java/sonia/scm/it/MeITCase.java
View File

@@ -62,18 +62,4 @@ public class MeITCase {
.assertType(s -> assertThat(s).isEqualTo(type)) .assertType(s -> assertThat(s).isEqualTo(type))
.assertPasswordLinkDoesNotExists(); .assertPasswordLinkDoesNotExists();
} }
@Test
public void shouldGet403IfUserIsNotAdmin() {
String newUser = "user";
String password = "pass";
String type = "xml";
TestData.createUser(newUser, password, false, type);
ScmRequests.start()
.given()
.url(TestData.getMeUrl())
.usernameAndPassword(newUser, password)
.getMeResource()
.assertStatusCode(403);
}
} }

17
scm-it/src/test/java/sonia/scm/it/UserITCase.java
View File

@@ -93,21 +93,4 @@ public class UserITCase {
.assertType(s -> assertThat(s).isEqualTo(type)) .assertType(s -> assertThat(s).isEqualTo(type))
.assertPasswordLinkDoesNotExists(); .assertPasswordLinkDoesNotExists();
} }
@Test
public void shouldGet403IfUserIsNotAdmin() {
String newUser = "user";
String password = "pass";
String type = "xml";
TestData.createUser(newUser, password, false, type);
ScmRequests.start()
.given()
.url(TestData.getMeUrl())
.usernameAndPassword(newUser, password)
.getUserResource()
.assertStatusCode(403);
}
} }

2
scm-webapp/src/test/java/sonia/scm/it/UserPermissionITCase.java
View File

@@ -37,6 +37,7 @@ package sonia.scm.it;
import com.sun.jersey.api.client.ClientResponse; import com.sun.jersey.api.client.ClientResponse;
import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.HalRepresentation;
import org.junit.Assume;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.junit.runners.Parameterized; import org.junit.runners.Parameterized;
import sonia.scm.api.rest.ObjectMapperProvider; import sonia.scm.api.rest.ObjectMapperProvider;
@@ -158,6 +159,7 @@ public class UserPermissionITCase extends AbstractPermissionITCaseBase<User>
@Override @Override
protected void checkGetAllResponse(ClientResponse response) protected void checkGetAllResponse(ClientResponse response)
{ {
Assume.assumeTrue(credentials.getUsername() == null);
if (!credentials.isAnonymous()) if (!credentials.isAnonymous())
{ {
assertNotNull(response); assertNotNull(response);