mirror of
https://github.com/scm-manager/scm-manager.git
synced 2025-11-12 00:15:44 +01:00
improve performance for big history with paging
This commit is contained in:
@@ -36,7 +36,6 @@ package sonia.scm.repository.spi;
|
|||||||
//~--- non-JDK imports --------------------------------------------------------
|
//~--- non-JDK imports --------------------------------------------------------
|
||||||
|
|
||||||
import com.google.common.base.Strings;
|
import com.google.common.base.Strings;
|
||||||
import com.google.common.collect.Lists;
|
|
||||||
|
|
||||||
import sonia.scm.repository.Changeset;
|
import sonia.scm.repository.Changeset;
|
||||||
import sonia.scm.repository.ChangesetPagingResult;
|
import sonia.scm.repository.ChangesetPagingResult;
|
||||||
@@ -110,53 +109,10 @@ public class HgLogCommand extends AbstractCommand implements LogCommand
|
|||||||
ChangesetPagingResult result = null;
|
ChangesetPagingResult result = null;
|
||||||
|
|
||||||
com.aragost.javahg.Repository repository = open();
|
com.aragost.javahg.Repository repository = open();
|
||||||
HgLogChangesetCommand cmd = HgLogChangesetCommand.on(repository);
|
|
||||||
|
|
||||||
if (!Strings.isNullOrEmpty(request.getPath()))
|
if (!Strings.isNullOrEmpty(request.getPath()))
|
||||||
{
|
{
|
||||||
|
result = collectHistory(repository, request);
|
||||||
String startChangeset = request.getStartChangeset();
|
|
||||||
String endChangeset = request.getEndChangeset();
|
|
||||||
|
|
||||||
if (!Strings.isNullOrEmpty(startChangeset)
|
|
||||||
&&!Strings.isNullOrEmpty(endChangeset))
|
|
||||||
{
|
|
||||||
cmd.rev(startChangeset.concat(":").concat(endChangeset));
|
|
||||||
}
|
|
||||||
else if (!Strings.isNullOrEmpty(endChangeset))
|
|
||||||
{
|
|
||||||
cmd.rev("tip:".concat(endChangeset));
|
|
||||||
}
|
|
||||||
else if (!Strings.isNullOrEmpty(startChangeset))
|
|
||||||
{
|
|
||||||
cmd.rev(startChangeset.concat(":0"));
|
|
||||||
}
|
|
||||||
|
|
||||||
List<Changeset> changesetList = cmd.execute(request.getPath());
|
|
||||||
|
|
||||||
int start = request.getPagingStart();
|
|
||||||
int limit = request.getPagingLimit();
|
|
||||||
List<Changeset> changesets = null;
|
|
||||||
|
|
||||||
if ((start == 0) && (limit < 0))
|
|
||||||
{
|
|
||||||
changesets = changesetList;
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
limit = limit + start;
|
|
||||||
|
|
||||||
if ((limit > changesetList.size()) || (limit < 0))
|
|
||||||
{
|
|
||||||
limit = changesetList.size();
|
|
||||||
}
|
|
||||||
|
|
||||||
List<Changeset> sublist = changesetList.subList(start, limit);
|
|
||||||
|
|
||||||
changesets = Lists.newArrayList(sublist);
|
|
||||||
}
|
|
||||||
|
|
||||||
result = new ChangesetPagingResult(changesetList.size(), changesets);
|
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
@@ -196,15 +152,88 @@ public class HgLogCommand extends AbstractCommand implements LogCommand
|
|||||||
end = start - request.getPagingLimit() + 1;
|
end = start - request.getPagingLimit() + 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
if ( end < 0 ){
|
if (end < 0)
|
||||||
|
{
|
||||||
end = 0;
|
end = 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
List<Changeset> changesets = cmd.rev(start + ":" + end).execute();
|
List<Changeset> changesets =
|
||||||
|
HgLogChangesetCommand.on(repository).rev(start + ":" + end).execute();
|
||||||
|
|
||||||
result = new ChangesetPagingResult(total, changesets);
|
result = new ChangesetPagingResult(total, changesets);
|
||||||
}
|
}
|
||||||
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
//~--- methods --------------------------------------------------------------
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Method description
|
||||||
|
*
|
||||||
|
*
|
||||||
|
* @param repository
|
||||||
|
* @param request
|
||||||
|
*
|
||||||
|
* @return
|
||||||
|
*/
|
||||||
|
private ChangesetPagingResult collectHistory(
|
||||||
|
com.aragost.javahg.Repository repository, LogCommandRequest request)
|
||||||
|
{
|
||||||
|
HgLogChangesetCommand cmd = HgLogChangesetCommand.on(repository);
|
||||||
|
String startChangeset = request.getStartChangeset();
|
||||||
|
String endChangeset = request.getEndChangeset();
|
||||||
|
|
||||||
|
if (!Strings.isNullOrEmpty(startChangeset)
|
||||||
|
&&!Strings.isNullOrEmpty(endChangeset))
|
||||||
|
{
|
||||||
|
cmd.rev(startChangeset.concat(":").concat(endChangeset));
|
||||||
|
}
|
||||||
|
else if (!Strings.isNullOrEmpty(endChangeset))
|
||||||
|
{
|
||||||
|
cmd.rev("tip:".concat(endChangeset));
|
||||||
|
}
|
||||||
|
else if (!Strings.isNullOrEmpty(startChangeset))
|
||||||
|
{
|
||||||
|
cmd.rev(startChangeset.concat(":0"));
|
||||||
|
}
|
||||||
|
|
||||||
|
int start = request.getPagingStart();
|
||||||
|
int limit = request.getPagingLimit();
|
||||||
|
|
||||||
|
List<Changeset> changesets = null;
|
||||||
|
int total = 0;
|
||||||
|
|
||||||
|
if ((start == 0) && (limit < 0))
|
||||||
|
{
|
||||||
|
changesets = cmd.execute(request.getPath());
|
||||||
|
total = changesets.size();
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
limit = limit + start;
|
||||||
|
|
||||||
|
List<Integer> revisionList = cmd.loadRevisions(request.getPath());
|
||||||
|
|
||||||
|
if ((limit > revisionList.size()) || (limit < 0))
|
||||||
|
{
|
||||||
|
limit = revisionList.size();
|
||||||
|
}
|
||||||
|
|
||||||
|
total = revisionList.size();
|
||||||
|
|
||||||
|
List<Integer> sublist = revisionList.subList(start, limit);
|
||||||
|
|
||||||
|
String[] revs = new String[sublist.size()];
|
||||||
|
|
||||||
|
for (int i = 0; i < sublist.size(); i++)
|
||||||
|
{
|
||||||
|
revs[i] = sublist.get(i).toString();
|
||||||
|
}
|
||||||
|
|
||||||
|
changesets = HgLogChangesetCommand.on(repository).rev(revs).execute();
|
||||||
|
}
|
||||||
|
|
||||||
|
return new ChangesetPagingResult(total, changesets);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user