remove lastLogin attribute to improve svn and bzr performance

scm-core/src/main/java/sonia/scm/user/User.java

@@ -131,15 +131,64 @@ public class User
    *
    *
    * @param user
+   *
+   * @return
    */
-  public void copyProperties(User user)
+  public boolean copyProperties(User user)
   {
-    user.setAdmin(admin);
-    user.setDisplayName(displayName);
-    user.setMail(mail);
-    user.setName(name);
-    user.setPassword(password);
-    user.setType(type);
+    return copyProperties(user, true);
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @param user
+   * @param copyPassword
+   *
+   * @return
+   */
+  public boolean copyProperties(User user, boolean copyPassword)
+  {
+    boolean result = false;
+
+    if (user.isAdmin() != admin)
+    {
+      result = true;
+      user.setAdmin(admin);
+    }
+
+    if (Util.isNotEquals(user.getDisplayName(), displayName))
+    {
+      result = true;
+      user.setDisplayName(displayName);
+    }
+
+    if (Util.isNotEquals(user.getMail(), mail))
+    {
+      result = true;
+      user.setMail(mail);
+    }
+
+    if (Util.isNotEquals(user.getName(), name))
+    {
+      result = true;
+      user.setName(name);
+    }
+
+    if (copyPassword && Util.isNotEquals(user.getPassword(), password))
+    {
+      result = true;
+      user.setPassword(password);
+    }
+
+    if (Util.isNotEquals(user.getType(), type))
+    {
+      result = true;
+      user.setType(type);
+    }
+
+    return result;
   }
 
   /**
@@ -263,9 +312,9 @@ public class User
    *
    * @return
    */
-  public long getLastLogin()
+  public Long getLastModified()
   {
-    return lastLogin;
+    return lastModified;
   }
 
   /**
@@ -378,11 +427,11 @@ public class User
    * Method description
    *
    *
-   * @param lastLogin
+   * @param lastModified
    */
-  public void setLastLogin(long lastLogin)
+  public void setLastModified(long lastModified)
   {
-    this.lastLogin = lastLogin;
+    this.lastModified = lastModified;
   }
 
   /**
@@ -444,7 +493,7 @@ public class User
 
   /** Field description */
   @XmlJavaTypeAdapter(XmlTimestampDateAdapter.class)
-  private Long lastLogin;
+  private Long lastModified;
 
   /** Field description */
   private String mail;

scm-core/src/main/java/sonia/scm/util/Util.java

@@ -142,6 +142,33 @@ public class Util
     return parseDate(dateString, null);
   }
 
+  /**
+   * Method description
+   *
+   *
+   * @param byteValue
+   *
+   * @return
+   */
+  public static String toString(byte[] byteValue)
+  {
+    StringBuilder buffer = new StringBuilder();
+
+    for (int i = 0; i < byteValue.length; i++)
+    {
+      int x = byteValue[i] & 0xff;
+
+      if (x < 16)
+      {
+        buffer.append('0');
+      }
+
+      buffer.append(Integer.toString(x, 16));
+    }
+
+    return buffer.toString();
+  }
+
   //~--- get methods ----------------------------------------------------------
 
   /**
@@ -183,6 +210,22 @@ public class Util
     return (array == null) || (array.length == 0);
   }
 
+  /**
+   * Method description
+   *
+   *
+   * @param object
+   * @param other
+   *
+   * @return
+   */
+  public static boolean isEquals(Object object, Object other)
+  {
+    return (object == null)
+           ? other == null
+           : object.equals(other);
+  }
+
   /**
    * Method description
    *
@@ -222,32 +265,17 @@ public class Util
     return (array != null) && (array.length > 0);
   }
 
-  //~--- methods --------------------------------------------------------------
-
   /**
    * Method description
    *
    *
-   * @param byteValue
+   * @param object
+   * @param other
    *
    * @return
    */
-  public static String toString(byte[] byteValue)
+  public static boolean isNotEquals(Object object, Object other)
   {
-    StringBuilder buffer = new StringBuilder();
-
-    for (int i = 0; i < byteValue.length; i++)
-    {
-      int x = byteValue[i] & 0xff;
-
-      if (x < 16)
-      {
-        buffer.append('0');
-      }
-
-      buffer.append(Integer.toString(x, 16));
-    }
-
-    return buffer.toString();
+    return !isEquals(object, other);
   }
 }