specify jest environment for tests and use airbnb-base for node

scm-ui/eslint-config/src/index.js

@@ -22,29 +22,65 @@
  * SOFTWARE.
  */
 
-module.exports = {
+const rules = {
+  "prettier/prettier": "warn",
+  semi: ["error", "always"],
+  quotes: ["error", "double", "avoid-escape"],
+  "no-var": "error"
+};
+
+const nodeConfiguration = {
+  extends: ["airbnb-base", "plugin:prettier/recommended"],
+  rules
+};
+
+const typescriptConfiguration = {
   parser: "@typescript-eslint/parser",
-  env: {
-    node: false,
-    browser: true
-  },
-  extends: ["react-app", "plugin:prettier/recommended", "plugin:@typescript-eslint/recommended"],
+  extends: ["react-app", "plugin:@typescript-eslint/recommended"],
   rules: {
-    "prettier/prettier": "warn",
-    semi: ["error", "always"],
-    quotes: ["error", "double", "avoid-escape"],
-    "jsx-a11y/href-no-hash": [0],
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/ban-ts-ignore": "warn",
-    "no-console": "error"
-  },
+    "no-console": "error",
+    "jsx-a11y/href-no-hash": [0],
+    ...rules
+  }
+};
+
+module.exports = {
   overrides: [
+    {
+      files: ["*.test.js"],
+      env: {
+        node: true,
+        jest: true,
+        browser: false
+      },
+      ...nodeConfiguration
+    },
     {
       files: ["*.js"],
       env: {
         node: true,
         browser: false
-      }
+      },
+      ...nodeConfiguration
+    },
+    {
+      files: ["*.test.ts", "*.test.tsx"],
+      env: {
+        node: true,
+        jest: true,
+        browser: false
+      },
+      ...typescriptConfiguration
+    },
+    {
+      files: ["*.ts", "*.tsx"],
+      env: {
+        node: false,
+        browser: true
+      },
+      ...typescriptConfiguration
     }
   ]
 };

scm-ui/eslint-config/src/index.test.js

@@ -1,3 +1,27 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2020-present Cloudogu GmbH and Contributors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
 const { ESLint } = require("eslint");
 const path = require("path");
 
@@ -8,7 +32,7 @@ describe("should lint files", () => {
   const lint = async file => {
     const results = await eslint.lintFiles([path.join(resource, file)]);
 
-    const messages = results[0].messages;
+    const { messages } = results[0];
 
     const warnings = messages.filter(m => m.severity === 1).map(m => m.ruleId);
     const errors = messages.filter(m => m.severity === 2).map(m => m.ruleId);
@@ -19,10 +43,8 @@ describe("should lint files", () => {
   };
 
   const expectContains = (results, ...ids) => {
-    for (const id of ids) {
-      expect(results).toContain(id);
-    }
-  }
+    ids.forEach(id => expect(results).toContain(id));
+  };
 
   it("should lint tsx files", async () => {
     const { errors, warnings } = await lint("TypescriptWithJsx.tsx");
@@ -32,7 +54,7 @@ describe("should lint files", () => {
 
   it("should lint js files", async () => {
     const { errors, warnings } = await lint("Node.js");
-    expectContains(errors, "no-var", "no-console", "quotes", "semi");
+    expectContains(errors, "no-var", "quotes", "semi");
     expectContains(warnings, "prettier/prettier");
   });