Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-12 16:35:45 +01:00
Code Issues Packages Projects Releases Activity

use binder from context to make extensions it testable

Browse Source
This commit is contained in:
Sebastian Sdorra
2020-02-19 09:48:46 +01:00
parent 041a999a01
commit f23b464524
3 changed files with 68 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
scm-ui/ui-components/src/avatar/AvatarImage.tsx
View File

@@ -1,8 +1,8 @@
import React, { FC } from "react";
import { binder } from "@scm-manager/ui-extensions";
import { Image } from "..";
import { Person } from "./Avatar";
import { EXTENSION_POINT } from "./Avatar";
import { useBinder } from "@scm-manager/ui-extensions";
type Props = {
person: Person;
@@ -10,6 +10,7 @@ type Props = {
};
const AvatarImage: FC<Props> = ({ person, representation = "rounded-border" }) => {
const binder = useBinder();
const avatarFactory = binder.getExtension(EXTENSION_POINT);
if (avatarFactory) {
const avatar = avatarFactory(person);

17
scm-ui/ui-components/src/avatar/AvatarWrapper.tsx
View File

@@ -1,18 +1,13 @@
import React, { Component, ReactNode } from "react";
import { binder } from "@scm-manager/ui-extensions";
import React, { FC } from "react";
import { useBinder } from "@scm-manager/ui-extensions";
import { EXTENSION_POINT } from "./Avatar";
type Props = {
children: ReactNode;
};
class AvatarWrapper extends Component<Props> {
render() {
const AvatarWrapper: FC = ({ children }) => {
const binder = useBinder();
if (binder.hasExtension(EXTENSION_POINT)) {
return <>{this.props.children}</>;
return <>{children}</>;
}
return null;
}
}
};
export default AvatarWrapper;

15
scm-ui/ui-components/src/layout/Footer.tsx
View File

@@ -1,7 +1,7 @@
import React from "react";
import React, { FC } from "react";
import { Me, Links } from "@scm-manager/ui-types";
import { Link } from "react-router-dom";
import { binder } from "@scm-manager/ui-extensions";
import { useBinder } from "@scm-manager/ui-extensions";
import { AvatarWrapper, AvatarImage } from "../avatar";
type Props = {
@@ -10,13 +10,11 @@ type Props = {
links: Links;
};
class Footer extends React.Component<Props> {
render() {
const { me, version, links } = this.props;
const Footer: FC<Props> = ({ me, version, links }) => {
const binder = useBinder();
if (!me) {
return "";
return null;
}
const extensionProps = { me, links };
const extensions = binder.getExtensions("footer.links", extensionProps);
@@ -59,7 +57,6 @@ class Footer extends React.Component<Props> {
</div>
</footer>
);
}
}
};
export default Footer;