Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-12 08:25:44 +01:00
Code Issues Packages Projects Releases Activity

use binder from context to make extensions it testable

Browse Source
This commit is contained in:
Sebastian Sdorra
2020-02-19 09:48:46 +01:00
parent 041a999a01
commit f23b464524
3 changed files with 68 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scm-ui/ui-components/src/avatar/AvatarImage.tsx
View File

@@ -1,15 +1,16 @@
import React, {FC} from "react"; import React, { FC } from "react";
import { binder } from "@scm-manager/ui-extensions";
import { Image } from ".."; import { Image } from "..";
import { Person } from "./Avatar"; import { Person } from "./Avatar";
import { EXTENSION_POINT } from "./Avatar"; import { EXTENSION_POINT } from "./Avatar";
import { useBinder } from "@scm-manager/ui-extensions";
type Props = { type Props = {
person: Person; person: Person;
representation?: "rounded" | "rounded-border"; representation?: "rounded" | "rounded-border";
}; };
const AvatarImage:FC<Props> = ({person, representation = "rounded-border"}) => { const AvatarImage: FC<Props> = ({ person, representation = "rounded-border" }) => {
const binder = useBinder();
const avatarFactory = binder.getExtension(EXTENSION_POINT); const avatarFactory = binder.getExtension(EXTENSION_POINT);
if (avatarFactory) { if (avatarFactory) {
const avatar = avatarFactory(person); const avatar = avatarFactory(person);

17
scm-ui/ui-components/src/avatar/AvatarWrapper.tsx
View File

@@ -1,18 +1,13 @@
import React, { Component, ReactNode } from "react"; import React, { FC } from "react";
import { binder } from "@scm-manager/ui-extensions"; import { useBinder } from "@scm-manager/ui-extensions";
import { EXTENSION_POINT } from "./Avatar"; import { EXTENSION_POINT } from "./Avatar";
type Props = { const AvatarWrapper: FC = ({ children }) => {
children: ReactNode; const binder = useBinder();
};
class AvatarWrapper extends Component<Props> {
render() {
if (binder.hasExtension(EXTENSION_POINT)) { if (binder.hasExtension(EXTENSION_POINT)) {
return <>{this.props.children}</>; return <>{children}</>;
} }
return null; return null;
} };
}
export default AvatarWrapper; export default AvatarWrapper;

15
scm-ui/ui-components/src/layout/Footer.tsx
View File

@@ -1,7 +1,7 @@
import React from "react"; import React, { FC } from "react";
import { Me, Links } from "@scm-manager/ui-types"; import { Me, Links } from "@scm-manager/ui-types";
import { Link } from "react-router-dom"; import { Link } from "react-router-dom";
import { binder } from "@scm-manager/ui-extensions"; import { useBinder } from "@scm-manager/ui-extensions";
import { AvatarWrapper, AvatarImage } from "../avatar"; import { AvatarWrapper, AvatarImage } from "../avatar";
type Props = { type Props = {
@@ -10,13 +10,11 @@ type Props = {
links: Links; links: Links;
}; };
class Footer extends React.Component<Props> { const Footer: FC<Props> = ({ me, version, links }) => {
render() { const binder = useBinder();
const { me, version, links } = this.props;
if (!me) { if (!me) {
return ""; return null;
} }
const extensionProps = { me, links }; const extensionProps = { me, links };
const extensions = binder.getExtensions("footer.links", extensionProps); const extensions = binder.getExtensions("footer.links", extensionProps);
@@ -59,7 +57,6 @@ class Footer extends React.Component<Props> {
</div> </div>
</footer> </footer>
); );
} };
}
export default Footer; export default Footer;