Clean up exceptions

- Remove declared IOException
- Fix repetition of exception messages
This commit is contained in:
René Pfeuffer
2018-06-29 09:34:31 +02:00
parent d29f9ea2d8
commit e7ea9e686e
15 changed files with 86 additions and 175 deletions

View File

@@ -137,7 +137,7 @@ public class DefaultUserManager extends AbstractUserManager
* @throws UserException
*/
@Override
public void create(User user) throws UserException, IOException
public void create(User user) throws UserException
{
String type = user.getType();
@@ -155,7 +155,7 @@ public class DefaultUserManager extends AbstractUserManager
if (userDAO.contains(user.getName()))
{
throw new UserAlreadyExistsException(user.getName().concat(" user already exists"));
throw new UserAlreadyExistsException(user.getName());
}
AssertUtil.assertIsValid(user);
@@ -175,7 +175,7 @@ public class DefaultUserManager extends AbstractUserManager
* @throws UserException
*/
@Override
public void delete(User user) throws UserException, IOException
public void delete(User user) throws UserException
{
if (logger.isInfoEnabled())
{
@@ -193,7 +193,7 @@ public class DefaultUserManager extends AbstractUserManager
}
else
{
throw new UserNotFoundException("user does not exists");
throw new UserNotFoundException();
}
}
@@ -224,7 +224,7 @@ public class DefaultUserManager extends AbstractUserManager
* @throws UserException
*/
@Override
public void modify(User user) throws UserException, IOException
public void modify(User user) throws UserException
{
String name = user.getName();
if (logger.isInfoEnabled())
@@ -245,7 +245,7 @@ public class DefaultUserManager extends AbstractUserManager
}
else
{
throw new UserNotFoundException("user does not exists");
throw new UserNotFoundException();
}
}
@@ -259,7 +259,7 @@ public class DefaultUserManager extends AbstractUserManager
* @throws UserException
*/
@Override
public void refresh(User user) throws UserException, IOException
public void refresh(User user) throws UserException
{
if (logger.isInfoEnabled())
{
@@ -271,7 +271,7 @@ public class DefaultUserManager extends AbstractUserManager
if (fresh == null)
{
throw new UserNotFoundException("user does not exists");
throw new UserNotFoundException();
}
fresh.copyProperties(user);