Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-06 13:35:44 +01:00
Code Issues Packages Projects Releases Activity

Clean up exceptions

Browse Source 
- Remove declared IOException
- Fix repetition of exception messages
This commit is contained in:
René Pfeuffer
2018-06-29 09:34:31 +02:00
parent d29f9ea2d8
commit e7ea9e686e
15 changed files with 86 additions and 175 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
scm-webapp/src/main/java/sonia/scm/group/DefaultGroupManager.java
View File

@@ -51,7 +51,12 @@ import sonia.scm.util.CollectionAppender;
import sonia.scm.util.Util;
import java.io.IOException;
import java.util.*;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.Comparator;
import java.util.LinkedList;
import java.util.List;
//~--- JDK imports ------------------------------------------------------------
@@ -106,7 +111,7 @@ public class DefaultGroupManager extends AbstractGroupManager
* @throws IOException
*/
@Override
public void create(Group group) throws GroupException, IOException
public void create(Group group) throws GroupException
{
String type = group.getType();
@@ -127,7 +132,7 @@ public class DefaultGroupManager extends AbstractGroupManager
if (groupDAO.contains(name))
{
throw new GroupAlreadyExistsException(name.concat(" group already exists"));
throw new GroupAlreadyExistsException(name);
}
removeDuplicateMembers(group);
@@ -147,7 +152,7 @@ public class DefaultGroupManager extends AbstractGroupManager
* @throws IOException
*/
@Override
public void delete(Group group) throws GroupException, IOException
public void delete(Group group) throws GroupException
{
if (logger.isInfoEnabled())
{
@@ -166,7 +171,7 @@ public class DefaultGroupManager extends AbstractGroupManager
}
else
{
throw new GroupNotFoundException("user does not exists");
throw new GroupNotFoundException();
}
}
@@ -189,7 +194,7 @@ public class DefaultGroupManager extends AbstractGroupManager
* @throws IOException
*/
@Override
public void modify(Group group) throws GroupException, IOException
public void modify(Group group) throws GroupException
{
if (logger.isInfoEnabled())
{
@@ -212,7 +217,7 @@ public class DefaultGroupManager extends AbstractGroupManager
}
else
{
throw new GroupNotFoundException("group does not exists");
throw new GroupNotFoundException();
}
}
@@ -226,7 +231,7 @@ public class DefaultGroupManager extends AbstractGroupManager
* @throws IOException
*/
@Override
public void refresh(Group group) throws GroupException, IOException
public void refresh(Group group) throws GroupException
{
String name = group.getName();
if (logger.isInfoEnabled())
@@ -239,7 +244,7 @@ public class DefaultGroupManager extends AbstractGroupManager
if (fresh == null)
{
throw new GroupNotFoundException("group does not exists");
throw new GroupNotFoundException();
}
fresh.copyProperties(group);