Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-09 15:05:44 +01:00
Code Issues Packages Projects Releases Activity

Do not fail on error 502 during restart actions (#1941)

Browse Source 
In some rare cases a reverse proxy stops forwarding traffic to scm,
before the response is returned to scm.
In such a case the reverse proxy returns 502 (bad gateway),
so we treat 502 not as error for restart actions.

Co-authored-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
This commit is contained in:
Sebastian Sdorra
2022-02-02 10:02:46 +01:00
committed by GitHub
parent c155d1eb4a
commit dff5d3aa5b
5 changed files with 116 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
scm-ui/ui-api/src/apiclient.test.ts
View File

@@ -24,7 +24,7 @@
import { apiClient, createUrl, extractXsrfTokenFromCookie } from "./apiclient";
import fetchMock from "fetch-mock";
import { BackendError } from "./errors";
import { BackendError, BadGatewayError } from "./errors";
describe("create url", () => {
it("should not change absolute urls", () => {
@@ -45,9 +45,9 @@ describe("error handling tests", () => {
context: [
{
type: "planet",
id: "earth",
},
],
id: "earth"
}
]
};
afterEach(() => {
@@ -55,9 +55,9 @@ describe("error handling tests", () => {
fetchMock.restore();
});
it("should create a normal error, if the content type is not scmm-error", (done) => {
it("should create a normal error, if the content type is not scmm-error", done => {
fetchMock.getOnce("/api/v2/error", {
status: 404,
status: 404
});
apiClient.get("/error").catch((err: Error) => {
@@ -67,13 +67,24 @@ describe("error handling tests", () => {
});
});
it("should create an backend error, if the content type is scmm-error", (done) => {
it("should create a bad gateway error", done => {
fetchMock.getOnce("/api/v2/error", {
status: 502
});
apiClient.get("/error").catch((err: Error) => {
expect(err).toBeInstanceOf(BadGatewayError);
done();
});
});
it("should create an backend error, if the content type is scmm-error", done => {
fetchMock.getOnce("/api/v2/error", {
status: 404,
headers: {
"Content-Type": "application/vnd.scmm-error+json;v=2",
"Content-Type": "application/vnd.scmm-error+json;v=2"
},
body: earthNotFoundError,
body: earthNotFoundError
});
apiClient.get("/error").catch((err: BackendError) => {
@@ -87,8 +98,8 @@ describe("error handling tests", () => {
expect(err.context).toEqual([
{
type: "planet",
id: "earth",
},
id: "earth"
}
]);
done();
});