Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-09 15:05:44 +01:00
Code Issues Packages Projects Releases Activity

move dto parameters to constructor in order to create an immutable object

Browse Source
This commit is contained in:
Sebastian Sdorra
2019-03-13 10:01:46 +01:00
parent be12167f0a
commit dea5732141
2 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scm-webapp/src/main/java/sonia/scm/api/v2/resources/NamespaceStrategiesDto.java
View File

@@ -12,7 +12,9 @@ public class NamespaceStrategiesDto extends HalRepresentation {
private String current;
private List<String> available;
public NamespaceStrategiesDto(Links links) {
public NamespaceStrategiesDto(String current, List<String> available, Links links) {
super(links);
this.current = current;
this.available = available;
}
}

7
scm-webapp/src/main/java/sonia/scm/api/v2/resources/NamespaceStrategyResource.java
View File

@@ -43,15 +43,10 @@ public class NamespaceStrategyResource {
@Path("")
@Produces(VndMediaType.NAMESPACE_STRATEGIES)
public NamespaceStrategiesDto get(@Context UriInfo uriInfo) {
NamespaceStrategiesDto dto = new NamespaceStrategiesDto(createLinks(uriInfo));
String currentStrategy = strategyAsString(namespaceStrategyProvider.get());
dto.setCurrent(currentStrategy);
List<String> availableStrategies = collectStrategyNames();
dto.setAvailable(availableStrategies);
return dto;
return new NamespaceStrategiesDto(currentStrategy, availableStrategies, createLinks(uriInfo));
}
private Links createLinks(@Context UriInfo uriInfo) {