improve user validation

This commit is contained in:
Sebastian Sdorra
2011-01-04 17:17:48 +01:00
parent 3254eda64e
commit dd4468664d

View File

@@ -52,6 +52,7 @@ import sonia.scm.user.AbstractUserManager;
import sonia.scm.user.User; import sonia.scm.user.User;
import sonia.scm.user.UserAllreadyExistException; import sonia.scm.user.UserAllreadyExistException;
import sonia.scm.user.UserException; import sonia.scm.user.UserException;
import sonia.scm.util.AssertUtil;
import sonia.scm.util.IOUtil; import sonia.scm.util.IOUtil;
import sonia.scm.util.SecurityUtil; import sonia.scm.util.SecurityUtil;
import sonia.scm.util.Util; import sonia.scm.util.Util;
@@ -163,6 +164,8 @@ public class XmlUserManager extends AbstractUserManager
throw new ScmSecurityException("admin account is required"); throw new ScmSecurityException("admin account is required");
} }
AssertUtil.assertIsValid(user);
if (userDB.contains(user.getName())) if (userDB.contains(user.getName()))
{ {
throw new UserAllreadyExistException(); throw new UserAllreadyExistException();
@@ -266,6 +269,8 @@ public class XmlUserManager extends AbstractUserManager
throw new ScmSecurityException("admin account is required"); throw new ScmSecurityException("admin account is required");
} }
AssertUtil.assertIsValid(user);
String name = user.getName(); String name = user.getName();
if (userDB.contains(name)) if (userDB.contains(name))