pass supported repository commands to scm state

This commit is contained in:
Sebastian Sdorra
2012-08-03 07:50:04 +02:00
parent f6dac33e22
commit d919338cc2
7 changed files with 125 additions and 27 deletions

View File

@@ -0,0 +1,90 @@
/**
* Copyright (c) 2010, Sebastian Sdorra All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer. 2. Redistributions in
* binary form must reproduce the above copyright notice, this list of
* conditions and the following disclaimer in the documentation and/or other
* materials provided with the distribution. 3. Neither the name of SCM-Manager;
* nor the names of its contributors may be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR
* ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* http://bitbucket.org/sdorra/scm-manager
*
*/
package sonia.scm.repository;
//~--- non-JDK imports --------------------------------------------------------
import sonia.scm.Type;
import sonia.scm.repository.api.Command;
//~--- JDK imports ------------------------------------------------------------
import java.util.Set;
/**
*
* @author Sebastian Sdorra
* @since 1.18
*/
public class RepositoryType extends Type
{
/**
* Constructs {@link RepositoryType} object.
* This constructor is required for JAXB.
*
*/
public RepositoryType() {}
/**
* Constructs ...
*
*
* @param name
* @param displayName
* @param supportedCommands
*/
public RepositoryType(String name, String displayName,
Set<Command> supportedCommands)
{
super(name, displayName);
this.supportedCommands = supportedCommands;
}
//~--- get methods ----------------------------------------------------------
/**
* Method description
*
*
* @return
*/
public Set<Command> getSupportedCommands()
{
return supportedCommands;
}
//~--- fields ---------------------------------------------------------------
/** Field description */
private Set<Command> supportedCommands;
}

View File

@@ -44,6 +44,7 @@ import org.eclipse.jgit.storage.file.FileRepositoryBuilder;
import sonia.scm.Type; import sonia.scm.Type;
import sonia.scm.io.FileSystem; import sonia.scm.io.FileSystem;
import sonia.scm.plugin.ext.Extension; import sonia.scm.plugin.ext.Extension;
import sonia.scm.repository.spi.GitRepositoryServiceProvider;
import sonia.scm.store.StoreFactory; import sonia.scm.store.StoreFactory;
import sonia.scm.util.AssertUtil; import sonia.scm.util.AssertUtil;
@@ -59,7 +60,7 @@ import java.io.IOException;
@Singleton @Singleton
@Extension @Extension
public class GitRepositoryHandler public class GitRepositoryHandler
extends AbstractSimpleRepositoryHandler<GitConfig> extends AbstractSimpleRepositoryHandler<GitConfig>
{ {
/** Field description */ /** Field description */
@@ -76,7 +77,9 @@ public class GitRepositoryHandler
public static final String TYPE_NAME = "git"; public static final String TYPE_NAME = "git";
/** Field description */ /** Field description */
public static final Type TYPE = new Type(TYPE_NAME, TYPE_DISPLAYNAME); public static final Type TYPE = new RepositoryType(TYPE_NAME,
TYPE_DISPLAYNAME,
GitRepositoryServiceProvider.COMMANDS);
//~--- constructors --------------------------------------------------------- //~--- constructors ---------------------------------------------------------
@@ -254,7 +257,7 @@ public class GitRepositoryHandler
*/ */
@Override @Override
protected void create(Repository repository, File directory) protected void create(Repository repository, File directory)
throws RepositoryException, IOException throws RepositoryException, IOException
{ {
FileRepository fr = null; FileRepository fr = null;

View File

@@ -55,7 +55,7 @@ public class GitRepositoryServiceProvider extends RepositoryServiceProvider
{ {
/** Field description */ /** Field description */
private static final Set<Command> COMMANDS = ImmutableSet.of(Command.BLAME, public static final Set<Command> COMMANDS = ImmutableSet.of(Command.BLAME,
Command.BROWSE, Command.CAT, Command.BROWSE, Command.CAT,
Command.DIFF, Command.LOG, Command.DIFF, Command.LOG,
Command.TAGS, Command.TAGS,

View File

@@ -55,6 +55,7 @@ import sonia.scm.io.INIConfigurationReader;
import sonia.scm.io.INIConfigurationWriter; import sonia.scm.io.INIConfigurationWriter;
import sonia.scm.io.INISection; import sonia.scm.io.INISection;
import sonia.scm.plugin.ext.Extension; import sonia.scm.plugin.ext.Extension;
import sonia.scm.repository.spi.HgRepositoryServiceProvider;
import sonia.scm.store.StoreFactory; import sonia.scm.store.StoreFactory;
import sonia.scm.util.AssertUtil; import sonia.scm.util.AssertUtil;
import sonia.scm.util.IOUtil; import sonia.scm.util.IOUtil;
@@ -80,7 +81,7 @@ import javax.xml.bind.JAXBException;
@Singleton @Singleton
@Extension @Extension
public class HgRepositoryHandler public class HgRepositoryHandler
extends AbstractSimpleRepositoryHandler<HgConfig> extends AbstractSimpleRepositoryHandler<HgConfig>
{ {
/** Field description */ /** Field description */
@@ -97,7 +98,9 @@ public class HgRepositoryHandler
public static final String TYPE_NAME = "hg"; public static final String TYPE_NAME = "hg";
/** Field description */ /** Field description */
public static final Type TYPE = new Type(TYPE_NAME, TYPE_DISPLAYNAME); public static final Type TYPE = new RepositoryType(TYPE_NAME,
TYPE_DISPLAYNAME,
HgRepositoryServiceProvider.COMMANDS);
/** the logger for HgRepositoryHandler */ /** the logger for HgRepositoryHandler */
private static final Logger logger = private static final Logger logger =
@@ -119,7 +122,7 @@ public class HgRepositoryHandler
*/ */
@Inject @Inject
public HgRepositoryHandler(StoreFactory storeFactory, FileSystem fileSystem, public HgRepositoryHandler(StoreFactory storeFactory, FileSystem fileSystem,
Provider<HgContext> hgContextProvider) Provider<HgContext> hgContextProvider)
{ {
super(storeFactory, fileSystem); super(storeFactory, fileSystem);
this.hgContextProvider = hgContextProvider; this.hgContextProvider = hgContextProvider;
@@ -127,8 +130,8 @@ public class HgRepositoryHandler
try try
{ {
this.jaxbContext = JAXBContext.newInstance(BrowserResult.class, this.jaxbContext = JAXBContext.newInstance(BrowserResult.class,
BlameResult.class, Changeset.class, ChangesetPagingResult.class, BlameResult.class, Changeset.class, ChangesetPagingResult.class,
HgVersion.class); HgVersion.class);
} }
catch (JAXBException ex) catch (JAXBException ex)
{ {
@@ -153,7 +156,7 @@ public class HgRepositoryHandler
if (logger.isDebugEnabled()) if (logger.isDebugEnabled())
{ {
logger.debug("installing mercurial with {}", logger.debug("installing mercurial with {}",
installer.getClass().getName()); installer.getClass().getName());
} }
installer.install(baseDirectory, autoConfig); installer.install(baseDirectory, autoConfig);
@@ -164,9 +167,8 @@ public class HgRepositoryHandler
{ {
if (logger.isErrorEnabled()) if (logger.isErrorEnabled())
{ {
logger.error( logger.error("Could not write Hg CGI for inital config. "
"Could not write Hg CGI for inital config. " + "HgWeb may not function until a new Hg config is set", ioe);
+ "HgWeb may not function until a new Hg config is set", ioe);
} }
} }
} }
@@ -224,7 +226,7 @@ public class HgRepositoryHandler
if (TYPE_NAME.equals(type)) if (TYPE_NAME.equals(type))
{ {
blameViewer = new HgBlameViewer(this, hgContextProvider.get(), blameViewer = new HgBlameViewer(this, hgContextProvider.get(),
repository); repository);
} }
else else
{ {
@@ -256,7 +258,7 @@ public class HgRepositoryHandler
if (TYPE_NAME.equals(type)) if (TYPE_NAME.equals(type))
{ {
changesetViewer = new HgChangesetViewer(this, jaxbContext, changesetViewer = new HgChangesetViewer(this, jaxbContext,
hgContextProvider.get(), repository); hgContextProvider.get(), repository);
} }
else else
{ {
@@ -278,7 +280,7 @@ public class HgRepositoryHandler
*/ */
@Override @Override
public DiffViewer getDiffViewer(Repository repository) public DiffViewer getDiffViewer(Repository repository)
throws RepositoryException throws RepositoryException
{ {
DiffViewer diffViewer = null; DiffViewer diffViewer = null;
@@ -374,7 +376,7 @@ public class HgRepositoryHandler
} }
version = MessageFormat.format(version, hgVersion.getPython(), version = MessageFormat.format(version, hgVersion.getPython(),
hgVersion.getMercurial()); hgVersion.getMercurial());
} }
else if (logger.isWarnEnabled()) else if (logger.isWarnEnabled())
{ {
@@ -478,7 +480,7 @@ public class HgRepositoryHandler
* @return * @return
*/ */
HgChangesetViewer getChangesetViewer(File repositoryDirectory, HgChangesetViewer getChangesetViewer(File repositoryDirectory,
HgContext context) HgContext context)
{ {
AssertUtil.assertIsNotNull(repositoryDirectory); AssertUtil.assertIsNotNull(repositoryDirectory);
AssertUtil.assertIsNotNull(context); AssertUtil.assertIsNotNull(context);
@@ -503,7 +505,7 @@ public class HgRepositoryHandler
{ {
hooksSection.setParameter("changegroup.scm", "python:scmhooks.callback"); hooksSection.setParameter("changegroup.scm", "python:scmhooks.callback");
hooksSection.setParameter("pretxnchangegroup.scm", hooksSection.setParameter("pretxnchangegroup.scm",
"python:scmhooks.callback"); "python:scmhooks.callback");
} }
/** /**
@@ -532,7 +534,7 @@ public class HgRepositoryHandler
*/ */
@Override @Override
protected ExtendedCommand buildCreateCommand(Repository repository, protected ExtendedCommand buildCreateCommand(Repository repository,
File directory) File directory)
{ {
ExtendedCommand cmd = new ExtendedCommand(config.getHgBinary(), "init", ExtendedCommand cmd = new ExtendedCommand(config.getHgBinary(), "init",
directory.getAbsolutePath()); directory.getAbsolutePath());
@@ -555,7 +557,7 @@ public class HgRepositoryHandler
*/ */
@Override @Override
protected void postCreate(Repository repository, File directory) protected void postCreate(Repository repository, File directory)
throws IOException, RepositoryException throws IOException, RepositoryException
{ {
File hgrcFile = new File(directory, PATH_HGRC); File hgrcFile = new File(directory, PATH_HGRC);
INIConfiguration hgrc = new INIConfiguration(); INIConfiguration hgrc = new INIConfiguration();
@@ -597,7 +599,7 @@ public class HgRepositoryHandler
* @return * @return
*/ */
private boolean appendHook(String repositoryName, INISection hooks, private boolean appendHook(String repositoryName, INISection hooks,
String hookName) String hookName)
{ {
boolean write = false; boolean write = false;
String hook = hooks.getParameter(hookName); String hook = hooks.getParameter(hookName);
@@ -607,7 +609,7 @@ public class HgRepositoryHandler
if (logger.isInfoEnabled()) if (logger.isInfoEnabled())
{ {
logger.info("register missing {} hook for respository {}", hookName, logger.info("register missing {} hook for respository {}", hookName,
repositoryName); repositoryName);
} }
hooks.setParameter(hookName, "python:scmhooks.callback"); hooks.setParameter(hookName, "python:scmhooks.callback");
@@ -728,7 +730,7 @@ public class HgRepositoryHandler
else if (logger.isDebugEnabled()) else if (logger.isDebugEnabled())
{ {
logger.debug( logger.debug(
"repository directory does not exists, could not register missing hooks"); "repository directory does not exists, could not register missing hooks");
} }
} }
else if (logger.isDebugEnabled()) else if (logger.isDebugEnabled())

View File

@@ -59,7 +59,7 @@ public class HgRepositoryServiceProvider extends RepositoryServiceProvider
{ {
/** Field description */ /** Field description */
private static final Set<Command> COMMANDS = ImmutableSet.of(Command.BLAME, public static final Set<Command> COMMANDS = ImmutableSet.of(Command.BLAME,
Command.BROWSE, Command.CAT, Command.BROWSE, Command.CAT,
Command.DIFF, Command.LOG, Command.DIFF, Command.LOG,
Command.TAGS, Command.TAGS,

View File

@@ -53,6 +53,7 @@ import sonia.scm.Type;
import sonia.scm.io.FileSystem; import sonia.scm.io.FileSystem;
import sonia.scm.logging.SVNKitLogger; import sonia.scm.logging.SVNKitLogger;
import sonia.scm.plugin.ext.Extension; import sonia.scm.plugin.ext.Extension;
import sonia.scm.repository.spi.SvnRepositoryServiceProvider;
import sonia.scm.store.StoreFactory; import sonia.scm.store.StoreFactory;
import sonia.scm.util.AssertUtil; import sonia.scm.util.AssertUtil;
import sonia.scm.util.Util; import sonia.scm.util.Util;
@@ -86,7 +87,9 @@ public class SvnRepositoryHandler
public static final String TYPE_NAME = "svn"; public static final String TYPE_NAME = "svn";
/** Field description */ /** Field description */
public static final Type TYPE = new Type(TYPE_NAME, TYPE_DISPLAYNAME); public static final Type TYPE = new RepositoryType(TYPE_NAME,
TYPE_DISPLAYNAME,
SvnRepositoryServiceProvider.COMMANDS);
/** the logger for SvnRepositoryHandler */ /** the logger for SvnRepositoryHandler */
private static final Logger logger = private static final Logger logger =

View File

@@ -52,7 +52,7 @@ public class SvnRepositoryServiceProvider extends RepositoryServiceProvider
{ {
/** Field description */ /** Field description */
private static final Set<Command> COMMANDS = ImmutableSet.of(Command.BLAME, public static final Set<Command> COMMANDS = ImmutableSet.of(Command.BLAME,
Command.BROWSE, Command.CAT, Command.BROWSE, Command.CAT,
Command.DIFF, Command.LOG); Command.DIFF, Command.LOG);