Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-12-22 00:09:47 +01:00
Code Issues Packages Projects Releases Activity

Do not fork ui-script commands

Browse Source 
Forking of the commands could lead to open processes,
even if the parent was stopped with ctrl+c.
This commit is contained in:
Sebastian Sdorra
2021-01-13 08:32:33 +01:00
committed by René Pfeuffer
parent 0a4b5d0439
commit d8a04a1113
6 changed files with 90 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
scm-ui/ui-scripts/bin/ui-scripts.js
View File

@@ -22,10 +22,20 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
/* eslint-disable no-console */
const { spawnSync } = require("child_process");
const commands = ["plugin", "plugin-watch", "plugin-publish", "publish", "version"];
const fs = require("fs");
const path = require("path");
const commandDir = path.join(__dirname, "../src/commands");
const commands = fs
.readdirSync(commandDir)
.map(script => {
if (script.endsWith(".js")) {
return script.replace(".js", "");
}
return undefined;
})
.filter(cmd => !!cmd);
const args = process.argv.slice(2);
@@ -33,33 +43,14 @@ const commandIndex = args.findIndex(arg => {
return commands.includes(arg);
});
const command = commandIndex === -1 ? args[0] : args[commandIndex];
const nodeArgs = commandIndex > 0 ? args.slice(0, commandIndex) : [];
if (commands.includes(command)) {
const result = spawnSync(
"node",
nodeArgs.concat(require.resolve(`../src/commands/${command}`)).concat(args.slice(commandIndex + 1)),
{ stdio: "inherit" }
);
if (result.signal) {
if (result.signal === "SIGKILL") {
console.log(
"The build failed because the process exited too early. " +
"This probably means the system ran out of memory or someone called " +
"`kill -9` on the process."
);
} else if (result.signal === "SIGTERM") {
console.log(
"The build failed because the process exited too early. " +
"Someone might have called `kill` or `killall`, or the system could " +
"be shutting down."
);
}
process.exit(1);
}
process.exit(result.status);
const commandName = commandIndex === -1 ? args[0] : args[commandIndex];
if (!commandName) {
console.log(`Use plugin-scripts [${commands.join(", ")}]`);
} else if (commands.includes(commandName)) {
// eslint-disable-next-line
const command = require(path.join(commandDir, `${commandName}.js`));
command(args.slice(commandIndex + 1));
} else {
console.log(`Unknown script "${command}".`);
console.log("Perhaps you need to update ui-scripts?");
console.log(`Unknown script "${commandName}".`);
console.log("Perhaps you need to update plugin-scripts?");
}