Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-11 16:05:44 +01:00
Code Issues Packages Projects Releases Activity

improve logging

Browse Source
This commit is contained in:
Sebastian Sdorra
2011-11-20 14:05:19 +01:00
parent 4027a824c8
commit d2b2d188e6
2 changed files with 40 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
scm-clients/scm-client-impl/src/main/java/sonia/scm/client/AbstractClientHandler.java
View File

@@ -35,6 +35,9 @@ package sonia.scm.client;
//~--- non-JDK imports -------------------------------------------------------- //~--- non-JDK imports --------------------------------------------------------
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import sonia.scm.ModelObject; import sonia.scm.ModelObject;
import sonia.scm.url.UrlProvider; import sonia.scm.url.UrlProvider;
import sonia.scm.util.AssertUtil; import sonia.scm.util.AssertUtil;
@@ -58,6 +61,12 @@ public abstract class AbstractClientHandler<T extends ModelObject>
implements ClientHandler<T> implements ClientHandler<T>
{ {
/** the logger for AbstractClientHandler */
private static final Logger logger =
LoggerFactory.getLogger(AbstractClientHandler.class);
//~--- constructors ---------------------------------------------------------
/** /**
* Constructs ... * Constructs ...
* *
@@ -234,7 +243,15 @@ public abstract class AbstractClientHandler<T extends ModelObject>
public List<T> getAll() public List<T> getAll()
{ {
List<T> items = null; List<T> items = null;
WebResource resource = client.resource(getItemsUrl()); String url = getItemsUrl();
if (logger.isDebugEnabled())
{
logger.debug("fetch all items of {} from url", itemClass.getSimpleName(),
url);
}
WebResource resource = client.resource(url);
ClientResponse response = null; ClientResponse response = null;
try try
@@ -284,6 +301,11 @@ public abstract class AbstractClientHandler<T extends ModelObject>
*/ */
protected T getItemByUrl(String url) protected T getItemByUrl(String url)
{ {
if (logger.isDebugEnabled())
{
logger.debug("fetch item {} from url {}", itemClass.getSimpleName(), url);
}
T item = null; T item = null;
WebResource resource = client.resource(url); WebResource resource = client.resource(url);
ClientResponse response = null; ClientResponse response = null;
@@ -321,5 +343,4 @@ public abstract class AbstractClientHandler<T extends ModelObject>
/** Field description */ /** Field description */
private Class<T> itemClass; private Class<T> itemClass;
;
} }

21
scm-clients/scm-client-impl/src/main/java/sonia/scm/client/JerseyClientProvider.java
View File

@@ -124,8 +124,14 @@ public class JerseyClientProvider implements ScmClientProvider
if (Util.isNotEmpty(username) && Util.isNotEmpty(password)) if (Util.isNotEmpty(username) && Util.isNotEmpty(password))
{ {
WebResource resource = ClientUtil.createResource(client, String authUrl = urlProvider.getAuthenticationUrl();
urlProvider.getAuthenticationUrl(),
if (logger.isDebugEnabled())
{
logger.debug("try login at {}", authUrl);
}
WebResource resource = ClientUtil.createResource(client, authUrl,
enableLogging); enableLogging);
if (logger.isDebugEnabled()) if (logger.isDebugEnabled())
@@ -142,8 +148,15 @@ public class JerseyClientProvider implements ScmClientProvider
} }
else else
{ {
WebResource resource = ClientUtil.createResource(client, String stateUrl = urlProvider.getStateUrl();
urlProvider.getStateUrl(), enableLogging);
if (logger.isDebugEnabled())
{
logger.debug("retrive state from {}", stateUrl);
}
WebResource resource = ClientUtil.createResource(client, stateUrl,
enableLogging);
if (logger.isDebugEnabled()) if (logger.isDebugEnabled())
{ {