From d273b19f683adb8fc1ba8b966a46793a7ae1cdcf Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Wed, 14 Oct 2020 10:47:03 +0200
Subject: [PATCH] add null check on parsing svn properties in browsecommand

---
 CHANGELOG.md                                  |  1 +
 .../scm/repository/spi/SvnBrowseCommand.java  | 33 +++++++++++--------
 2 files changed, 20 insertions(+), 14 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e94d216088..e14e58db6a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Unreleased
 ### Fixed
 - Null Pointer Exception on anonymous migration with deleted repositories ([#1371](https://github.com/scm-manager/scm-manager/pull/1371))
+- Null Pointer Exception on parsing SVN properties ([#1373](https://github.com/scm-manager/scm-manager/pull/1373))
 
 ## [2.7.0] - 2020-10-12
 ### Added
diff --git a/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/repository/spi/SvnBrowseCommand.java b/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/repository/spi/SvnBrowseCommand.java
index 00a135dd82..e83a0dc365 100644
--- a/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/repository/spi/SvnBrowseCommand.java
+++ b/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/repository/spi/SvnBrowseCommand.java
@@ -193,23 +193,28 @@ public class SvnBrowseCommand extends AbstractSvnCommand
 
       repository.getDir(entry.getRelativePath(), revision, properties, (Collection) null);
 
-      String[] externals = properties.getStringValue(SVNProperty.EXTERNALS).split("\\r?\\n");
-      for (String external : externals) {
-        String subRepoUrl = "";
-        String subRepoPath = "";
-        for (String externalPart : external.split(" ")) {
-          if (shouldSetExternal(externalPart)) {
-            subRepoUrl = externalPart;
-          } else if (!externalPart.contains("-r")) {
-            subRepoPath = externalPart;
+      String externals = properties.getStringValue(SVNProperty.EXTERNALS);
+
+      if (!Strings.isNullOrEmpty(externals)) {
+        String[] splitExternals = externals.split("\\r?\\n");
+        for (String external : splitExternals) {
+          String subRepoUrl = "";
+          String subRepoPath = "";
+          for (String externalPart : external.split(" ")) {
+            if (shouldSetExternal(externalPart)) {
+              subRepoUrl = externalPart;
+            } else if (!externalPart.contains("-r")) {
+              subRepoPath = externalPart;
+            }
+          }
+
+          if (Util.isNotEmpty(external)) {
+            SubRepository subRepository = new SubRepository(subRepoUrl);
+            fileObject.addChild(createSubRepoDirectory(subRepository, subRepoPath));
           }
         }
-
-        if (Util.isNotEmpty(external)) {
-          SubRepository subRepository = new SubRepository(subRepoUrl);
-          fileObject.addChild(createSubRepoDirectory(subRepository, subRepoPath));
-        }
       }
+
     } catch (SVNException ex) {
       logger.error("could not fetch file properties", ex);
     }